Charm for ServerDensity sd-agent

[Wes Mason]

Server Density (https://www.serverdensity.com/) is a server/website monitoring SaaS platform with an open source python agent (https://github.com/serverdensity/sd-agent) which periodically sends metrics back to the service for alerting and analysis (graphs etc.)

This is a subordinate charm that automatically installs the agent into a unit and allows it's configuration, as well as allowing the querying and creation of devices via the SD v2 API.

[Marco Ceppi (marcoceppi)]

Hi Wes, sorry for the delay in response! First, I wanted to thank you for taking the time to work on this charm! It'll be a fantastic to have this in our charm store. The queue is a little backed up but we should be getting a review of this charm done this week.

Within the next few days myself or another Juju Charmer will be replying to this bug with an initial review of the charm and all, if any, feedback required to get it in the charm store.

Thanks for your patience and investing time in working on this charm!

[Wes Mason (wesmason)]

Cheers!
I can guess that a lack of testing will come up, in which case I'm all open to suggestions on the best way to test the charm. :)

[Charles Butler (lazypower)]

Greetings Wes,

Thank you for your submission to the charm store! I've deployed the Server Density agent, and I am pleased to report the following:

charm proof: no output! excellent, moving to the next phase.

Minor Knitpicks: The hooks are missing a set -e flag. This is the bare minimum for bash based scripts so they don't go rogue and halt on error, giving the user a chance to correct any misbehavior from the charm.

aside from that, everything looks to be in order. I had fun attaching the SD charm to deployed units, and continued to test the charm after its review phase was complete so I could get a better grasp of what the Server Density dash is giving us as a PAAS.

This is an excellent addition to the monitoring charms available in the store. With the only comment being such a minor knitpick I'm perfectly happy to sponsor this charm being accepted to the charm store. Its clear you've put in some excellent work here and I look forward to future iterations of the charm.

Thank you again for your submission!

[Charles Butler (lazypower)]

Ah I apologize, on my last pass through the charm I did come up with one thing that blocks this momentarily:

There is a juju-info relationship in metadata.yaml - juju-info is a default, and reserved relationship interface. The simple fix here is to rename the relationship to something specific to what your charm is doing, such as "data-emitter" or "serverdensity". its line 15 in metadata.yaml.

Simply rename the relationship, and upon resubmission you will have my whole hearted +1 and promulgation to the store will begin.

Thanks again Wes! Great work!

[Charles Butler (lazypower)]

Thank you so much for your submission. I've promulgated your charm to the charm store. You can deploy server density at any time now by typing

juju deploy serverdensity

You can find the bugs open against the serverdensity charm: https://bugs.launchpad.net/charms/precise/+source/serverdensity

Thanks again!