Comment 3 for bug 1252526

Thank you both for your contributions!

Patrick,

It seems you never subscribed the charmers team as per step 11 on https://juju.ubuntu.com/docs/authors-charm-store.html, which is why your submission was not reviewed before now. This is what I found when I reviewed your charm:

* `charm proof` had no errors or warnings
* Good icon
* The README.md, config.yaml, metadata.yaml, and copyright all look good
* There are no tests (would prevent acceptance to trusty)

However, I was not able to get the charm running following the instructions in the README.md. Additionally, though there are quite a few config options defined, the charm doesn't have a config-changed hook to handle those values being changed.

Nathan,

I have assigned the bug to you since you have the newer submission. Here is what I found when I reviewed your charm:

* `charm proof` had no errors or warnings
* Good icon
* The README.md, config.yaml, metadata.yaml, and copyright all look good
* I was able get the charm deployed without issue by following the README.md
* Changing the config values worked as expected
* There are no tests; this is fine for acceptance for precise for now, but tests are required for trusty and will likely be required for precise as well in the future

In summary, I give a +1 for the more recent submission by Nathan.

Thank you both again for your contributions!