Charm needed: uwsgi

[Patrick Hetu]

Cool application servers.

[Patrick Hetu (patrick-hetu)]

Note: you might want to test it with this python-django branch:

  lp:~patrick-hetu/charms/precise/python-django/charmhelpers

[Nathan Osman (george-edison55)]

I have completed the first version of my uWSGI charm, which is located here:

lp:~george-edison55/charms/precise/uwsgi/trunk

I would like to submit this charm for review (hence, I am subscribing the ~charmers group) so I figured it would be easier to continue off of this bug report instead of filing a new one.

[Cory Johns (johnsca)]

Thank you both for your contributions!

Patrick,

It seems you never subscribed the charmers team as per step 11 on https://juju.ubuntu.com/docs/authors-charm-store.html, which is why your submission was not reviewed before now. This is what I found when I reviewed your charm:

* `charm proof` had no errors or warnings
* Good icon
* The README.md, config.yaml, metadata.yaml, and copyright all look good
* There are no tests (would prevent acceptance to trusty)

However, I was not able to get the charm running following the instructions in the README.md. Additionally, though there are quite a few config options defined, the charm doesn't have a config-changed hook to handle those values being changed.

Nathan,

I have assigned the bug to you since you have the newer submission. Here is what I found when I reviewed your charm:

* `charm proof` had no errors or warnings
* Good icon
* The README.md, config.yaml, metadata.yaml, and copyright all look good
* I was able get the charm deployed without issue by following the README.md
* Changing the config values worked as expected
* There are no tests; this is fine for acceptance for precise for now, but tests are required for trusty and will likely be required for precise as well in the future

In summary, I give a +1 for the more recent submission by Nathan.

Thank you both again for your contributions!

[Patrick Hetu (patrick-hetu)]

After some thinking, I think I'll rename my charm uwsgi-emperor and open a new bug later (and subscribes to charmer team this time ;) ).
Because my charm used the "new" (1.3) multi-app feature of Uwsgi and it's available only since saucy.
I've try Nathan's charm with my django charm and it works pretty well, great job Nathan!

[Patrick Hetu (patrick-hetu)]

Maybe just a small detail,

in the Django charm, python_path will allow multiple path separated by colons.
Since Uwsgi needs them to be separated in multiple variables, I guess you could do a split
on that variable just to be sure.

[Charles Butler (lazypower)]

Nathan,

This is a great first cut of the uWSGI charm! Thank you for this submission, it's great to see a familiar face from AskUbuntu show up in the charm review queue.

Its pretty simple in what it does and offers, the relationship is very straight forward.

There are some areas for improvement on the next iteration of the charm. The missing stop hook means the uWSGI application is left behind if someone were to destroy the service. As uWSGI is a subordinate, I would like to see a cleanup routine added in the event a user chooses to move from uWSGI to another application server (eg: python-gunicorn)

I also see that uWSGI supports a standard for monitoring. Adding a monitoring interface with the NRPE-External charm would be a great place to start adding additional functionality.

In all, this was a great approach and we appreciate this contribution to the charm store. Thanks again and welcome to the charm store!

You can find the bug tracker for the charm here: https://bugs.launchpad.net/charms/precise/+source/uwsgi

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>