contrib.amulet.utils. validate_services_by_name doesn't actually check that Upstart jobs are running, merely that the job is defined.
The code assumes that "sudo status foo" will return non-zero when foo isn't running. It doesn't, instead Upstart returns 0 and tells you in a message that the services is "stop/waiting".
Additionally there are no tests which cover the behaviour of any of the utils.
contrib. amulet. utils. validate_ services_ by_name doesn't actually check that Upstart jobs are running, merely that the job is defined.
The code assumes that "sudo status foo" will return non-zero when foo isn't running. It doesn't, instead Upstart returns 0 and tells you in a message that the services is "stop/waiting".
Additionally there are no tests which cover the behaviour of any of the utils.