validate_services_by_name in contrib.amulet.utils doesn't

Bug #1484112 reported by Adam Collard
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Charm Helpers
Fix Released
Adam Collard

Bug Description

contrib.amulet.utils.validate_services_by_name doesn't actually check that Upstart jobs are running, merely that the job is defined.

The code assumes that "sudo status foo" will return non-zero when foo isn't running. It doesn't, instead Upstart returns 0 and tells you in a message that the services is "stop/waiting".

Additionally there are no tests which cover the behaviour of any of the utils.

Tags: landscape

Related branches

Changed in charm-helpers:
assignee: nobody → Adam Collard (adam-collard)
status: New → In Progress
description: updated
Revision history for this message
Ryan Beisner (1chb1n) wrote :

FYI, confirmed, that's a bug. Thanks for the enhancement. ;-)

Changed in charm-helpers:
status: In Progress → Fix Committed
Changed in charm-helpers:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.