validate_services_by_name in contrib.amulet.utils doesn't
Bug #1484112 reported by
Adam Collard
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Charm Helpers |
Fix Released
|
Undecided
|
Adam Collard | ||
Bug Description
contrib.
The code assumes that "sudo status foo" will return non-zero when foo isn't running. It doesn't, instead Upstart returns 0 and tells you in a message that the services is "stop/waiting".
Additionally there are no tests which cover the behaviour of any of the utils.
Related branches
lp:~adam-collard/charm-helpers/fix-amulet-utils-validate-services-by-name
- Chris Glass (community): Approve
-
Diff: 190 lines (+125/-10)3 files modifiedcharmhelpers/contrib/amulet/utils.py (+18/-10)
test_requirements.txt (+2/-0)
tests/contrib/amulet/test_utils.py (+105/-0)
| Changed in charm-helpers: | |
| assignee: | nobody → Adam Collard (adam-collard) |
| status: | New → In Progress |
| description: | updated |
Revision history for this message
| Ryan Beisner (1chb1n) wrote | #1 |
| Changed in charm-helpers: | |
| status: | In Progress → Fix Committed |
| Changed in charm-helpers: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
FYI, confirmed, that's a bug. Thanks for the enhancement. ;-)