Addresses minor issues that were raised in the code review comments
for Patch Set 10 of "Add SQLAlchemy implementation of groupby" https://review.openstack.org/#/c/41597/
The issues were in the StatisticsGroupByTest class of the storage
driver tests.
1) Adds else clause to test_group_by_with_query_filter_multiple
The else clause ensures that all possible values for 'project_id'
and 'resource_id' are covered when checking the values returned
by get_meter_statistics().
2) Adds TODO comments for tests that are not implemented
The tests that have not been implemented are ones involving
metadata fields, since group by with metadata fields has not yet
been implemented.
Reviewed: https:/ /review. openstack. org/43993 github. com/openstack/ ceilometer/ commit/ 2e484972e189368 2159458461a1eae a7a5cf48f6
Committed: http://
Submitter: Jenkins
Branch: master
commit 2e484972e189368 2159458461a1eae a7a5cf48f6
Author: Terri Yu <email address hidden>
Date: Wed Aug 28 05:38:48 2013 +0000
Adds else and TODO in statistics storage tests
Fixes bug #1217688
Addresses minor issues that were raised in the code review comments /review. openstack. org/#/c/ 41597/
for Patch Set 10 of "Add SQLAlchemy implementation of groupby"
https:/
The issues were in the StatisticsGroup ByTest class of the storage
driver tests.
1) Adds else clause to test_group_ by_with_ query_filter_ multiple
The else clause ensures that all possible values for 'project_id' statistics( ).
and 'resource_id' are covered when checking the values returned
by get_meter_
2) Adds TODO comments for tests that are not implemented
The tests that have not been implemented are ones involving
metadata fields, since group by with metadata fields has not yet
been implemented.
Change-Id: I55cc0cb6cc7917 08c9b8038787d71 2760f9515df