missing else clause and TODO comments in statistics group by storage tests

[Terri Yu]

A few minor issues that were raised in the code review comments for Patch Set 10 of "Add SQLAlchemy implementation of groupby" https://review.openstack.org/#/c/41597/

1) test_group_by_with_query_filter_multiple in class StatisticsGroupByTest in tests/storage/test_storage_scenarios.py is missing an else clause in the code block where it checks values returned by get_meter_statistics(). The else clause would ensure that all possible values for 'project_id' and 'resource_id' are covered.

2) tests/storage/test_storage_scenarios.py defines tests for group by with metadata fields in class StatisticsGroupByTest, but these are not implemented. The body of the tests is "pass." A TODO comment needs to be added to each of these tests.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/43993

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/43993
Committed: http://github.com/openstack/ceilometer/commit/2e484972e1893682159458461a1eaea7a5cf48f6
Submitter: Jenkins
Branch: master

commit 2e484972e1893682159458461a1eaea7a5cf48f6
Author: Terri Yu <email address hidden>
Date: Wed Aug 28 05:38:48 2013 +0000

    Adds else and TODO in statistics storage tests

    Fixes bug #1217688

    Addresses minor issues that were raised in the code review comments
    for Patch Set 10 of "Add SQLAlchemy implementation of groupby"
    https://review.openstack.org/#/c/41597/

    The issues were in the StatisticsGroupByTest class of the storage
    driver tests.

    1) Adds else clause to test_group_by_with_query_filter_multiple

       The else clause ensures that all possible values for 'project_id'
       and 'resource_id' are covered when checking the values returned
       by get_meter_statistics().

    2) Adds TODO comments for tests that are not implemented

       The tests that have not been implemented are ones involving
       metadata fields, since group by with metadata fields has not yet
       been implemented.

    Change-Id: I55cc0cb6cc791708c9b8038787d712760f9515df