Comment 5 for bug 1618391

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> In experimenting with this I noticed a typo in the source when getting this parameter, so the min
> will always be 10 on every system in spite of the config.

Thanks Pat, this is indeed a typo in repowerd.

That being said, two things to note in relation to the "brightness is too strong":

1. The screenBrightnessSettingMininum config has no effect on autobrightness; it only affects the minimum value manually settable by the user. Autobrightness is governed by the curve specified in "config_autoBrightnessLcdBacklightValues" in the device specific config file (/usr/share/powerd/device_configs/config-default.xml)

2. By pure chance, this bug has no effect on E4.5 and allows an even darker setting on MX4 (not sure about PRO5) for the manual case, since it defaults to 10 for min brightness, whereas the actual config values for the aforementioned devices are 10 and 15 respectively.

Suggested steps to improve the situation:

* Fix typo in repowerd (assigned to me)
* Change device specific config files to have lower minimum values for both (manual) brightness setting and the autobrightness curve.