calibre

Bug #883616
Comment #4

Comment 4 for bug 883616

Revision history for this message

Glenn Barnich (gbarnich) wrote on 2011-11-05: Re: [Bug 883616] Re: IREX DR Driver root directory

Thanks for considering this, there is no hurry.

On 05 Nov 2011, at 06:08, Kovid Goyal wrote:

> Sorry I got a little busy for a few days, so I could not respond. In
> principle I'm ok with your patch. Just walk me through a couple of the
> changes, so I understand what's being done.
>
> 1) The original firmware is ok with books being put into the root
> directory rather than under sbooks?

the last official beta firmware from IREX (version 2rc3, 30-Jun-2010, http://updates.irexnet.com/beta/dr1000s/ ) is ok

the last official non-beta firmware from IREX (version 1.71, 02-Nov-2009, http://updates.irexnet.com/embedded/dr1000/) is also ok, meaning that the books are correctly copied to the root directory of the card; I am convinced that people who can access the directory /ebooks can also access the root directory, but I am not completely sure as I have not really used this firmware, in any case one can always put the books into /ebooks by using the appropriate save template (whereas it seems to be impossible to go up in the directory structure using this method)

>
> 2) Why is the WINDOWS_MAIN_MEM being set to an empty string. If you need
> ot match multiple devices, you can make it a list, see for example
> android/driver.py

no good reason, can and should be put back to 'DR1000'

>
> 3) Why is DELETE_EXTS being nuked?

this change is also not essential, I have made it in order to have the same configuration on the DR1000 than on the DR800 since the latest firmwares on both are almost identical

I guess the original reason for this option is related to the mobipocket reader of the old firmware,
there is a difference between the mobipocket capabilities of version 2rc3 and version 1.71

[extract from the installation notes of 2rc3:

In addition to the features and improvements above, there are regressions from the v1.7.x release.
For this reason we will keep the older firmware versions available for download
(http://updates.irexnet.com/embedded/)

* The PC Companion Software application does not work anymore. There is currently no way to merge
scribbles or safely rename a file on the PC.
* Mobipocket Support (both DRM and non-DRM) has been removed in favor of Adobe DRM and EPUB
......
]
people who use the latest firmware 2rc3 use the port of FBreader to read this type of files,
http://wiki.mobileread.com/wiki/Digital_Reader_Software#Standalone_applications

>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/883616
>
> Title:
> IREX DR Driver root directory
>
> Status in calibre: e-book management:
> Incomplete
>
> Bug description:
> Loading image...done
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: <email address hidden>
> # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
> # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
> # timestamp: 2011-10-29 20:36:54 +0200
> # base_revision_id: <email address hidden>-\
> # i239c4whbhw4y23a
> #
> # Begin patch
> === modified file 'src/calibre/devices/irexdr/driver.py'
> --- src/calibre/devices/irexdr/driver.py 2010-10-04 03:18:26 +0000
> +++ src/calibre/devices/irexdr/driver.py 2011-10-29 18:36:00 +0000
> @@ -27,24 +27,27 @@
> BCD = [0x322]
>
> VENDOR_NAME = 'IREX'
> - WINDOWS_MAIN_MEM = 'DR1000'
> +
> + EBOOK_DIR_MAIN = ''
> + EBOOK_DIR_CARD_A = ''
> +
> + WINDOWS_MAIN_MEM = ''
>
> OSX_MAIN_MEM = 'iRex DR1000 Media'
> -
> MAIN_MEMORY_VOLUME_LABEL = 'IRex Digital Reader 1000 Main Memory'
>
> - EBOOK_DIR_MAIN = 'ebooks'
> - DELETE_EXTS = ['.mbp']
> +
> + DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
> class IREXDR800(IREXDR1000):
> name = 'IRex Digital Reader 800 Device Interface'
> description = _('Communicate with the IRex Digital Reader 800')
> PRODUCT_ID = [0x002]
> - WINDOWS_MAIN_MEM = 'DR800'
> + WINDOWS_MAIN_MEM = ''
> FORMATS = ['epub', 'pdb', 'html', 'pdf', 'txt']
>
> - EBOOK_DIR_MAIN = 'Books'
> + EBOOK_DIR_MAIN = ''
> DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
>
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWXDszVgAAbzfgEAQUOf/936v
> nMq/7//wUAQars3Dbp0Hu9tm8JJI00jTBMp6TAmI00IDTyGmkaZHqaDJEMCZNTU2k0aNAAAANGgA
> CUE0FNMqeZCnqbU2o9IDQ9RoGgaB6jQNqknpo0j0ieTSfqh6gyMQAABoPSAJSU2k9MmqeSP1T2pq
> ZNNqaZMTJoADCBoMBo1bSnqU+2XabNZFy673ZKaNsBRUTY1h2weUqaAE4DKjfNzW7rzDMj8+Ye8c
> Ko8+ip75BVM9pGhE7j8zj5F6sMe36NqXx7N/LBTw9nGveW+jU+9r+Uc79ESiEaJOfiqvdQz5pYs+
> Z7p3dmFOZHWjpR5MasUx7z3i4PcUZOLaZip2fhftQWGhXBFiWEbNfZLoTRZGKLC89RYi9TJYwkip
> 0hR2EFbJGQGojI6O6ZJmHLlWaV6oM1YM6I3s38zlZoGZMjX04wgUQMIm9Iium/3l/6TddyUVwczG
> S6YWTCRVEr7Lbb9YXLnYRBRrneooLGubFfMGKIF2qBMCgumy2i1sEA91SXii44yp8gVRa0zcfu4O
> CynRNTGh6YTtWUUGGu6QUIxiHRRgoDbXQGstYaj+l8EhYhXiAyBwH4qXBIVMezLKCE0wFsjGNiXg
> 5cYqHE1ptZiUc76LJjfs531wsGZ18yhkYqBwWbcloXFdrZx0qTKjrarKtNNz7NTNOgTckyLRYICS
> Dd/OzC6cF5rNbF3js2JRhy3BxvTsmPRUN5w3+Tl4pxmaP7sC+Z7s/otaYpi/rMROi5DWmkcKaUoc
> 9P+5o6SYfFymr5J7i0tLc/Q4OGaIZaWj7fjuPNiNj6N2pWTbw2AcAhukqqIRKl3fChGqtLAnUb/t
> 3G71Sd+KaU25e8HmAFlBk6zKjnuOFg0RWgArerGdBLvMHMA5ykMdebwKCcv4aLylTOS8DG+GK8SB
> mLFxXBe3Dgz4etpoRK3Q12WPCdfGyWQyZYzTr0uNuyDzrdRMFFVahRCrp0SS1NJ0bXSts/jiem+f
> CZVuWu2LHY/VmxFYSU2CwBH3OJlDOSbbqCrK5TxFBDlt1aBVuXYO6jqGihHKjEL/JYAyaxFIN7LE
> uDLBFFlWETztWnNNUA5o/RVAOhSVpVpIRk+Q4J1/EYS1A4SdK+ikLHgyFZAHhyBYRwBYlFJ5QkyR
> LESn9pmUDHJzaKFggGUNusnqpWOZsjniy4zC1EJA/oCTkswFc9KxNkFVFTiJu8BZxMQAYHCuzvYj
> WgpM9oRxiApqDrSL4qUloY263Ib5Ui07CeMWsRWhqVlbrYUErRQt2F7uwZWUpQLAX1njuEqUmolt
> unzQLyWT9FcscOHBzReC2TGxSYVXHRAQ68C8WxU3qJOuOYkVC2SKOrvdOSNgvmotqwzUOcjQcI8B
> QX0xpYjFyqio5RFI0hSF6QIFKRxaAvL2YTG3D/F3JFOFCQcOzNWA
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/calibre/+bug/883616/+subscriptions

Thanks for considering this, there is no hurry.

On 05 Nov 2011, at 06:08, Kovid Goyal wrote:

> Sorry I got a little busy for a few days, so I could not respond. In
> principle I'm ok with your patch. Just walk me through a couple of the
> changes, so I understand what's being done.
> 
> 1) The original firmware is ok with books being put into the root
> directory rather than under sbooks?

the last official beta firmware from IREX (version 2rc3, 30-Jun-2010, http://updates.irexnet.com/beta/dr1000s/ ) is ok

the last official non-beta firmware from IREX (version 1.71, 02-Nov-2009, http://updates.irexnet.com/embedded/dr1000/) is also ok, meaning that the books are correctly copied to the root directory of the card;  I am convinced that people who can access the directory /ebooks can also access the root directory, but I am not completely sure as I have not really used this firmware, in any case one can always put the books into /ebooks by using the appropriate save template (whereas it seems to be impossible to go up in the directory structure using this method)

From what I gather from the mobileread forum, most users that want to get the most out of their device and use calibre with the DR1000 have version 2rc3 of the firmware, but there is no way to be sure of course. I believe that people who stay with the original firmware mostly also use the companion software on the PC to interact with their device.
 
> 
> 2) Why is the WINDOWS_MAIN_MEM being set to an empty string. If you need
> ot match multiple devices, you can make it a list, see for example
> android/driver.py

no good reason, can and should be put back to 'DR1000'

> 
> 3) Why is DELETE_EXTS being nuked?

this change is also not essential, I have made it in order to have the same configuration on the DR1000 than on the DR800 since the latest firmwares on both are almost identical

I guess the original reason for this option is related to the mobipocket reader of the old firmware, 
there is a difference between the mobipocket capabilities of version 2rc3 and version 1.71

[extract from the installation notes of 2rc3:

In addition to the features and improvements above, there are regressions from the v1.7.x release. 
For this reason we will keep the older firmware versions available for download 
(http://updates.irexnet.com/embedded/)

* The PC Companion Software application does not work anymore. There is currently no way to merge
  scribbles or safely rename a file on the PC.
* Mobipocket Support (both DRM and non-DRM) has been removed in favor of Adobe DRM and EPUB
......
]
people who use the latest firmware 2rc3 use the port of FBreader to read this type of files,
http://wiki.mobileread.com/wiki/Digital_Reader_Software#Standalone_applications

> 
> -- 
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/883616
> 
> Title:
>  IREX DR Driver root directory
> 
> Status in calibre: e-book management:
>  Incomplete
> 
> Bug description:
>  Loading image...done
>  # Bazaar merge directive format 2 (Bazaar 0.90)
>  # revision_id: gbarnich@gmail.com-20111029183600-4aevgfiqcrr4bxny
>  # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
>  # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
>  # timestamp: 2011-10-29 20:36:54 +0200
>  # base_revision_id: kovid@kovidgoyal.net-20111029025107-\
>  #   i239c4whbhw4y23a
>  #
>  # Begin patch
>  === modified file 'src/calibre/devices/irexdr/driver.py'
>  --- src/calibre/devices/irexdr/driver.py        2010-10-04 03:18:26 +0000
>  +++ src/calibre/devices/irexdr/driver.py        2011-10-29 18:36:00 +0000
>  @@ -27,24 +27,27 @@
>       BCD         = [0x322]
> 
>       VENDOR_NAME = 'IREX'
>  -    WINDOWS_MAIN_MEM = 'DR1000'
>  +
>  +    EBOOK_DIR_MAIN = ''
>  +    EBOOK_DIR_CARD_A = ''
>  +
>  +    WINDOWS_MAIN_MEM = ''
> 
>       OSX_MAIN_MEM = 'iRex DR1000 Media'
>  -
>       MAIN_MEMORY_VOLUME_LABEL  = 'IRex Digital Reader 1000 Main Memory'
> 
>  -    EBOOK_DIR_MAIN = 'ebooks'
>  -    DELETE_EXTS = ['.mbp']
>  +
>  +    DELETE_EXTS = []
>       SUPPORTS_SUB_DIRS = True
> 
>   class IREXDR800(IREXDR1000):
>       name           = 'IRex Digital Reader 800 Device Interface'
>       description    = _('Communicate with the IRex Digital Reader 800')
>       PRODUCT_ID = [0x002]
>  -    WINDOWS_MAIN_MEM = 'DR800'
>  +    WINDOWS_MAIN_MEM = ''
>       FORMATS     = ['epub', 'pdb', 'html', 'pdf', 'txt']
> 
>  -    EBOOK_DIR_MAIN = 'Books'
>  +    EBOOK_DIR_MAIN = ''
>       DELETE_EXTS = []
>       SUPPORTS_SUB_DIRS = True
> 
> 
>  # Begin bundle
>  IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWXDszVgAAbzfgEAQUOf/936v
>  nMq/7//wUAQars3Dbp0Hu9tm8JJI00jTBMp6TAmI00IDTyGmkaZHqaDJEMCZNTU2k0aNAAAANGgA
>  CUE0FNMqeZCnqbU2o9IDQ9RoGgaB6jQNqknpo0j0ieTSfqh6gyMQAABoPSAJSU2k9MmqeSP1T2pq
>  ZNNqaZMTJoADCBoMBo1bSnqU+2XabNZFy673ZKaNsBRUTY1h2weUqaAE4DKjfNzW7rzDMj8+Ye8c
>  Ko8+ip75BVM9pGhE7j8zj5F6sMe36NqXx7N/LBTw9nGveW+jU+9r+Uc79ESiEaJOfiqvdQz5pYs+
>  Z7p3dmFOZHWjpR5MasUx7z3i4PcUZOLaZip2fhftQWGhXBFiWEbNfZLoTRZGKLC89RYi9TJYwkip
>  0hR2EFbJGQGojI6O6ZJmHLlWaV6oM1YM6I3s38zlZoGZMjX04wgUQMIm9Iium/3l/6TddyUVwczG
>  S6YWTCRVEr7Lbb9YXLnYRBRrneooLGubFfMGKIF2qBMCgumy2i1sEA91SXii44yp8gVRa0zcfu4O
>  CynRNTGh6YTtWUUGGu6QUIxiHRRgoDbXQGstYaj+l8EhYhXiAyBwH4qXBIVMezLKCE0wFsjGNiXg
>  5cYqHE1ptZiUc76LJjfs531wsGZ18yhkYqBwWbcloXFdrZx0qTKjrarKtNNz7NTNOgTckyLRYICS
>  Dd/OzC6cF5rNbF3js2JRhy3BxvTsmPRUN5w3+Tl4pxmaP7sC+Z7s/otaYpi/rMROi5DWmkcKaUoc
>  9P+5o6SYfFymr5J7i0tLc/Q4OGaIZaWj7fjuPNiNj6N2pWTbw2AcAhukqqIRKl3fChGqtLAnUb/t
>  3G71Sd+KaU25e8HmAFlBk6zKjnuOFg0RWgArerGdBLvMHMA5ykMdebwKCcv4aLylTOS8DG+GK8SB
>  mLFxXBe3Dgz4etpoRK3Q12WPCdfGyWQyZYzTr0uNuyDzrdRMFFVahRCrp0SS1NJ0bXSts/jiem+f
>  CZVuWu2LHY/VmxFYSU2CwBH3OJlDOSbbqCrK5TxFBDlt1aBVuXYO6jqGihHKjEL/JYAyaxFIN7LE
>  uDLBFFlWETztWnNNUA5o/RVAOhSVpVpIRk+Q4J1/EYS1A4SdK+ikLHgyFZAHhyBYRwBYlFJ5QkyR
>  LESn9pmUDHJzaKFggGUNusnqpWOZsjniy4zC1EJA/oCTkswFc9KxNkFVFTiJu8BZxMQAYHCuzvYj
>  WgpM9oRxiApqDrSL4qUloY263Ib5Ui07CeMWsRWhqVlbrYUErRQt2F7uwZWUpQLAX1njuEqUmolt
>  unzQLyWT9FcscOHBzReC2TGxSYVXHRAQ68C8WxU3qJOuOYkVC2SKOrvdOSNgvmotqwzUOcjQcI8B
>  QX0xpYjFyqio5RFI0hSF6QIFKRxaAvL2YTG3D/F3JFOFCQcOzNWA
> 
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/calibre/+bug/883616/+subscriptions