calibre

IREX DR Driver root directory

Bug #883616 reported by Glenn Barnich
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Undecided
Paula Mulder

Bug Description

Loading image...done
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: <email address hidden>
# target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
# testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
# timestamp: 2011-10-29 20:36:54 +0200
# base_revision_id: <email address hidden>-\
# i239c4whbhw4y23a
#
# Begin patch
=== modified file 'src/calibre/devices/irexdr/driver.py'
--- src/calibre/devices/irexdr/driver.py 2010-10-04 03:18:26 +0000
+++ src/calibre/devices/irexdr/driver.py 2011-10-29 18:36:00 +0000
@@ -27,24 +27,27 @@
     BCD = [0x322]

     VENDOR_NAME = 'IREX'
- WINDOWS_MAIN_MEM = 'DR1000'
+
+ EBOOK_DIR_MAIN = ''
+ EBOOK_DIR_CARD_A = ''
+
+ WINDOWS_MAIN_MEM = ''

     OSX_MAIN_MEM = 'iRex DR1000 Media'
-
     MAIN_MEMORY_VOLUME_LABEL = 'IRex Digital Reader 1000 Main Memory'

- EBOOK_DIR_MAIN = 'ebooks'
- DELETE_EXTS = ['.mbp']
+
+ DELETE_EXTS = []
     SUPPORTS_SUB_DIRS = True

 class IREXDR800(IREXDR1000):
     name = 'IRex Digital Reader 800 Device Interface'
     description = _('Communicate with the IRex Digital Reader 800')
     PRODUCT_ID = [0x002]
- WINDOWS_MAIN_MEM = 'DR800'
+ WINDOWS_MAIN_MEM = ''
     FORMATS = ['epub', 'pdb', 'html', 'pdf', 'txt']

- EBOOK_DIR_MAIN = 'Books'
+ EBOOK_DIR_MAIN = ''
     DELETE_EXTS = []
     SUPPORTS_SUB_DIRS = True

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWXDszVgAAbzfgEAQUOf/936v
nMq/7//wUAQars3Dbp0Hu9tm8JJI00jTBMp6TAmI00IDTyGmkaZHqaDJEMCZNTU2k0aNAAAANGgA
CUE0FNMqeZCnqbU2o9IDQ9RoGgaB6jQNqknpo0j0ieTSfqh6gyMQAABoPSAJSU2k9MmqeSP1T2pq
ZNNqaZMTJoADCBoMBo1bSnqU+2XabNZFy673ZKaNsBRUTY1h2weUqaAE4DKjfNzW7rzDMj8+Ye8c
Ko8+ip75BVM9pGhE7j8zj5F6sMe36NqXx7N/LBTw9nGveW+jU+9r+Uc79ESiEaJOfiqvdQz5pYs+
Z7p3dmFOZHWjpR5MasUx7z3i4PcUZOLaZip2fhftQWGhXBFiWEbNfZLoTRZGKLC89RYi9TJYwkip
0hR2EFbJGQGojI6O6ZJmHLlWaV6oM1YM6I3s38zlZoGZMjX04wgUQMIm9Iium/3l/6TddyUVwczG
S6YWTCRVEr7Lbb9YXLnYRBRrneooLGubFfMGKIF2qBMCgumy2i1sEA91SXii44yp8gVRa0zcfu4O
CynRNTGh6YTtWUUGGu6QUIxiHRRgoDbXQGstYaj+l8EhYhXiAyBwH4qXBIVMezLKCE0wFsjGNiXg
5cYqHE1ptZiUc76LJjfs531wsGZ18yhkYqBwWbcloXFdrZx0qTKjrarKtNNz7NTNOgTckyLRYICS
Dd/OzC6cF5rNbF3js2JRhy3BxvTsmPRUN5w3+Tl4pxmaP7sC+Z7s/otaYpi/rMROi5DWmkcKaUoc
9P+5o6SYfFymr5J7i0tLc/Q4OGaIZaWj7fjuPNiNj6N2pWTbw2AcAhukqqIRKl3fChGqtLAnUb/t
3G71Sd+KaU25e8HmAFlBk6zKjnuOFg0RWgArerGdBLvMHMA5ykMdebwKCcv4aLylTOS8DG+GK8SB
mLFxXBe3Dgz4etpoRK3Q12WPCdfGyWQyZYzTr0uNuyDzrdRMFFVahRCrp0SS1NJ0bXSts/jiem+f
CZVuWu2LHY/VmxFYSU2CwBH3OJlDOSbbqCrK5TxFBDlt1aBVuXYO6jqGihHKjEL/JYAyaxFIN7LE
uDLBFFlWETztWnNNUA5o/RVAOhSVpVpIRk+Q4J1/EYS1A4SdK+ikLHgyFZAHhyBYRwBYlFJ5QkyR
LESn9pmUDHJzaKFggGUNusnqpWOZsjniy4zC1EJA/oCTkswFc9KxNkFVFTiJu8BZxMQAYHCuzvYj
WgpM9oRxiApqDrSL4qUloY263Ib5Ui07CeMWsRWhqVlbrYUErRQt2F7uwZWUpQLAX1njuEqUmolt
unzQLyWT9FcscOHBzReC2TGxSYVXHRAQ68C8WxU3qJOuOYkVC2SKOrvdOSNgvmotqwzUOcjQcI8B
QX0xpYjFyqio5RFI0hSF6QIFKRxaAvL2YTG3D/F3JFOFCQcOzNWA

Related branches

lp:calibre
Revision history for this message
Kovid Goyal (kovid) wrote :

What's the motivation for this patch? The Irex DR is an old device. If you are running some sort of custom firmware, then use the user defined driver, as described here: http://manual.calibre-ebook.com/faq.html#my-device-is-non-standard-or-unusual-what-can-i-do-to-connect-to-it

Changed in calibre:
status: New → Incomplete
Revision history for this message
Glenn Barnich (gbarnich) wrote : Re: [Bug 883616] Re: IREX DR Driver root directory
Download full text (5.6 KiB)

Hi Kovid,

First of all, thanks for a wonderful program.

On 30 Oct 2011, at 02:48, Kovid Goyal wrote:

> What's the motivation for this patch? The Irex DR is an old device.

True, but the hardware is great and the software that exists by now is second to none. There still is a dedicated developer community out there, who has continued to improve the firmware, see first section of
http://wiki.mobileread.com/wiki/Digital_Reader_Software
I believe that their patches have become the de facto standard, and some of the ported software only works with it. Furthermore, the changes that I propose are absolutely minimal and will work both with the standard official firmware and with the patched version.

> If
> you are running some sort of custom firmware, then use the user defined
> driver, as described here: http://manual.calibre-ebook.com/faq.html#my-
> device-is-non-standard-or-unusual-what-can-i-do-to-connect-to-it

That is what I did at first and it works great, but it only works for one of the two devices, not for both at the same time since there is only a single user-defined device. To make both work, I merely followed chaley's advice, last message of http://www.mobileread.com/forums/showthread.php?t=151145
and it seems to be the only way. I thought that other users that do not want to install the sources could profit as well so that they (and me) could continue with the standard calibre releases. Btw, chaley's suggestion to control the directory structure through tags, for instance
{tags:'first_non_empty(
 in_list($, ',', '^IREX$', '/Books/', ''),
 in_list($, ',', '^News$', '/News/', ''))'}{author_sort}-{title}
is really great and could maybe be proposed as an option in the customization of the user-defined device.

Finally, there has been talk by the main DR developers to use the metadata from calibre directly on the DR, it could be an interesting case study ...
message #59 of
http://www.mobileread.com/forums/showthread.php?t=139330&highlight=calibre&page=4
and message number #61 of
http://www.mobileread.com/forums/showthread.php?t=139330&highlight=calibre&page=5

Cheers,
G

>
> ** Changed in: calibre
> Status: New => Incomplete
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/883616
>
> Title:
> IREX DR Driver root directory
>
> Status in calibre: e-book management:
> Incomplete
>
> Bug description:
> Loading image...done
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: <email address hidden>
> # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
> # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
> # timestamp: 2011-10-29 20:36:54 +0200
> # base_revision_id: <email address hidden>-\
> # i239c4whbhw4y23a
> #
> # Begin patch
> === modified file 'src/calibre/devices/irexdr/driver.py'
> --- src/calibre/devices/irexdr/driver.py 2010-10-04 03:18:26 +0000
> +++ src/calibre/devices/irexdr/driver.py 2011-10-29 18:36:00 +0000
> @@ -27,24 +27,27 @@
> BCD = [0x322]
>
> VENDOR_NAME = 'IREX'
> - WINDOWS_MAIN_MEM = 'DR1000...

Read more...

Revision history for this message
Kovid Goyal (kovid) wrote :

Sorry I got a little busy for a few days, so I could not respond. In principle I'm ok with your patch. Just walk me through a couple of the changes, so I understand what's being done.

1) The original firmware is ok with books being put into the root directory rather than under sbooks?

2) Why is the WINDOWS_MAIN_MEM being set to an empty string. If you need ot match multiple devices, you can make it a list, see for example android/driver.py

3) Why is DELETE_EXTS being nuked?

Changed in calibre:
status: Incomplete → New
status: New → Incomplete
Revision history for this message
Glenn Barnich (gbarnich) wrote :
Download full text (6.2 KiB)

Thanks for considering this, there is no hurry.

On 05 Nov 2011, at 06:08, Kovid Goyal wrote:

> Sorry I got a little busy for a few days, so I could not respond. In
> principle I'm ok with your patch. Just walk me through a couple of the
> changes, so I understand what's being done.
>
> 1) The original firmware is ok with books being put into the root
> directory rather than under sbooks?

the last official beta firmware from IREX (version 2rc3, 30-Jun-2010, http://updates.irexnet.com/beta/dr1000s/ ) is ok

the last official non-beta firmware from IREX (version 1.71, 02-Nov-2009, http://updates.irexnet.com/embedded/dr1000/) is also ok, meaning that the books are correctly copied to the root directory of the card; I am convinced that people who can access the directory /ebooks can also access the root directory, but I am not completely sure as I have not really used this firmware, in any case one can always put the books into /ebooks by using the appropriate save template (whereas it seems to be impossible to go up in the directory structure using this method)

From what I gather from the mobileread forum, most users that want to get the most out of their device and use calibre with the DR1000 have version 2rc3 of the firmware, but there is no way to be sure of course. I believe that people who stay with the original firmware mostly also use the companion software on the PC to interact with their device.

>
> 2) Why is the WINDOWS_MAIN_MEM being set to an empty string. If you need
> ot match multiple devices, you can make it a list, see for example
> android/driver.py

no good reason, can and should be put back to 'DR1000'

>
> 3) Why is DELETE_EXTS being nuked?

this change is also not essential, I have made it in order to have the same configuration on the DR1000 than on the DR800 since the latest firmwares on both are almost identical

I guess the original reason for this option is related to the mobipocket reader of the old firmware,
there is a difference between the mobipocket capabilities of version 2rc3 and version 1.71

[extract from the installation notes of 2rc3:

In addition to the features and improvements above, there are regressions from the v1.7.x release.
For this reason we will keep the older firmware versions available for download
(http://updates.irexnet.com/embedded/)

* The PC Companion Software application does not work anymore. There is currently no way to merge
  scribbles or safely rename a file on the PC.
* Mobipocket Support (both DRM and non-DRM) has been removed in favor of Adobe DRM and EPUB
......
]
people who use the latest firmware 2rc3 use the port of FBreader to read this type of files,
http://wiki.mobileread.com/wiki/Digital_Reader_Software#Standalone_applications

>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/883616
>
> Title:
> IREX DR Driver root directory
>
> Status in calibre: e-book management:
> Incomplete
>
> Bug description:
> Loading image...done
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: <email address hidden>
> # target_branch: http://bazaar...

Read more...

Revision history for this message
Kovid Goyal (kovid) wrote :

So, really the only change you need is setting EBOOK_DIR_MAIN = ''? Is the custom firmware unable to access files under /ebooks? I ask because I hate making behavioral changes, unless they are absolutely necessary.

Revision history for this message
Glenn Barnich (gbarnich) wrote :
Download full text (5.0 KiB)

On 08 Nov 2011, at 11:42, Kovid Goyal wrote:

> So, really the only change you need is setting EBOOK_DIR_MAIN = ''?

yes, both in the DR1000 section and in the DR800 section

> Is
> the custom firmware unable to access files under /ebooks?

If by custom you mean the latest (beta and also final) firmware from IREX, both the custom and the original firmwares are able to access files in this directory, but in fact for both firmwares, the final directory structure is and always has been somewhat ugly. Concretely for the latest beta firmware and the standard plugin you end up with

DR1000

/Books (not accessible by calibre)
/ebooks/ (contains all books loaded by calibre, including a directory /news with the news from calibre ...)
/News (not accessible by calibre)

 DR800

/Books (contains all books loaded by calibre, including a directory /news with the news from calibre ...)
/News (not accessible by calibre)

> I ask because
> I hate making behavioral changes, unless they are absolutely necessary.

They are of course not absolutely necessary, because after using calibre to put books and news, one can of course move the files on the devices by hand in the appropriate directories to use the full features of the reader. But this is not optimal of course and somehow defeats the purpose.

I do not think that this will be a behavioral change that will negatively affect any users with the original or latest firmware. In any case, the old behavior of the plugin can always be reproduced just by including /ebooks respectively /Books in the save template.

>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/883616
>
> Title:
> IREX DR Driver root directory
>
> Status in calibre: e-book management:
> Incomplete
>
> Bug description:
> Loading image...done
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: <email address hidden>
> # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
> # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
> # timestamp: 2011-10-29 20:36:54 +0200
> # base_revision_id: <email address hidden>-\
> # i239c4whbhw4y23a
> #
> # Begin patch
> === modified file 'src/calibre/devices/irexdr/driver.py'
> --- src/calibre/devices/irexdr/driver.py 2010-10-04 03:18:26 +0000
> +++ src/calibre/devices/irexdr/driver.py 2011-10-29 18:36:00 +0000
> @@ -27,24 +27,27 @@
> BCD = [0x322]
>
> VENDOR_NAME = 'IREX'
> - WINDOWS_MAIN_MEM = 'DR1000'
> +
> + EBOOK_DIR_MAIN = ''
> + EBOOK_DIR_CARD_A = ''
> +
> + WINDOWS_MAIN_MEM = ''
>
> OSX_MAIN_MEM = 'iRex DR1000 Media'
> -
> MAIN_MEMORY_VOLUME_LABEL = 'IRex Digital Reader 1000 Main Memory'
>
> - EBOOK_DIR_MAIN = 'ebooks'
> - DELETE_EXTS = ['.mbp']
> +
> + DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
> class IREXDR800(IREXDR1000):
> name = 'IRex Digital Reader 800 Device Interface'
> description = _('Communicate with the IRex Digital Reader 800')
> PRODUCT_ID = [0x002]
> - WINDOWS_MAIN_MEM = 'DR800'
> + ...

Read more...

Revision history for this message
Kovid Goyal (kovid) wrote :
Download full text (9.3 KiB)

How about the following change:

def get_ebook_dir_main(self, for_upload=False):
    if for_upload:
       return 'ebooks' # or 'Books' for the 800
    return ''

This will mean tha calibre will continue to place books in the ebooks
directory, but it will be able to scan all directories for books.

Kovid.

On Tue, Nov 08, 2011 at 11:24:42AM -0000, Glenn Barnich wrote:
> On 08 Nov 2011, at 11:42, Kovid Goyal wrote:
>
> > So, really the only change you need is setting EBOOK_DIR_MAIN = ''?
>
> yes, both in the DR1000 section and in the DR800 section
>
>
> > Is
> > the custom firmware unable to access files under /ebooks?
>
> If by custom you mean the latest (beta and also final) firmware from
> IREX, both the custom and the original firmwares are able to access
> files in this directory, but in fact for both firmwares, the final
> directory structure is and always has been somewhat ugly. Concretely for
> the latest beta firmware and the standard plugin you end up with
>
> DR1000
>
> /Books (not accessible by calibre)
> /ebooks/ (contains all books loaded by calibre, including a directory /news with the news from calibre ...)
> /News (not accessible by calibre)
>
> DR800
>
> /Books (contains all books loaded by calibre, including a directory /news with the news from calibre ...)
> /News (not accessible by calibre)
>
>
> > I ask because
> > I hate making behavioral changes, unless they are absolutely necessary.
>
> They are of course not absolutely necessary, because after using calibre
> to put books and news, one can of course move the files on the devices
> by hand in the appropriate directories to use the full features of the
> reader. But this is not optimal of course and somehow defeats the
> purpose.
>
> I do not think that this will be a behavioral change that will
> negatively affect any users with the original or latest firmware. In any
> case, the old behavior of the plugin can always be reproduced just by
> including /ebooks respectively /Books in the save template.
>
>
> >
> > --
> > You received this bug notification because you are subscribed to the bug
> > report.
> > https://bugs.launchpad.net/bugs/883616
> >
> > Title:
> > IREX DR Driver root directory
> >
> > Status in calibre: e-book management:
> > Incomplete
> >
> > Bug description:
> > Loading image...done
> > # Bazaar merge directive format 2 (Bazaar 0.90)
> > # revision_id: <email address hidden>
> > # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
> > # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
> > # timestamp: 2011-10-29 20:36:54 +0200
> > # base_revision_id: <email address hidden>-\
> > # i239c4whbhw4y23a
> > #
> > # Begin patch
> > === modified file 'src/calibre/devices/irexdr/driver.py'
> > --- src/calibre/devices/irexdr/driver.py 2010-10-04 03:18:26 +0000
> > +++ src/calibre/devices/irexdr/driver.py 2011-10-29 18:36:00 +0000
> > @@ -27,24 +27,27 @@
> > BCD = [0x322]
> >
> > VENDOR_NAME = 'IREX'
> > - WINDOWS_MAIN_MEM = 'DR1000'
> > +
> > + EBOOK_DIR_MAIN = ''
> > + EBOOK_DIR_CARD_A = ''
> > +
> > + WIN...

Read more...

Revision history for this message
Glenn Barnich (gbarnich) wrote :
Download full text (3.8 KiB)

IREX DR/Calibre poll
http://www.mobileread.com/forums/showthread.php?p=1823269#post1823269

On 08 Nov 2011, at 11:42, Kovid Goyal wrote:

> So, really the only change you need is setting EBOOK_DIR_MAIN = ''? Is
> the custom firmware unable to access files under /ebooks? I ask because
> I hate making behavioral changes, unless they are absolutely necessary.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/883616
>
> Title:
> IREX DR Driver root directory
>
> Status in calibre: e-book management:
> Incomplete
>
> Bug description:
> Loading image...done
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: <email address hidden>
> # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
> # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
> # timestamp: 2011-10-29 20:36:54 +0200
> # base_revision_id: <email address hidden>-\
> # i239c4whbhw4y23a
> #
> # Begin patch
> === modified file 'src/calibre/devices/irexdr/driver.py'
> --- src/calibre/devices/irexdr/driver.py 2010-10-04 03:18:26 +0000
> +++ src/calibre/devices/irexdr/driver.py 2011-10-29 18:36:00 +0000
> @@ -27,24 +27,27 @@
> BCD = [0x322]
>
> VENDOR_NAME = 'IREX'
> - WINDOWS_MAIN_MEM = 'DR1000'
> +
> + EBOOK_DIR_MAIN = ''
> + EBOOK_DIR_CARD_A = ''
> +
> + WINDOWS_MAIN_MEM = ''
>
> OSX_MAIN_MEM = 'iRex DR1000 Media'
> -
> MAIN_MEMORY_VOLUME_LABEL = 'IRex Digital Reader 1000 Main Memory'
>
> - EBOOK_DIR_MAIN = 'ebooks'
> - DELETE_EXTS = ['.mbp']
> +
> + DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
> class IREXDR800(IREXDR1000):
> name = 'IRex Digital Reader 800 Device Interface'
> description = _('Communicate with the IRex Digital Reader 800')
> PRODUCT_ID = [0x002]
> - WINDOWS_MAIN_MEM = 'DR800'
> + WINDOWS_MAIN_MEM = ''
> FORMATS = ['epub', 'pdb', 'html', 'pdf', 'txt']
>
> - EBOOK_DIR_MAIN = 'Books'
> + EBOOK_DIR_MAIN = ''
> DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
>
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWXDszVgAAbzfgEAQUOf/936v
> nMq/7//wUAQars3Dbp0Hu9tm8JJI00jTBMp6TAmI00IDTyGmkaZHqaDJEMCZNTU2k0aNAAAANGgA
> CUE0FNMqeZCnqbU2o9IDQ9RoGgaB6jQNqknpo0j0ieTSfqh6gyMQAABoPSAJSU2k9MmqeSP1T2pq
> ZNNqaZMTJoADCBoMBo1bSnqU+2XabNZFy673ZKaNsBRUTY1h2weUqaAE4DKjfNzW7rzDMj8+Ye8c
> Ko8+ip75BVM9pGhE7j8zj5F6sMe36NqXx7N/LBTw9nGveW+jU+9r+Uc79ESiEaJOfiqvdQz5pYs+
> Z7p3dmFOZHWjpR5MasUx7z3i4PcUZOLaZip2fhftQWGhXBFiWEbNfZLoTRZGKLC89RYi9TJYwkip
> 0hR2EFbJGQGojI6O6ZJmHLlWaV6oM1YM6I3s38zlZoGZMjX04wgUQMIm9Iium/3l/6TddyUVwczG
> S6YWTCRVEr7Lbb9YXLnYRBRrneooLGubFfMGKIF2qBMCgumy2i1sEA91SXii44yp8gVRa0zcfu4O
> CynRNTGh6YTtWUUGGu6QUIxiHRRgoDbXQGstYaj+l8EhYhXiAyBwH4qXBIVMezLKCE0wFsjGNiXg
> 5cYqHE1ptZiUc76LJjfs531wsGZ18yhkYqBwWbcloXFdrZx0qTKjrarKtNNz7NTNOgTckyLRYICS
> Dd/OzC6cF5rNbF3js2JRhy3BxvTsmPRUN5w3+Tl4pxmaP7sC+Z7s/otaYpi/rMROi5DWmkcKaUoc
> 9P+5o6SYfFymr5J7i0tLc/Q4OGaIZaWj7fjuPNiNj6N2pWTbw2AcAhukqqIRKl3fChGqtLAnUb/t
> 3G71Sd+KaU25e8HmAFlBk6zKj...

Read more...

Revision history for this message
Glenn Barnich (gbarnich) wrote :
Download full text (13.2 KiB)

if this means that the default directory on the DR1000 is the root directory in case the /ebooks directory is not there, then this is perfect

for the DR800, the /Books directory is definitely there and then the problem still remains: there is no way to access through calibre the /News directory that is on the same level than the /Books directory (or is there ?)

On 08 Nov 2011, at 13:09, Kovid Goyal wrote:

> How about the following change:
>
> def get_ebook_dir_main(self, for_upload=False):
> if for_upload:
> return 'ebooks' # or 'Books' for the 800
> return ''
>
> This will mean tha calibre will continue to place books in the ebooks
> directory, but it will be able to scan all directories for books.
>
> Kovid.
>
> On Tue, Nov 08, 2011 at 11:24:42AM -0000, Glenn Barnich wrote:
>> On 08 Nov 2011, at 11:42, Kovid Goyal wrote:
>>
>>> So, really the only change you need is setting EBOOK_DIR_MAIN = ''?
>>
>> yes, both in the DR1000 section and in the DR800 section
>>
>>
>>> Is
>>> the custom firmware unable to access files under /ebooks?
>>
>> If by custom you mean the latest (beta and also final) firmware from
>> IREX, both the custom and the original firmwares are able to access
>> files in this directory, but in fact for both firmwares, the final
>> directory structure is and always has been somewhat ugly. Concretely for
>> the latest beta firmware and the standard plugin you end up with
>>
>> DR1000
>>
>> /Books (not accessible by calibre)
>> /ebooks/ (contains all books loaded by calibre, including a directory /news with the news from calibre ...)
>> /News (not accessible by calibre)
>>
>> DR800
>>
>> /Books (contains all books loaded by calibre, including a directory /news with the news from calibre ...)
>> /News (not accessible by calibre)
>>
>>
>>> I ask because
>>> I hate making behavioral changes, unless they are absolutely necessary.
>>
>> They are of course not absolutely necessary, because after using calibre
>> to put books and news, one can of course move the files on the devices
>> by hand in the appropriate directories to use the full features of the
>> reader. But this is not optimal of course and somehow defeats the
>> purpose.
>>
>> I do not think that this will be a behavioral change that will
>> negatively affect any users with the original or latest firmware. In any
>> case, the old behavior of the plugin can always be reproduced just by
>> including /ebooks respectively /Books in the save template.
>>
>>
>>>
>>> --
>>> You received this bug notification because you are subscribed to the bug
>>> report.
>>> https://bugs.launchpad.net/bugs/883616
>>>
>>> Title:
>>> IREX DR Driver root directory
>>>
>>> Status in calibre: e-book management:
>>> Incomplete
>>>
>>> Bug description:
>>> Loading image...done
>>> # Bazaar merge directive format 2 (Bazaar 0.90)
>>> # revision_id: <email address hidden>
>>> # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
>>> # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
>>> # timestamp: 2011-10-29 20:36:54 +0200
>>> # base_revision_id: <email address hidden>-\
>>> # i239c4whbhw4y23a
>...

Revision history for this message
Kovid Goyal (kovid) wrote :

It means that for the purposes of sending books, calibre will still send them under /ebooks. However for the purposes of locating books on the device, calibre will use the root directory.

Kovid Goyal (kovid)
Changed in calibre:
status: Incomplete → New
status: New → Incomplete
Revision history for this message
Paula Mulder (genemulder) wrote :

I am about ready to throw this ebook out the nearest window. I have never had so much trouble with a device in my life.

Changed in calibre:
assignee: nobody → Paula Mulder (genemulder)
Revision history for this message
Glenn Barnich (gbarnich) wrote :
Download full text (3.8 KiB)

really, I am very sorry to hear that, what precisely is the problem?

On 12 Nov 2011, at 02:36, Paula Mulder wrote:

> I am about ready to throw this ebook out the nearest window. I have
> never had so much trouble with a device in my life.
>
> ** Changed in: calibre
> Assignee: (unassigned) => Paula Mulder (genemulder)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/883616
>
> Title:
> IREX DR Driver root directory
>
> Status in calibre: e-book management:
> Incomplete
>
> Bug description:
> Loading image...done
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: <email address hidden>
> # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
> # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
> # timestamp: 2011-10-29 20:36:54 +0200
> # base_revision_id: <email address hidden>-\
> # i239c4whbhw4y23a
> #
> # Begin patch
> === modified file 'src/calibre/devices/irexdr/driver.py'
> --- src/calibre/devices/irexdr/driver.py 2010-10-04 03:18:26 +0000
> +++ src/calibre/devices/irexdr/driver.py 2011-10-29 18:36:00 +0000
> @@ -27,24 +27,27 @@
> BCD = [0x322]
>
> VENDOR_NAME = 'IREX'
> - WINDOWS_MAIN_MEM = 'DR1000'
> +
> + EBOOK_DIR_MAIN = ''
> + EBOOK_DIR_CARD_A = ''
> +
> + WINDOWS_MAIN_MEM = ''
>
> OSX_MAIN_MEM = 'iRex DR1000 Media'
> -
> MAIN_MEMORY_VOLUME_LABEL = 'IRex Digital Reader 1000 Main Memory'
>
> - EBOOK_DIR_MAIN = 'ebooks'
> - DELETE_EXTS = ['.mbp']
> +
> + DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
> class IREXDR800(IREXDR1000):
> name = 'IRex Digital Reader 800 Device Interface'
> description = _('Communicate with the IRex Digital Reader 800')
> PRODUCT_ID = [0x002]
> - WINDOWS_MAIN_MEM = 'DR800'
> + WINDOWS_MAIN_MEM = ''
> FORMATS = ['epub', 'pdb', 'html', 'pdf', 'txt']
>
> - EBOOK_DIR_MAIN = 'Books'
> + EBOOK_DIR_MAIN = ''
> DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
>
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWXDszVgAAbzfgEAQUOf/936v
> nMq/7//wUAQars3Dbp0Hu9tm8JJI00jTBMp6TAmI00IDTyGmkaZHqaDJEMCZNTU2k0aNAAAANGgA
> CUE0FNMqeZCnqbU2o9IDQ9RoGgaB6jQNqknpo0j0ieTSfqh6gyMQAABoPSAJSU2k9MmqeSP1T2pq
> ZNNqaZMTJoADCBoMBo1bSnqU+2XabNZFy673ZKaNsBRUTY1h2weUqaAE4DKjfNzW7rzDMj8+Ye8c
> Ko8+ip75BVM9pGhE7j8zj5F6sMe36NqXx7N/LBTw9nGveW+jU+9r+Uc79ESiEaJOfiqvdQz5pYs+
> Z7p3dmFOZHWjpR5MasUx7z3i4PcUZOLaZip2fhftQWGhXBFiWEbNfZLoTRZGKLC89RYi9TJYwkip
> 0hR2EFbJGQGojI6O6ZJmHLlWaV6oM1YM6I3s38zlZoGZMjX04wgUQMIm9Iium/3l/6TddyUVwczG
> S6YWTCRVEr7Lbb9YXLnYRBRrneooLGubFfMGKIF2qBMCgumy2i1sEA91SXii44yp8gVRa0zcfu4O
> CynRNTGh6YTtWUUGGu6QUIxiHRRgoDbXQGstYaj+l8EhYhXiAyBwH4qXBIVMezLKCE0wFsjGNiXg
> 5cYqHE1ptZiUc76LJjfs531wsGZ18yhkYqBwWbcloXFdrZx0qTKjrarKtNNz7NTNOgTckyLRYICS
> Dd/OzC6cF5rNbF3js2JRhy3BxvTsmPRUN5w3+Tl4pxmaP7sC+Z7s/otaYpi/rMROi5DWmkcKaUoc
> 9P+5o6SYfFymr5J7i0tLc/Q4OGaIZaWj7fjuPNiNj6N2pWTbw2AcAhukqqIRKl3fChGqtLAnUb/t
> 3G71Sd+KaU25e8HmAFlBk6zKjnuOFg0RWgArerGdBLvMHMA5ykMdebw...

Read more...

Revision history for this message
Glenn Barnich (gbarnich) wrote :
Download full text (4.0 KiB)

Hi,

Here is a reply I got from an old firmware user confirming that the directory /ebooks for the DR1000 is of no real use and that the proposed change will not have a negative effect.

http://www.mobileread.com/forums/showthread.php?t=156332

Regards,
G

On 12 Nov 2011, at 02:36, Paula Mulder wrote:

> I am about ready to throw this ebook out the nearest window. I have
> never had so much trouble with a device in my life.
>
> ** Changed in: calibre
> Assignee: (unassigned) => Paula Mulder (genemulder)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/883616
>
> Title:
> IREX DR Driver root directory
>
> Status in calibre: e-book management:
> Incomplete
>
> Bug description:
> Loading image...done
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: <email address hidden>
> # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
> # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
> # timestamp: 2011-10-29 20:36:54 +0200
> # base_revision_id: <email address hidden>-\
> # i239c4whbhw4y23a
> #
> # Begin patch
> === modified file 'src/calibre/devices/irexdr/driver.py'
> --- src/calibre/devices/irexdr/driver.py 2010-10-04 03:18:26 +0000
> +++ src/calibre/devices/irexdr/driver.py 2011-10-29 18:36:00 +0000
> @@ -27,24 +27,27 @@
> BCD = [0x322]
>
> VENDOR_NAME = 'IREX'
> - WINDOWS_MAIN_MEM = 'DR1000'
> +
> + EBOOK_DIR_MAIN = ''
> + EBOOK_DIR_CARD_A = ''
> +
> + WINDOWS_MAIN_MEM = ''
>
> OSX_MAIN_MEM = 'iRex DR1000 Media'
> -
> MAIN_MEMORY_VOLUME_LABEL = 'IRex Digital Reader 1000 Main Memory'
>
> - EBOOK_DIR_MAIN = 'ebooks'
> - DELETE_EXTS = ['.mbp']
> +
> + DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
> class IREXDR800(IREXDR1000):
> name = 'IRex Digital Reader 800 Device Interface'
> description = _('Communicate with the IRex Digital Reader 800')
> PRODUCT_ID = [0x002]
> - WINDOWS_MAIN_MEM = 'DR800'
> + WINDOWS_MAIN_MEM = ''
> FORMATS = ['epub', 'pdb', 'html', 'pdf', 'txt']
>
> - EBOOK_DIR_MAIN = 'Books'
> + EBOOK_DIR_MAIN = ''
> DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
>
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWXDszVgAAbzfgEAQUOf/936v
> nMq/7//wUAQars3Dbp0Hu9tm8JJI00jTBMp6TAmI00IDTyGmkaZHqaDJEMCZNTU2k0aNAAAANGgA
> CUE0FNMqeZCnqbU2o9IDQ9RoGgaB6jQNqknpo0j0ieTSfqh6gyMQAABoPSAJSU2k9MmqeSP1T2pq
> ZNNqaZMTJoADCBoMBo1bSnqU+2XabNZFy673ZKaNsBRUTY1h2weUqaAE4DKjfNzW7rzDMj8+Ye8c
> Ko8+ip75BVM9pGhE7j8zj5F6sMe36NqXx7N/LBTw9nGveW+jU+9r+Uc79ESiEaJOfiqvdQz5pYs+
> Z7p3dmFOZHWjpR5MasUx7z3i4PcUZOLaZip2fhftQWGhXBFiWEbNfZLoTRZGKLC89RYi9TJYwkip
> 0hR2EFbJGQGojI6O6ZJmHLlWaV6oM1YM6I3s38zlZoGZMjX04wgUQMIm9Iium/3l/6TddyUVwczG
> S6YWTCRVEr7Lbb9YXLnYRBRrneooLGubFfMGKIF2qBMCgumy2i1sEA91SXii44yp8gVRa0zcfu4O
> CynRNTGh6YTtWUUGGu6QUIxiHRRgoDbXQGstYaj+l8EhYhXiAyBwH4qXBIVMezLKCE0wFsjGNiXg
> 5cYqHE1ptZiUc76LJjfs531wsGZ18yhkYqBwWbcloXFdrZx0qTKjrarKtNNz7NTNOgTckyLRYICS
> Dd/OzC6cF5rNbF3js2JRhy3Bx...

Read more...

Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in lp:calibre

Fixed in branch lp:calibre. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased

Changed in calibre:
status: Incomplete → Fix Released
Revision history for this message
Glenn Barnich (gbarnich) wrote : Re: [Bug 883616] Fixed in lp:calibre
Download full text (3.7 KiB)

thanks, great!

On 19 Nov 2011, at 10:47, Kovid Goyal wrote:

> Fixed in branch lp:calibre. The fix will be in the next release. calibre
> is usually released every Friday.
>
> status fixreleased
>
> ** Changed in: calibre
> Status: Incomplete => Fix Released
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/883616
>
> Title:
> IREX DR Driver root directory
>
> Status in calibre: e-book management:
> Fix Released
>
> Bug description:
> Loading image...done
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: <email address hidden>
> # target_branch: http://bazaar.launchpad.net/~kovid/calibre/trunk/
> # testament_sha1: 38c5471c63aa74698f2c1bebff24d3346ce29feb
> # timestamp: 2011-10-29 20:36:54 +0200
> # base_revision_id: <email address hidden>-\
> # i239c4whbhw4y23a
> #
> # Begin patch
> === modified file 'src/calibre/devices/irexdr/driver.py'
> --- src/calibre/devices/irexdr/driver.py 2010-10-04 03:18:26 +0000
> +++ src/calibre/devices/irexdr/driver.py 2011-10-29 18:36:00 +0000
> @@ -27,24 +27,27 @@
> BCD = [0x322]
>
> VENDOR_NAME = 'IREX'
> - WINDOWS_MAIN_MEM = 'DR1000'
> +
> + EBOOK_DIR_MAIN = ''
> + EBOOK_DIR_CARD_A = ''
> +
> + WINDOWS_MAIN_MEM = ''
>
> OSX_MAIN_MEM = 'iRex DR1000 Media'
> -
> MAIN_MEMORY_VOLUME_LABEL = 'IRex Digital Reader 1000 Main Memory'
>
> - EBOOK_DIR_MAIN = 'ebooks'
> - DELETE_EXTS = ['.mbp']
> +
> + DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
> class IREXDR800(IREXDR1000):
> name = 'IRex Digital Reader 800 Device Interface'
> description = _('Communicate with the IRex Digital Reader 800')
> PRODUCT_ID = [0x002]
> - WINDOWS_MAIN_MEM = 'DR800'
> + WINDOWS_MAIN_MEM = ''
> FORMATS = ['epub', 'pdb', 'html', 'pdf', 'txt']
>
> - EBOOK_DIR_MAIN = 'Books'
> + EBOOK_DIR_MAIN = ''
> DELETE_EXTS = []
> SUPPORTS_SUB_DIRS = True
>
>
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWXDszVgAAbzfgEAQUOf/936v
> nMq/7//wUAQars3Dbp0Hu9tm8JJI00jTBMp6TAmI00IDTyGmkaZHqaDJEMCZNTU2k0aNAAAANGgA
> CUE0FNMqeZCnqbU2o9IDQ9RoGgaB6jQNqknpo0j0ieTSfqh6gyMQAABoPSAJSU2k9MmqeSP1T2pq
> ZNNqaZMTJoADCBoMBo1bSnqU+2XabNZFy673ZKaNsBRUTY1h2weUqaAE4DKjfNzW7rzDMj8+Ye8c
> Ko8+ip75BVM9pGhE7j8zj5F6sMe36NqXx7N/LBTw9nGveW+jU+9r+Uc79ESiEaJOfiqvdQz5pYs+
> Z7p3dmFOZHWjpR5MasUx7z3i4PcUZOLaZip2fhftQWGhXBFiWEbNfZLoTRZGKLC89RYi9TJYwkip
> 0hR2EFbJGQGojI6O6ZJmHLlWaV6oM1YM6I3s38zlZoGZMjX04wgUQMIm9Iium/3l/6TddyUVwczG
> S6YWTCRVEr7Lbb9YXLnYRBRrneooLGubFfMGKIF2qBMCgumy2i1sEA91SXii44yp8gVRa0zcfu4O
> CynRNTGh6YTtWUUGGu6QUIxiHRRgoDbXQGstYaj+l8EhYhXiAyBwH4qXBIVMezLKCE0wFsjGNiXg
> 5cYqHE1ptZiUc76LJjfs531wsGZ18yhkYqBwWbcloXFdrZx0qTKjrarKtNNz7NTNOgTckyLRYICS
> Dd/OzC6cF5rNbF3js2JRhy3BxvTsmPRUN5w3+Tl4pxmaP7sC+Z7s/otaYpi/rMROi5DWmkcKaUoc
> 9P+5o6SYfFymr5J7i0tLc/Q4OGaIZaWj7fjuPNiNj6N2pWTbw2AcAhukqqIRKl3fChGqtLAnUb/t
> 3G71Sd+KaU25e8HmAFlBk6zKjnuOFg0RWgArerGdBLvMHMA5ykMdebwKCcv4aLylTOS8DG+GK8SB
> mLFxXBe3Dgz4etpoRK3Q12WPCdfGyWQyZ...

Read more...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.