calibre

Bug #799471
Comment #2

Comment 2 for bug 799471

Revision history for this message

Kovid Goyal (kovid) wrote on 2011-06-19: Re: [Bug 799471] Re: News Tag inconsistancy (in german version)

Originally, it was not possible to have the title of the periodical not added as a tag, that option was added relatively recently.

It doesn't really make sense to have a News entry under the news category, so I'm not sure if this can be fixed.

On Sun, Jun 19, 2011 at 05:36:34PM -0000, Charles Haley wrote:
> @kovid: two issues here. The first is a bug -- I forgot to use a
> translated string when I added click-on-news-to-search to the tag
> browser last week. I will fix this.
>
> The second issue is the one the OP is posting about. It has been there
> forever, and is in every translation. The tag_browser_news temp view
> explicitly removes the News tag (in whatever language) from the results
> for get_categories. Result: that tag never appears in the News category,
> which means that no tags are in the category if no book is tagged with
> something in addition to News. That is why the News category contains
> zero items. Is this what you want? My guess is yes, because that code
> has been there for as long as I have worked on calibre, some 18 months
> now, but I can make a reasonable argument that the News tag should be
> listed so I can get a count of books with that tag.
>
> ** Changed in: calibre
> Status: New => In Progress
>
> ** Changed in: calibre
> Assignee: (unassigned) => Charles Haley (cbhaley)
>
> --
> You received this bug notification because you are subscribed to
> calibre.
> https://bugs.launchpad.net/bugs/799471
>
> Title:
> News Tag inconsistancy (in german version)
>
> Status in calibre: e-book management:
> In Progress
>
> Bug description:
> Just a little issue
>
> In the german version of calibre, news from the news download is
> called "Nachrichten". They also get the tag "Nachrichten". In the tag
> browser, there is a collection for news (called "Nachrichten")
> additional to normal tags. This collection is always empty, also if
> news have been downloaded. Only if I manually set the tag "News" to an
> entry, it will appear in "Nachrichten". (In the normal tag collection,
> also "Nachrichten" appear.)
>
> So it seems that in the tag browser the selection of "Nachrichten" has
> been forgotten in the translation and still selects "News" instead of
> "Nachrichten". That's of cause not a serious problem, just a tiny and
> unimportent bug.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/calibre/+bug/799471/+subscriptions
>
> !DSPAM:3,4dfe35ce9888772916120!
>
>

--
_____________________________________

Dr. Kovid Goyal
http://www.kovidgoyal.net
http://calibre-ebook.com
_____________________________________

Originally, it was not possible to have the title of the periodical not added as a tag, that option was added relatively recently.

It doesn't really make sense to have a News entry under the news category, so I'm not sure if this can be fixed.

On Sun, Jun 19, 2011 at 05:36:34PM -0000, Charles Haley wrote:
> @kovid: two issues here. The first is a bug -- I forgot to use a
> translated string when I added click-on-news-to-search to the tag
> browser last week. I will fix this.
> 
> The second issue is the one the OP is posting about. It has been there
> forever, and is in every translation. The tag_browser_news temp view
> explicitly removes the News tag (in whatever language) from the results
> for get_categories. Result: that tag never appears in the News category,
> which means that no tags are in the category if no book is tagged with
> something in addition to News. That is why the News category contains
> zero items. Is this what you want? My guess is yes, because that code
> has been there for as long as I have worked on calibre, some 18 months
> now, but I can make a reasonable argument that the News tag should be
> listed so I can get a count of books with that tag.
> 
> ** Changed in: calibre
>        Status: New => In Progress
> 
> ** Changed in: calibre
>      Assignee: (unassigned) => Charles Haley (cbhaley)
> 
> -- 
> You received this bug notification because you are subscribed to
> calibre.
> https://bugs.launchpad.net/bugs/799471
> 
> Title:
>   News Tag inconsistancy (in german version)
> 
> Status in calibre: e-book management:
>   In Progress
> 
> Bug description:
>   Just a little issue
> 
>   In the german version of calibre, news from the news download is
>   called "Nachrichten". They also get the tag "Nachrichten". In the tag
>   browser, there is a collection for news (called "Nachrichten")
>   additional to normal tags. This collection is always empty, also if
>   news have been downloaded. Only if I manually set the tag "News" to an
>   entry, it will appear in "Nachrichten". (In the normal tag collection,
>   also "Nachrichten" appear.)
> 
>   So it seems that in the tag browser the selection of "Nachrichten" has
>   been forgotten in the translation and still selects "News" instead of
>   "Nachrichten". That's of cause not a serious problem, just a tiny and
>   unimportent bug.
> 
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/calibre/+bug/799471/+subscriptions
> 
> !DSPAM:3,4dfe35ce9888772916120!
> 
>

-- 
_____________________________________

Dr. Kovid Goyal 
http://www.kovidgoyal.net
http://calibre-ebook.com
_____________________________________