News Tag inconsistancy (in german version)

Bug #799471 reported by Klaus Mueller
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
calibre
Fix Released
Undecided
Charles Haley

Bug Description

Just a little issue

In the german version of calibre, news from the news download is called "Nachrichten". They also get the tag "Nachrichten". In the tag browser, there is a collection for news (called "Nachrichten") additional to normal tags. This collection is always empty, also if news have been downloaded. Only if I manually set the tag "News" to an entry, it will appear in "Nachrichten". (In the normal tag collection, also "Nachrichten" appear.)

So it seems that in the tag browser the selection of "Nachrichten" has been forgotten in the translation and still selects "News" instead of "Nachrichten". That's of cause not a serious problem, just a tiny and unimportent bug.

Related branches

Revision history for this message
Charles Haley (cbhaley) wrote :

@kovid: two issues here. The first is a bug -- I forgot to use a translated string when I added click-on-news-to-search to the tag browser last week. I will fix this.

The second issue is the one the OP is posting about. It has been there forever, and is in every translation. The tag_browser_news temp view explicitly removes the News tag (in whatever language) from the results for get_categories. Result: that tag never appears in the News category, which means that no tags are in the category if no book is tagged with something in addition to News. That is why the News category contains zero items. Is this what you want? My guess is yes, because that code has been there for as long as I have worked on calibre, some 18 months now, but I can make a reasonable argument that the News tag should be listed so I can get a count of books with that tag.

Changed in calibre:
assignee: nobody → Charles Haley (cbhaley)
status: New → In Progress
Revision history for this message
Kovid Goyal (kovid) wrote : Re: [Bug 799471] Re: News Tag inconsistancy (in german version)

Originally, it was not possible to have the title of the periodical not added as a tag, that option was added relatively recently.

It doesn't really make sense to have a News entry under the news category, so I'm not sure if this can be fixed.

On Sun, Jun 19, 2011 at 05:36:34PM -0000, Charles Haley wrote:
> @kovid: two issues here. The first is a bug -- I forgot to use a
> translated string when I added click-on-news-to-search to the tag
> browser last week. I will fix this.
>
> The second issue is the one the OP is posting about. It has been there
> forever, and is in every translation. The tag_browser_news temp view
> explicitly removes the News tag (in whatever language) from the results
> for get_categories. Result: that tag never appears in the News category,
> which means that no tags are in the category if no book is tagged with
> something in addition to News. That is why the News category contains
> zero items. Is this what you want? My guess is yes, because that code
> has been there for as long as I have worked on calibre, some 18 months
> now, but I can make a reasonable argument that the News tag should be
> listed so I can get a count of books with that tag.
>
> ** Changed in: calibre
> Status: New => In Progress
>
> ** Changed in: calibre
> Assignee: (unassigned) => Charles Haley (cbhaley)
>
> --
> You received this bug notification because you are subscribed to
> calibre.
> https://bugs.launchpad.net/bugs/799471
>
> Title:
> News Tag inconsistancy (in german version)
>
> Status in calibre: e-book management:
> In Progress
>
> Bug description:
> Just a little issue
>
> In the german version of calibre, news from the news download is
> called "Nachrichten". They also get the tag "Nachrichten". In the tag
> browser, there is a collection for news (called "Nachrichten")
> additional to normal tags. This collection is always empty, also if
> news have been downloaded. Only if I manually set the tag "News" to an
> entry, it will appear in "Nachrichten". (In the normal tag collection,
> also "Nachrichten" appear.)
>
> So it seems that in the tag browser the selection of "Nachrichten" has
> been forgotten in the translation and still selects "News" instead of
> "Nachrichten". That's of cause not a serious problem, just a tiny and
> unimportent bug.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/calibre/+bug/799471/+subscriptions
>
> !DSPAM:3,4dfe35ce9888772916120!
>
>

--
_____________________________________

Dr. Kovid Goyal
http://www.kovidgoyal.net
http://calibre-ebook.com
_____________________________________

Revision history for this message
Charles Haley (cbhaley) wrote :

OK, I will push the search change.

A consequence of not having the News tag under News is that it is difficult to see the number of news articles in the library. Getting that number requires a search (click on News) or going to Tags to see the count on the News tag.

The fix is technically trivial -- change the temp view creation in db2 to remove the test for tag == News. Whether it makes sense or not I can't say. I don't use the News tag at all, so in the end I don't care one way or the other. :)

Charles Haley (cbhaley)
Changed in calibre:
status: In Progress → Fix Committed
Revision history for this message
Kovid Goyal (kovid) wrote : Fixed in lp:calibre

Fixed in branch lp:calibre. The fix will be in the next release. calibre is usually released every Friday.

 status fixreleased

Changed in calibre:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.