News Tag inconsistancy (in german version)
Bug #799471 reported by
Klaus Mueller
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
calibre |
Fix Released
|
Undecided
|
Charles Haley |
Bug Description
Just a little issue
In the german version of calibre, news from the news download is called "Nachrichten". They also get the tag "Nachrichten". In the tag browser, there is a collection for news (called "Nachrichten") additional to normal tags. This collection is always empty, also if news have been downloaded. Only if I manually set the tag "News" to an entry, it will appear in "Nachrichten". (In the normal tag collection, also "Nachrichten" appear.)
So it seems that in the tag browser the selection of "Nachrichten" has been forgotten in the translation and still selects "News" instead of "Nachrichten". That's of cause not a serious problem, just a tiny and unimportent bug.
Related branches
lp:~cbhaley/calibre/calibre_dev
- Kovid Goyal: Pending requested
-
Diff: 17 lines (+5/-2)1 file modifiedsrc/calibre/library/caches.py (+5/-2)
Changed in calibre: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
@kovid: two issues here. The first is a bug -- I forgot to use a translated string when I added click-on- news-to- search to the tag browser last week. I will fix this.
The second issue is the one the OP is posting about. It has been there forever, and is in every translation. The tag_browser_news temp view explicitly removes the News tag (in whatever language) from the results for get_categories. Result: that tag never appears in the News category, which means that no tags are in the category if no book is tagged with something in addition to News. That is why the News category contains zero items. Is this what you want? My guess is yes, because that code has been there for as long as I have worked on calibre, some 18 months now, but I can make a reasonable argument that the News tag should be listed so I can get a count of books with that tag.