Comment 2 for bug 629150

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 629150] Re: bzr version-info is accessing bound branch location

1 seems sensible to me. Perhaps update should also make sure that the local branch has the same nick as the remote branch?

Cheers, jelmer

Martin Packman <email address hidden> wrote:

>This is fallout from fixing bug 230903, and also fulfilling the
>behaviour bug 148030 asks for. But bug 882541 shows it's still causing
>pain.
>
>I see two possible approaches for resolving this issue:
>
>1) When creating a bound branch, get the explicit or implied remote
>nick, and set it as the explicit local nick. This means it won't then
>requery for it each time, at the cost of not detecting if the remote
>branch's nick changes. It also won't fix the issue for people who've
>already created bound branches, they'll want to set the nick explictly
>themselves.
>
>2) In version_info rather than doing `self._branch.nick` do
>`self._branch._get_nick(local=True)` which has basically the same
>effect
>as the above, but leaves the slow nick fetch problem around for other
>commands. It also may surprise some people by starting to return the
>name of the local directory rather than whatever the remote branch has
>as the nickname.
>
>** Changed in: bzr
> Importance: Low => Medium
>
>--
>You received this bug notification because you are a member of
>bzr-core,
>which is subscribed to Bazaar.
>https://bugs.launchpad.net/bugs/629150
>
>Title:
> bzr version-info is accessing bound branch location
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/bzr/+bug/629150/+subscriptions

--
Sent from my phone. Please excuse my brevity.