bzr version-info is accessing bound branch location
Bug #629150 reported by
Henrik Nordström
This bug affects 5 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Medium
|
Unassigned |
Bug Description
If running bzr version-info on a bound branch then it accesses the bound branch location for no apparent reason. All data it needs should be available in the local repository.
lifeless guess on why:
(00.57.16) lifeless: oh I know
(00.57.21) lifeless: probably getting branch nick
(00.57.33) lifeless: there is a api it can use to avoid using the master one
tested with bzr 2.1.2.
Changed in bzr: | |
importance: | Undecided → Low |
status: | New → Confirmed |
tags: | added: check-for-breezy |
To post a comment you must log in.
This is fallout from fixing bug 230903, and also fulfilling the behaviour bug 148030 asks for. But bug 882541 shows it's still causing pain.
I see two possible approaches for resolving this issue:
1) When creating a bound branch, get the explicit or implied remote nick, and set it as the explicit local nick. This means it won't then requery for it each time, at the cost of not detecting if the remote branch's nick changes. It also won't fix the issue for people who've already created bound branches, they'll want to set the nick explictly themselves.
2) In version_info rather than doing `self._branch.nick` do `self._ branch. _get_nick( local=True) ` which has basically the same effect as the above, but leaves the slow nick fetch problem around for other commands. It also may surprise some people by starting to return the name of the local directory rather than whatever the remote branch has as the nickname.