Comment 1 for bug 603461

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Public bug reported:
>
> revno 5339 introduced a regression, the bzrlib.tests.blackbox.test_log.TestLogErrors.test_log_bad_message_re test is failing
> on freebsd, hardy and jaunty.
>
> See:
> http://babune.ladeuil.net:24842/job/selftest-freebsd/128/
> http://babune.ladeuil.net:24842/job/selftest-hardy/139/
> http://babune.ladeuil.net:24842/job/selftest-jaunty/132/
>

It looks like older versions of python didn't give the detail as to why
the regex error happened. If you look at:

> AssertionError: pattern "ERROR.*Invalid pattern.*nothing to repeat" not found in
> """\
> bzr: ERROR: Unprintable exception InvalidPattern: dict={}, fmt='Invalid pattern(s) found. %(message)s', error=KeyError('message',)
> """
>
It shows that 'ERROR.*InvalidPattern' is valid. I'm a bit concerned
about the 'Unprintable exception' part. Did we add proper tests to
bzrlib/tests/test_errrors.py?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw3KBEACgkQJdeBCYSNAAMj2QCeIS8UTw1oCOIgVaHe6CHG5E8e
ffMAn0QgzNEPeydEfXRJv5pdGdTgbN1C
=41UW
-----END PGP SIGNATURE-----