bzrlib.tests.blackbox.test_log.TestLogErrors.test_log_bad_message_re failing

Bug #603461 reported by Vincent Ladeuil on 2010-07-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
High
Parth Malwankar

Bug Description

revno 5339 introduced a regression, the bzrlib.tests.blackbox.test_log.TestLogErrors.test_log_bad_message_re test is failing
on freebsd, hardy and jaunty.

See:
http://babune.ladeuil.net:24842/job/selftest-freebsd/128/
http://babune.ladeuil.net:24842/job/selftest-hardy/139/
http://babune.ladeuil.net:24842/job/selftest-jaunty/132/

Related branches

Vincent Ladeuil (vila) on 2010-07-09
Changed in bzr:
status: New → Confirmed
importance: Undecided → High

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Public bug reported:
>
> revno 5339 introduced a regression, the bzrlib.tests.blackbox.test_log.TestLogErrors.test_log_bad_message_re test is failing
> on freebsd, hardy and jaunty.
>
> See:
> http://babune.ladeuil.net:24842/job/selftest-freebsd/128/
> http://babune.ladeuil.net:24842/job/selftest-hardy/139/
> http://babune.ladeuil.net:24842/job/selftest-jaunty/132/
>

It looks like older versions of python didn't give the detail as to why
the regex error happened. If you look at:

> AssertionError: pattern "ERROR.*Invalid pattern.*nothing to repeat" not found in
> """\
> bzr: ERROR: Unprintable exception InvalidPattern: dict={}, fmt='Invalid pattern(s) found. %(message)s', error=KeyError('message',)
> """
>
It shows that 'ERROR.*InvalidPattern' is valid. I'm a bit concerned
about the 'Unprintable exception' part. Did we add proper tests to
bzrlib/tests/test_errrors.py?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw3KBEACgkQJdeBCYSNAAMj2QCeIS8UTw1oCOIgVaHe6CHG5E8e
ffMAn0QgzNEPeydEfXRJv5pdGdTgbN1C
=41UW
-----END PGP SIGNATURE-----

Parth Malwankar (parthm) wrote :

Thats weird. This seems to pass on 2.4.6. There doesn't seem to be an older 2.4 on the Python site (http://python.org/download/releases/).
What is the version of Python being used?

Parth Malwankar (parthm) wrote :

Ah, I wasn't aware of bt.test_errors. I will add a test for InvalidPattern to that.
I can look into fixing this issue if I can reproduce it locally.

Parth Malwankar (parthm) wrote :

I am able to reproduce it. This works on Python 2.4 and 2.6 but fails on Python 2.5.

Changed in bzr:
assignee: nobody → Parth Malwankar (parthm)
status: Confirmed → In Progress

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Parth Malwankar wrote:
> I am able to reproduce it. This works on Python 2.4 and 2.6 but fails on
> Python 2.5.
>
>
> ** Changed in: bzr
> Assignee: (unassigned) => Parth Malwankar (parthm)
>
> ** Changed in: bzr
> Status: Confirmed => In Progress
>

Which is why it passed on our machines (most run 2.6 now) and on PQM
(runs 2.4) I guess. :)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw3RfsACgkQJdeBCYSNAAPd6ACeL6MtTo5+jbExOfwG0j1nwh0C
/MgAn35otxcVIbZc1d6fCwofXPV3FgqQ
=AaDx
-----END PGP SIGNATURE-----

Vincent Ladeuil (vila) wrote :

babune@hardy32:~$ python -V
Python 2.5.2

[babune@freebsd8 ~]$ python -V
Python 2.5.5

babune@jaunty64:~$ python -V
Python 2.6.2

So at least one 2.6 is failing.

Parth Malwankar (parthm) on 2010-07-16
Changed in bzr:
milestone: none → 2.2.0
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers