Comment 4 for bug 561110

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 561110] Re: should set tag directly if pristine tar delta is empty

On Thu, 2010-04-15 at 16:00 +0000, James Westby wrote:
> On Thu, 15 Apr 2010 15:46:43 -0000, Jelmer Vernooij <email address hidden> wrote:
> > On Mon, 2010-04-12 at 09:12 +0000, James Westby wrote:
> > > That makes sense, but we should have some way to mark that it doesn't
> > > need a delta either.
> > Can you expand a bit? Do you mean determining that it doesn't need a
> > delta so we can avoid running pristine-tar ?
> Yeah, we should set a revprop saying "we would have put a delta here,
> but didn't need to, so just export." Maybe you don't think it's needed.

> In addition, should we be concerned that your bzr version might not need
> a delta, but mine might?
Yeah, I think we should refuse to export from a upstream- tagged
revision if it doesn't have any of the pristine tar delta *and*
bzrlib.export doesn't support the per_file_timestamps argument. That
should be sufficient to prevent accidentally bzr-builddeb from creating
a tarball with different timestamps.

Cheers,

Jelmer