should set tag directly if pristine tar delta is empty

[Jelmer Vernooij]

If the pristine tar delta between the tagged revision upstream and the tarball that is imported is empty, then bzr-builddeb should just set a 'upstream-VERSION' tag on the upstream tagged revision, rather than creating a new commit with an empty pristine tar delta.

It's possible now for this to happen because 'bzr export' can create tarballs with deterministic timestamps.

[James Westby (james-w)]

Hi,

That makes sense, but we should have some way to mark that it doesn't
need a delta either.

Thanks,

James

[Jelmer Vernooij (jelmer)]

On Mon, 2010-04-12 at 09:12 +0000, James Westby wrote:
> That makes sense, but we should have some way to mark that it doesn't
> need a delta either.
Can you expand a bit? Do you mean determining that it doesn't need a
delta so we can avoid running pristine-tar ?

Cheers,

Jelmer

[James Westby (james-w)]

On Thu, 15 Apr 2010 15:46:43 -0000, Jelmer Vernooij <email address hidden> wrote:
> On Mon, 2010-04-12 at 09:12 +0000, James Westby wrote:
> > That makes sense, but we should have some way to mark that it doesn't
> > need a delta either.
> Can you expand a bit? Do you mean determining that it doesn't need a
> delta so we can avoid running pristine-tar ?

Yeah, we should set a revprop saying "we would have put a delta here,
but didn't need to, so just export." Maybe you don't think it's needed.

In addition, should we be concerned that your bzr version might not need
a delta, but mine might?

Thanks,

James

[Jelmer Vernooij (jelmer)]

On Thu, 2010-04-15 at 16:00 +0000, James Westby wrote:
> On Thu, 15 Apr 2010 15:46:43 -0000, Jelmer Vernooij <email address hidden> wrote:
> > On Mon, 2010-04-12 at 09:12 +0000, James Westby wrote:
> > > That makes sense, but we should have some way to mark that it doesn't
> > > need a delta either.
> > Can you expand a bit? Do you mean determining that it doesn't need a
> > delta so we can avoid running pristine-tar ?
> Yeah, we should set a revprop saying "we would have put a delta here,
> but didn't need to, so just export." Maybe you don't think it's needed.

> In addition, should we be concerned that your bzr version might not need
> a delta, but mine might?
Yeah, I think we should refuse to export from a upstream- tagged
revision if it doesn't have any of the pristine tar delta *and*
bzrlib.export doesn't support the per_file_timestamps argument. That
should be sufficient to prevent accidentally bzr-builddeb from creating
a tarball with different timestamps.

Cheers,

Jelmer

[James Westby (james-w)]

On Thu, 15 Apr 2010 16:24:14 -0000, Jelmer Vernooij <email address hidden> wrote:
> Yeah, I think we should refuse to export from a upstream- tagged
> revision if it doesn't have any of the pristine tar delta *and*
> bzrlib.export doesn't support the per_file_timestamps argument. That
> should be sufficient to prevent accidentally bzr-builddeb from creating
> a tarball with different timestamps.

Right, so if you create one of these revisions, and then I try and build
it with an old bzr-builddeb it won't try and export anyway as there is
no delta.

I think that's fine then.

Thanks,

James