Taps time out erroneously and don't fire
Bug #962705 reported by
Chase Douglas
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Geis |
Fix Released
|
Medium
|
Chase Douglas | ||
Grail |
Fix Released
|
Medium
|
Chase Douglas | ||
utouch-geis (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
utouch-grail (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
In the geis and grail tool code, when an X sync event is received the current server time is requested. The server time may have advanced in the time between the X sync event generation and this new request. If the server time has advanced beyond the tap timeout for a tap, and the tap ended after the X sync event generation, the tap gesture will be rejected erroneously.
Related branches
lp:~chasedouglas/geis/fix-tap
- Stephen M. Webb (community): Approve
-
Diff: 26 lines (+4/-12)1 file modifiedlibutouch-geis/backend/grail/geis_grail_backend.c (+4/-12)
lp:~chasedouglas/grail/use-sync-event-time
- Stephen M. Webb (community): Approve
-
Diff: 93 lines (+10/-20)6 files modifiedtools/common/servertime.c (+5/-15)
tools/common/servertime.h (+1/-1)
tools/grail-test-3-1.c (+1/-1)
tools/grail-test-atomic.c (+1/-1)
tools/grail-test-edge.c (+1/-1)
tools/grail-test-propagation.c (+1/-1)
Changed in utouch-grail: | |
status: | New → In Progress |
Changed in utouch-geis (Ubuntu): | |
status: | New → In Progress |
Changed in utouch-grail (Ubuntu): | |
status: | New → In Progress |
Changed in utouch-grail: | |
importance: | Undecided → Medium |
Changed in utouch-geis (Ubuntu): | |
importance: | Undecided → Medium |
Changed in utouch-grail (Ubuntu): | |
importance: | Undecided → Medium |
Changed in utouch-grail: | |
assignee: | nobody → Chase Douglas (chasedouglas) |
milestone: | none → utouch-grail-3.0.4 |
Changed in utouch-grail: | |
status: | In Progress → Fix Committed |
Changed in utouch-geis: | |
status: | In Progress → Fix Committed |
Changed in utouch-grail: | |
status: | Fix Committed → Fix Released |
Changed in utouch-geis: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package utouch-grail - 3.0.4-0ubuntu1
---------------
utouch-grail (3.0.4-0ubuntu1) precise; urgency=low
[ Stephen M. Webb ] utouch- grail-tools. install: added manpages (LP: #955609)
* debian/copyright: changed library to LGPL-3 license (LP: #963070)
* debian/
[ Daniel d'Andrada ]
* New upstream release
- Fix utouch-grail needs to be relicensed under LGPLv3 (LP: #963070)
- Fix taps time out erroneously and don't fire (LP: #962705)
- Fix virtual destructors to SliceCheckerState (LP: #962886)
- Fix uninitialized variable in SliceChecker (LP: #962904)
- Fix tests can only be run when built in-source (LP: #962919)
- Fix needless memory growth from undeleted Gesture instances (LP: #965260)
- Fix touch state accounting should be managed better (LP: #966688)
- Fix no touch events while utouch-grail clients wait for next timeout
(LP: #967605)
- Fix premature gesture acceptance possible upon timestamps mismatch
(LP: #963379)
- Fix utouch-grail FTBFS in daily PPA (LP: #966367)
- Fix utouch-grail-tools package is missing manpages (LP: #955609)
[ Chase Douglas ]
* Build with debhelper --parallel
* Disable integration tests during package build
* Remove --with-xi configure flag, it is obsolete
-- Chase Douglas <email address hidden> Fri, 30 Mar 2012 16:03:04 -0700