Creating a filter fails if no matching devices are present

Bug #904731 reported by Jussi Pakkanen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Geis
Fix Released
High
Stephen M. Webb
utouch-geis (Ubuntu)
Fix Released
High
Stephen M. Webb

Bug Description

Get code from here: https://code.launchpad.net/~jpakkane/+junk/geis-drag

Build and run, get this:

GEIS_DEBUG=2 ./geis-example
GEIS(warning)-_set_valist:566 back end not specified, defaulting to DBus
GEIS(warning)-_locator_message_handler:120 server not found!
Geis subscription activation failed.

This worked a few days ago with the exact same piece of code.

Related branches

Revision history for this message
Stephen M. Webb (bregma) wrote :

The geis-example code no longer selects gestures on touchscreen devices when there is no touchscreen device present as a result of fixing #89173.

This is correct behaviour. You will find the test program works correctly on a system with a real or emulated touchscreen device.

Changed in utouch-geis:
status: New → Invalid
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

If your subscription says "I don't want gestures from touch screen devices" it should succeed regardless of whether there are touch screen devices currently plugged in or not. Forcing the library user to do system instrospection for this is an unnecessary burden.

Changed in utouch-geis:
status: Invalid → Confirmed
Revision history for this message
Chase Douglas (chasedouglas) wrote :

A parallel case is with event subscription from the X server. A client can subscribe to touch events even if there are no touch devices present. If a touch device is added, then the subscription is still valid and the client doesn't need to do anything to receive events from it. Requiring a client to watch device additions and removals and then update the gesture subscriptions would be annoying and racy.

Changed in utouch-geis:
status: Confirmed → Triaged
importance: Undecided → High
assignee: nobody → Stephen M. Webb (bregma)
Changed in utouch-geis (Ubuntu):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Stephen M. Webb (bregma)
Revision history for this message
Chase Douglas (chasedouglas) wrote :

Stephen, I have a feeling this has been fixed. Can you verify?

Thanks!

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

If there are no touch devices connected, the program errors out with "Failed direct touch filter term creation."

If there are connected devices it works, but only vertical drag motion is reported. I tried to find bugs in the sample app but didn't find any.

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

The second issue was due to my faulty X config, sorry. The filter issue still stands, though.

Stephen M. Webb (bregma)
Changed in utouch-geis:
milestone: none → utouch-geis-2.2.7
Stephen M. Webb (bregma)
Changed in utouch-geis:
status: Triaged → In Progress
Changed in utouch-geis (Ubuntu):
status: Triaged → In Progress
summary: - Subscription fails with daily PPA
+ Creating a filter fails if no matching devices are present
Stephen M. Webb (bregma)
Changed in utouch-geis:
milestone: utouch-geis-2.2.7 → utouch-geis-2.2.8
Stephen M. Webb (bregma)
Changed in utouch-geis:
status: In Progress → Fix Committed
Stephen M. Webb (bregma)
Changed in utouch-geis:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package utouch-geis - 2.2.8-0ubuntu1

---------------
utouch-geis (2.2.8-0ubuntu1) precise; urgency=low

  [ Chase Douglas ]
  * Build integration tests where dependencies are available
    - Will not build tests in archive, will build tests in Jenkins systems

  [ Stephen M. Webb ]
  * New upstream release.
    - fixes filter creation when no matching devices are present (lp: #904731)
    - fixes Unity crashes in geis_filter_delete() (lp: #936815)
    - fixes touch event delay during timeout wait (lp: #967605)
    - fixes handling device addition/removal (lp: #944822)
    - fixes tap timeouts (lp: #962705)
    - fixes position delta on touch count changes (lp: #967267)
    - fixes window ungrab on subscription deactivation (lp: #968736)
    - fixes geistest crash on startup (lp: #966595)
  * Bumped minimum required version of utouch-geis to 3.0.4 for licensing
    changes.
 -- <email address hidden> (Stephen M. Webb) Sat, 31 Mar 2012 13:13:34 -0400

Changed in utouch-geis (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.