EngineBuffer ramp in and out interval is latency dependent
Bug #884567 reported by
RJ Skerry-Ryan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Medium
|
Owen Williams |
Bug Description
Looks like the ramp in and out behavior has changed significantly compared to 1.9.
In 1.9, the ramp out and in was 50 samples, something like 1ms @ 44.1kHz.
In 1.10, the ramp in is 5 callbacks worth of audio. The ramp-out is 12.5 callbacks of audio. At 20ms latency, this is a 100ms ramp in and a 250ms ramp out. It's pretty noticeable when you are previewing a hotcue, for example.
Ramp/in out should not depend on latency or the song samplerate (so both 1.9 and 1.10 are not ideal) -- it should be a desired time interval ramp-in like 1ms or 5ms. I think 1ms is enough to accomplish the task of ramp-in which is to smooth discontinuity caused by abrupt starts and stops.
Changed in mixxx: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
milestone: | none → 1.10.0 |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
That was my change. I'll see if I can reduce the length of the ramp without hurting the quality