Fix retention units (sec, min, etc.) for storage schemas (located in whisper.py) to match those accepted by Carbon and the Webapp
Bug #851428 reported by
Nicholas Leskiw
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
whisper |
Fix Committed
|
High
|
Nicholas Leskiw |
Bug Description
In whisper.py the units available appear to be:
UnitMultipliers = {
's' : 1,
'm' : 60,
'h' : 60 * 60,
'd' : 60 * 60 * 24,
'y' : 60 * 60 * 24 * 365,
}
These need to be fixed to match the ones accepted by the webapp and carbon.
This includes changing the detection from an index (currently string[-1]) to a regex match ([0-9])([A-Za-z])
Related branches
Changed in graphite: | |
importance: | Undecided → High |
assignee: | nobody → Nicholas Leskiw (nleskiw) |
Changed in graphite: | |
milestone: | 1.0.0 → 0.9.10 |
affects: | graphite → whisper |
Changed in whisper: | |
milestone: | 0.9.10 → none |
To post a comment you must log in.
So I don't know if you've started on this or not; I've got some code for this that just needs to be cleaned up a little. I copied the getUnitString method from webapp/ graphite/ render/ attime. py.