Comment 8 for bug 851428

Revision history for this message
chrismd (chrismd) wrote :

Hi Scott, just looked at your branch, a couple comments.

* Please don't bring "months" back as a unit, it's not a well-defined unit of time and people always come back with questions asking why their graphs don't look like they expect when they use it. The only reason it still exists in attime.py is for backwards compatibility, I'll announce its deprecated with the next release.
* I don't see the point of the change of 's' -> 'seconds' and using a regex, it seems much more complicated than a one letter suffix.