Topbar - window controls for maximised windows in the top bar should conform to Fitts's law
Bug #839690 reported by
John Lea
This bug affects 52 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Critical
|
John Lea | ||
Unity |
Fix Released
|
High
|
Marco Trevisan (Treviño) | ||
unity-2d |
Fix Released
|
Low
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
High
|
Marco Trevisan (Treviño) | ||
unity-2d (Ubuntu) |
Fix Released
|
Low
|
Unassigned |
Bug Description
Close, maximize/unmaximize and minimize button for maximised windows in the top bar should conform to Fitts law.
Desired solution:
- In addition to clicking directly on the 'close' window decoration, clicking anywhere to the left and above the 'close' window decoration (all the way to the top left pixel) should also trigger the 'close' action. The same goes for the other two (maximize/
Related branches
lp:~3v1n0/unity/panel-p-cleanup
- Tim Penhey (community): Approve
-
Diff: 7874 lines (+3128/-2131)28 files modifiedUnityCore/Variant.cpp (+31/-2)
UnityCore/Variant.h (+6/-1)
plugins/unityshell/src/DashController.cpp (+5/-3)
plugins/unityshell/src/DashController.h (+1/-0)
plugins/unityshell/src/LauncherController.cpp (+51/-8)
plugins/unityshell/src/PanelController.cpp (+27/-20)
plugins/unityshell/src/PanelController.h (+2/-4)
plugins/unityshell/src/PanelIndicatorEntryView.cpp (+440/-347)
plugins/unityshell/src/PanelIndicatorEntryView.h (+69/-45)
plugins/unityshell/src/PanelIndicatorsView.cpp (+103/-42)
plugins/unityshell/src/PanelIndicatorsView.h (+27/-18)
plugins/unityshell/src/PanelMenuView.cpp (+934/-859)
plugins/unityshell/src/PanelMenuView.h (+78/-90)
plugins/unityshell/src/PanelTitlebarGrabAreaView.cpp (+125/-13)
plugins/unityshell/src/PanelTitlebarGrabAreaView.h (+27/-6)
plugins/unityshell/src/PanelTray.cpp (+92/-115)
plugins/unityshell/src/PanelTray.h (+21/-24)
plugins/unityshell/src/PanelView.cpp (+123/-149)
plugins/unityshell/src/PanelView.h (+40/-45)
plugins/unityshell/src/PluginAdapter.cpp (+158/-24)
plugins/unityshell/src/PluginAdapter.h (+12/-3)
plugins/unityshell/src/SwitcherController.cpp (+9/-2)
plugins/unityshell/src/UBusMessages.h (+1/-0)
plugins/unityshell/src/WindowButtons.cpp (+587/-220)
plugins/unityshell/src/WindowButtons.h (+33/-12)
plugins/unityshell/src/WindowManager.cpp (+38/-10)
plugins/unityshell/src/WindowManager.h (+12/-6)
plugins/unityshell/src/unityshell.cpp (+76/-63)
lp:~ubuntu-desktop/unity/ubuntu
(Merged)
description: | updated |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
tags: | added: onew udo |
Changed in ayatana-design: | |
importance: | Undecided → Low |
status: | New → Fix Committed |
Changed in unity: | |
status: | New → Confirmed |
Changed in unity (Ubuntu): | |
status: | New → Confirmed |
Changed in unity: | |
importance: | Undecided → Low |
status: | Confirmed → Triaged |
Changed in unity (Ubuntu): | |
status: | Confirmed → Triaged |
importance: | Undecided → Low |
Changed in unity: | |
assignee: | nobody → Neil J. Patel (njpatel) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Neil J. Patel (njpatel) |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
summary: |
- Topbar - close button for maximised windows in the top bar should + Topbar - window controls for maximised windows in the top bar should conform to Fitts law |
description: | updated |
description: | updated |
summary: |
Topbar - window controls for maximised windows in the top bar should - conform to Fitts law + conform to Fitts's law |
tags: | added: udp |
Changed in unity: | |
milestone: | none → backlog |
Changed in ayatana-design: | |
status: | Fix Released → Fix Committed |
Changed in unity-2d: | |
assignee: | nobody → Lohith D Shivamurthy (dyams) |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in unity-2d: | |
milestone: | none → 5.2 |
Changed in unity-2d (Ubuntu): | |
importance: | Undecided → Low |
status: | Confirmed → Triaged |
Changed in unity-2d: | |
assignee: | Lohith D Shivamurthy (dyams) → nobody |
Changed in unity-2d: | |
milestone: | 5.2 → 5.4 |
Changed in ayatana-design: | |
importance: | Low → Medium |
Changed in unity: | |
importance: | Low → Medium |
Changed in unity-2d: | |
status: | Triaged → Fix Released |
Changed in unity-2d (Ubuntu): | |
status: | Triaged → Fix Released |
Changed in ayatana-design: | |
importance: | Medium → Critical |
Changed in unity: | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity: | |
milestone: | backlog → 5.6.0 |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
milestone: | 5.6.0 → 5.8.0 |
Changed in unity: | |
milestone: | 5.8.0 → 5.10.0 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
tags: | added: reviewedbydesignp |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: | removed: udo udp |
To post a comment you must log in.
Enabling the left edge pixel to activate the maximised close button is probably a bad idea. The close button can result in lose of state (or work) for the user involved.
In a maximised workflow the "Fitts Law" property of the Top-Left pixel is being used to show the Launcher; in the version of Unity shipped with 11.04 hitting this pixel caused for the Launcher to show *instantly*, rather than with the delay from purely hitting the left edge.
IMHO; if this is enabled for the left-edge pixels, it should still remain disabled for the very top-left edge corner pixel. So that a flick of the mouse and accompanied by a click will not cause the present window to vanish. None of the other corners have this unique risk, and I don't believe it's valuable to enable it for the close button.
If it was minimise or maximise it would be fine, as these are reversible actions, but close is not.