PPA Uploads are seemingly (but not actually) rejected
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
William Grant |
Bug Description
user visible symptoms
=======
dput says:
550 Changes file must be signed with a valid GPG signature: Verification failed 3 times: ['General error', 'General error', 'General error'] : Permission denied.
Note: This error might indicate a problem with your passive_ftp setting.
Please consult dput.cf(5) for details on this configuration option.
...but it turns out that the upload is actually accepted and processed and built and published, etc. This is very confusing.
This is not a security issue: there are two identical gpg checks in series, the first is only advisory, and is the one that is failing.
Operational symptoms
=======
The GPG temp directory is usable - manual verification of the one being kept up to date by the in-process touch() shows it to work fine. This excludes timestamp skew (checked by copying a failed changes file and trying again, on the same machine).
The log file is messed up, and there appears to be a failure to log an OOPS - but this is a recent change so not a root cause and possibly not even related.
Related branches
- Gavin Panella (community): Approve
- Jeroen T. Vermeulen: Pending requested
-
Diff: 317 lines (+96/-37)12 files modifiedcronscripts/supermirror-pull.py (+1/-1)
daemons/librarian.tac (+5/-1)
daemons/poppy-sftp.tac (+12/-3)
lib/lp/codehosting/puller/tests/test_acceptance.py (+5/-1)
lib/lp/poppy/twistedftp.py (+5/-0)
lib/lp/services/gpg/doc/gpg-signatures.txt (+46/-0)
lib/lp/services/gpg/handler.py (+6/-1)
lib/lp/services/mail/tests/test_incoming.py (+2/-1)
lib/lp/services/sshserver/service.py (+0/-1)
lib/lp/services/twistedsupport/loggingsupport.py (+8/-26)
scripts/code-import-worker-monitor.py (+5/-1)
versions.cfg (+1/-1)
- Julian Edwards (community): Approve
-
Diff: 44 lines (+9/-3)3 files modifiedlib/lp/poppy/tests/test_poppy.py (+3/-1)
lib/lp/poppy/tests/test_twistedftp.py (+3/-1)
lib/lp/poppy/twistedftp.py (+3/-1)
- Curtis Hovey (community): Approve (code)
-
Diff: 527 lines (+2/-374)10 files modifieddaemons/poppy-sftp.tac (+1/-16)
database/schema/security.cfg (+0/-6)
lib/lp/poppy/tests/test_poppy.py (+0/-36)
lib/lp/poppy/tests/test_twistedconfigreset.py (+0/-31)
lib/lp/poppy/tests/test_twistedftp.py (+0/-111)
lib/lp/poppy/twistedconfigreset.py (+0/-49)
lib/lp/poppy/twistedftp.py (+1/-60)
lib/lp/services/gpg/handler.py (+0/-14)
lib/lp/services/gpg/interfaces.py (+0/-10)
lib/lp/services/gpg/tests/test_gpghandler.py (+0/-41)
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Critical |
tags: | added: poppy regression |
tags: | added: canonical-losa-lp |
description: | updated |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
tags: |
added: qa-untestable removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
assignee: | Julian Edwards (julian-edwards) → William Grant (wgrant) |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Almost the same problem here, except it doesn't always process the upload. Seems random (Task Coach project).