Journal error - invalid parameter

[Craig Eves]

When selecting Journal the error
Mahara: Invalid Parameter
A required parameter is missing or malformed is displayed and a journal can't be created.

This is in version 1.4 with the following user http://myportfolio.school.nz/admin/users/edit.php?id=25748

This user accidentally deleted their existing journal and now can't create on.

Craig

[Hugh Davenport (hugh-davenport)]

That user doesn't appear to have a journal in the database, which would be the problem.

There should probably be a better error message for when this happens.

[Hugh Davenport (hugh-davenport)]

Ah, just read your comment, they deleted it (that would be why there isn't one there)

So we need to be able to make a user create a journal even if they don't have one, or stop them deleting the default one.

Cheers,

Hugh

[Hugh Davenport (hugh-davenport)]

Fixed their problem,

They had the multiple journals option unchecked in their settings. Enabling this allows you have zero journals.

There is a bug because you are not meant to be able to disable this setting if you have no journals (or more than one)

Would you be able to ask that user how they went about "accidentally deleting their existing journal", as there is likely to be a bug somewhere in how they did it that will need to be fixed.

Cheers,

Hugh

[François Marier (fmarier)]

In addition to fixing the underlying problem if we can identify it, it would be good to detect this and display an error message that points to the problem.

That way, next time it happens, we'll know exactly what to fix.

[Craig Eves (craig-flexible)]

The accidental deletion of blogss can happen using v 1.3 because there is no are you sure prompt when you select delete journal.

There is a prompt when dleeting a blog post bit not the blog itself, this is fixed in 1.4

Craig

[Hugh Davenport (hugh-davenport)]

Hi Craig,

So this bug would of happened since 1.3 time, and just migrated up?

In that case, this bug can be used to just give a better error message
to the user when this happens.

If they deleted the blog in 1.4, then we would need specifics on how
they went about deleting it, and whether any messages came up. As when I
have the multiple journals option unchecked, I can't see a delete
journal button.

Cheers,

Hugh

On 16/06/11 14:12, Craig Eves wrote:
> The accidental deletion of blogss can happen using v 1.3 because there
> is no are you sure prompt when you select delete journal.
>
> There is a prompt when dleeting a blog post bit not the blog itself,
> this is fixed in 1.4
>
> Craig
>

--
Hugh Davenport
803 2258
Developer
Catalyst Ltd.

[François Marier (fmarier)]

Let's just improve the error message in that case.

[Hugh Davenport (hugh-davenport)]

After a bit of testing, it seems there is a bug after all.

If you go directly to the /artefact/blog/ page when you don't have the
multiple journals option enabled, you can create and delete journals as
much as you want. This could leave you in a state where you don't have a
default journal :)

Cheers,

Hugh

--
Hugh Davenport
803 2258
Developer
Catalyst Ltd.

[Hugh Davenport (hugh-davenport)]

https://reviews.mahara.org/335

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/335
Committed: http://gitorious.org/mahara/mahara/commit/c84bed6c070ec4736bb4bef1add2e12e496ecd1b
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit c84bed6c070ec4736bb4bef1add2e12e496ecd1b
Author: Hugh Davenport <email address hidden>
Date: Thu Jun 16 15:23:47 2011 +1200

    Fix bug and give better error when multiplejournals

    Bug #795307

    When multiple journals option is disabled, you can still go to
    /artefact/blog and delete/create journals as if it was enabled

    Also, if there is no default journal, the error message wasn't
    helpful, and now says what the problem is and how the user can
    fix it.

    Change-Id: I3878f46e8479bc98f547381c285b4501085d501d
    Signed-off-by: Hugh Davenport <email address hidden>

[Donna Hrynkiw (donna-hrynkiw)]

FWIW.

We just upgraded our test site from v1.1.6 to v1.4 and my personal account experienced this problem. My co-worker did not -- which was reassuring.

My profile already had "Enable multiple journals" turned on. Turning that setting off and saving. Then turning it on again and saving solved the problem.

But yeah -- a more descriptive error message is needed.