[underthehood] the ListAggregatorModel class is not unit tested
Bug #794482 reported by
Olivier Tilloy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity-2d |
Fix Released
|
High
|
Olivier Tilloy | ||
unity-2d (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
It is a critical piece of code, it’s easy to get it wrong (I did in the past), and it’s not unit tested… We should fix that.
Related branches
lp:~osomon/unity-2d/listaggregatormodel-unittests
- Florian Boucault (community): Approve
-
Diff: 463 lines (+398/-2)5 files modified.bzrignore (+3/-0)
libunity-2d-private/Unity2d/listaggregatormodel.cpp (+10/-2)
libunity-2d-private/Unity2d/listaggregatormodel.h (+3/-0)
libunity-2d-private/tests/CMakeLists.txt (+1/-0)
libunity-2d-private/tests/listaggregatormodeltest.cpp (+381/-0)
Changed in unity-2d: | |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in unity-2d (Ubuntu): | |
status: | New → Confirmed |
Changed in unity-2d: | |
assignee: | nobody → Olivier Tilloy (osomon) |
status: | Confirmed → In Progress |
Changed in unity-2d: | |
milestone: | none → 3.10 |
Changed in unity-2d (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity-2d: | |
status: | In Progress → Fix Committed |
Changed in unity-2d (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity-2d: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package unity-2d - 3.8.10-0ubuntu1
---------------
unity-2d (3.8.10-0ubuntu1) oneiric; urgency=low
[ Florian Boucault ] unity-2d- launcher. install: launchermenu. css anylonger as its now shipped as 2d-private- qml.so using the Qt resource system libunity- 2d-private0: backgrounds/ warty-final- ubuntu. png from usr/share/ unity-2d/ places/ artwork to /usr/share/unity-2d
* debian/
- do not install launcher/
part as libunity-
* debian/
- move symbolic link to /usr/share/
/
* debian/control:
- add pkg-config as a build dependency
[ Didier Roche ] Renderer unity-2d. gconf-defaults, 20_ubuntu- 2d-gconf- default:
* New upstream release:
- FTBFS due to erroneous check on libwnck (LP: #800550)
- [dash] Search is slow and freezes (LP: #774569)
- Some community lenses do not display anything - UnityHorizontal
not implemented (LP: #790319)
- [underthehood] the ListAggregatorModel class is not unit tested
(LP: #794482)
- Missing a GConf schema file for the /desktop/unity-2d/… keys
(LP: #750303)
- [dash] home screen search hint should be 'Search' (LP: #797825)
* debian/
debian/
- transition some gconf keys from session-wide to system-wide
(LP: #797672, #797676)
* debian/control:
- ensure we are still using gtk2 indicator for alpha2 (LP: #804938)
- bump standards-version
-- Didier Roche <email address hidden> Mon, 04 Jul 2011 11:05:54 +0200