Advanced subscription overlay for direct subscriptions does not handle unsubscribing teams
Bug #761257 reported by
Brad Crittenden
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Данило Шеган |
Bug Description
The overlay has an option for unsubscribing a team but the logic does not support it. In fact, selecting an option like "Unsubscribe HWDB team" will actually unsubscribe the user, leaving the team subscribed.
Related branches
lp:~danilo/launchpad/bug-761257
- Brad Crittenden (community): Approve (code)
-
Diff: 167 lines (+86/-26)2 files modifiedlib/lp/bugs/javascript/bug_subscription.js (+10/-4)
lib/lp/bugs/javascript/bugtask_index_portlets.js (+76/-22)
summary: |
- Advanced subscription overlay does not handle unsubscribing teams + Advanced subscription overlay for direct subscriptions does not handle + unsubscribing teams |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | Launchpad Yellow Squad (yellow) → Данило Шеган (danilo) |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Ok, when working on this, I found out a gazillion of problems. I'll list those that I haven't fixed yet here just so I have them written down, and I'll be filing bugs as appropriate.
1. There is no 'mute' link if you are a member of a team that is subscribed to the bug notification- levels is conditional on your subscription being "muted" in bug_subscription.js and bug-subscription.pt when it shouldn't be, since we don't want to show levels for unsubscribing teams either; I might fix this in this branch subscription" as the value, which might just as well be a team/person name, and if such a person/team ever shows up, it's all going to break
2. Animation for show-bug-
3. There is no way to set a different bug notification level for team subscriptions
4. For the "update my subscription level" radio box we hard-code "update-
5. If at any one point you end up with no subscribers after you've unsubscribed everyone, "subscribing someone else" fails from then on; this is not a problem if you start with a bug with no subscribers, so the "None" text that is being added doesn't have the same properties as the one that's originally constructed on page load
6. There are no tests at all for this
I am fixing a few other problems except the one mentioned in this bug: animation was very jumpy if you click the same radio box twice, and when you had a bug muted, you couldn't really set the bug notification level when unmuting.