Clean up menus

[John Macdonald]

There are too many options the the right-click menus, and the options are not grouped logically in most cases. The language used can also be improved to be more user friendly:

All items that can be checked are checked.

Page right click menu:
  Back
  Forward
  Refresh (Stop when loading the page)
  ----------
  Add to Bookmarks
  Add to Speed Dial
  ----------
  Save Page As...
  Print...
  ----------
  Zoom In
  Zoom Out
  ----------
  Encoding >
  View Source
  Inspect Element
*Create Launcher does nothing, so removed
*Undo Close tab belongs in the tab right click menu
*Back, Forward, Refresh/Stop should be hidden if the navigation bar is shown (no one is going to always look for and move their mouse to
the little part of the page that is not content to go back and forward)
*Should zoom options even be shown? They are rarley used/needed, and can be accessed via the universal ctrl+scroll (discoverability doesn't really impact user experience here)

AppMenu:
  New Window
  New Private Browsing Window
  Open...
  ----------
  Print...
  Find in Page...
  ----------
✓ Sidepanel
  Configure Advertisment Filters...
  Clear Private Data...
  ----------
  Fullscreen
  ----------
  Frequent Questions
  About
  Preferences
*Export and Import bookmarks would be moved to the bookmarks sidepanel view
*"Find in Page" clarifies that it looks only in the page; it's not a search engine
*Customize Toolbar (really "Customize Navigation Bar") moved to the navigation bar right click menu where it makes sense

Navigation bar right click menu:
✓ Menu Bar
✓ Navigation Bar
✓ Status Bar
✓ Bookmarks Bar
  ----------
  Customize Navigation Bar...
*Bar names are separated into <name> <bar> instead of <namebar> because it is eaiser to find the bar you are looking for by only looking at the first word in each entry
*"Bookmarks bar" makes more sense than "Bookmark bar" (you probably have more than one bookmark)

Boookmarks bar right click menu:
✓ Menu Bar
✓ Navigation Bar
✓ Status Bar
✓ Bookmarks Bar
  ----------
  Manage Bookmarks...
*We have space, why not add an option for managing bookmarks here?

Tab Bar blank space right click menu:
✓ Menu Bar
✓ Navigation Bar
✓ Status Bar
✓ Bookmarks Bar
  ----------
  New Tab
  Undo Close Tab
  Open Tabs: (greyed out, because it can't be clicked)
    <currently open tab 1>
    <currently open tab 2>
    <currently open tab 3>
*You can hide toolbars from the tab bar right click menu because it a) makes sense and b) is the proper place to put the option for unhiding the navigation bar when it's hidden (previously it was in the page right click menu, see bug 743283)
*"Open Tabs:" is added to clarify what the list of tabs in the menu is
*"Open" makes no sense and does nothing, removed

Right click on a tab:
  Open in New Window
  Duplicate Tab
  Only Show Tab Icon
  View as Web App
  ----------
  Close Other Tabs
  Close
*The viewing of a page as a web application has been removed from the link right click menu and put where it makes sense and is readily avaliable
*No checkmarks for "Only Show Tab Icon" to aviod ambigous toggled menu items (see http://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html#//apple_ref/doc/uid/TP30000356-TPXREF121)

Right click on an image:
  Save Image As...
  Copy Image
  Copy Image Address
  Open Image in New Tab
  Block Image
  ----------
  Inspect Element

Right click on a link:
  Open Link in New Tab
  Open Link in New Window
  Copy Link
  Save Link As...
  ----------
  Inspect Element
*Downloading a web page in the default dowload manager is useless; the transfers panel is good enough
*"Copy Link" is more understandable language (previously it was "Copy Link location")

[donald iljazi (1lj4z1-deactivatedaccount-deactivatedaccount-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

i agree, it should be more minimal.

[Cris Dywan (kalikiana)]

That statement is as useful as saying "please read my mind".

[John Macdonald (jxtreme42)]

Added the specific menu items.

[John Macdonald (jxtreme42)]

Added a very in-depth review of Midori's menus.

[Danielle Foré (danrabbit)]

I don't think zoom in and out belong in the AppMenu. These are contextual actions based on the current tab, not the application. So the context menu of that view is where they should live.

Having said that, I more or less agree with most of your suggestions. I'm especially keen on the string changes from "Private Browsing" to "New Private Browsing Window", "Find In Page...", proper use of elipses etc. Nice work.

[Danielle Foré (danrabbit)]

As a hint, Christian will probably be more keen on merging these changes if you provide him with a branch merge proposal or a patch ;)

[John Macdonald (jxtreme42)]

I totally agree with you on the zoom in/out. And I'll try to patch this (i'm not much of a coder, but renaming/removing/moving things sounds doable).

[Danielle Foré (danrabbit)]

Make sure you're working from git, there have been some changes to menus recently. And good luck! :D

[Cris Dywan (kalikiana)]

I can tell you one thing, and I don't mean to be unfriendly, doing all menus at once is very tedious for me and I am not going to iterate all menus multiple times while posing questions about some of them. Just this once I will do that, after that please suggest individual suggestions in comments or, even better, file separate bug reports.

By the way you are welcome to join #midori on irc.freenode.net to sort out some of these questions.

> New Private Browsing Window

Didn't we just recently move this to be together with Clear Private Data?

> Find in Page...

Does an inline bar warrant ... used for new windows?

> ✓ Sidepanel
>   Configure Advertisment Filters...
>   Clear Private Data...
>   ----------
>   Fullscreen

‘Advertisement Filters’ may be moving into the preferences dialogue, and
‘Customise Toolbar’ will also move I think. That means those menus are fairly
empty by default.

I'm not sure about many pairs or even single items surrounded by separators. If a third of the whole menu is separators it defeats the point of cleaning up.

You are missing ‘Report a Problem...’ at the bottom.

> *Bar names are separated into <name> <bar> instead of <namebar>

No strong opinion on this.

> *"Bookmarks bar" makes more sense than "Bookmark bar"

But you don't say Tools Bar or Menus Bar, do you?

>   Manage Bookmarks...
> *We have space, why not add an option for managing bookmarks here?

What should this do?

> *"Open" makes no sense and does nothing, removed

It does work, but I agree on removing it. I will in fact do this right now.

> Right click on a tab:
> *No checkmarks for "Only Show Tab Icon" to aviod ambigous toggled menu

There are no checkmarks, it changes label to "Show Tab Label".

What about ‘New Tab’? I think being able to open a tab from there is useful, in
particular if you hide the toolbar.

> Right click on an image:
> Copy Image

We don't have that feature. Feel free to open a feature request.

> Tab Bar blank space right click menu:
> ✓ Menu Bar

I guess it makes sense. But it will make the menu much larger by default because,
unlike Firefox or Chromium, Midori shows the open tabs in there.

> Open Tabs: (greyed out, because it can't be clicked)

No strong opinion, if you find it useful let's have it.

> *The viewing of a page as a web application has been removed from the
> link right click menu and put where it makes sense and is readily avaliable

Not so sure about that one, I actually use that on a regular basis and I don't
see why I would want to load the page twice. It may be useful here to talk a bit
about how you/ we see typical use cases of "web apps" beforehand.

> *Downloading a web page in the default dowload manager is useless; the transfers panel is good enough

This was removed recently. Not because it's useless, but because usability-wise it was poor.

> *"Copy Link" is more understandable language (previously it was "Copy Link location")

There was a change from ‘Save Link Destination‘ to ‘Save As‘ in the past. I can't say if "Destination" is hard to understand, but it is most likely redundant/ obvious.

I think you really should get git master going since you apparently didn't see a few changes that al...

[Danielle Foré (danrabbit)]

Christian, I just started working on a section of the HIG outlining the use of ellipses (...) http://webdev.elementaryos.org/wiki/human-interface-guidelines/text#using-ellipsis

Having your feedback would probably be good and could also help sort out where it's appropriate to use here :)

[Cris Dywan (kalikiana)]

Private Browsing → New Private Browsing Window

Save As → Save Page As...

Find → Find...

[gue5t gue5t (gue5t)]

With respect to the right-click menus, it would be nice if something along the lines described above were implemented for stop/refresh. Currently, the right-click contains both options but only one is ever enabled at once, and if the page is loading when right-click opens the menu, then Stop will be sensitive and Refresh will be insensitive until the menu closes regardless of whether the page finishes loading.

This is essentially the worst of both possible worlds; only including one or the other of Stop and Refresh in the menu would at least eliminate one insensitive option from the menu consistently. Even better would be to add the appropriate one of the pair and switch it for the other if page load state changes while the menu is open. But that's relatively complex and I don't know how easily/reliably/cleanly it can be done.

[Danielle Foré (danrabbit)]

I've moved this to a blueprint where we can track each change as a separate bug report and discuss the changes more granularly: https://blueprints.launchpad.net/midori/+spec/cleaner-menus

As such, I'm going to mark this meta-bug report as being an invalid report.