Ambiance/Radiance should use chromium specific theming controls
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
light-themes |
Fix Released
|
Wishlist
|
Andrea Cimitan | ||
light-themes (Ubuntu) |
Fix Released
|
Low
|
Andrea Cimitan |
Bug Description
Binary package hint: light-themes
(Context: I'm the author of the Google Chrome GTK+ integration code.)
(Related fixed xubuntu bug: https:/
The current interaction between Ambiance and both Chrome 8 and 9 results in a bright orange frame. There appear to be some changes in Ambiance between Lucid and Maverick (our previous autoselected gray wasn't optimal, but wasn't so...bright).
Since (at least as an outsider looking in) CSD doesn't appear like it's going to occur, we've added some explicit nobs for GTK+ authors to fiddle with to force the non-GTK+ parts of the Chrome interface. The new theming controls for Chrome 9 and forward are documented at: http://
This is obviously a low priority, but it'd be a nice to have before Natty is shipped.
Here is an example for Ambiance based on me naively picking colors from screenshots taken with the gimp. Your art team will probably be displeased with it and want to fine tune it. These individual style properties are documented in the link above. It is only meant as an example of what can be done. To try this out, please install either Google Chrome/Chromium 9.0.597 or newer:
style "chrome-gtk-frame"
{
ChromeGtkFr
ChromeGtkFr
ChromeGtkFr
ChromeGtkFr
ChromeGtkFr
ChromeGtkFr
ChromeGtkFr
}
class "ChromeGtkFrame" style "chrome-gtk-frame"
Related branches
- James Schriver: Approve
-
Diff: 61 lines (+42/-0)2 files modifiedAmbiance/gtk-2.0/apps/chromium.rc (+21/-0)
Radiance/gtk-2.0/apps/chromium.rc (+21/-0)
- Paul Sladen: Pending requested
-
Diff: 229 lines (+71/-32)5 files modifiedAmbiance/gtk-2.0/apps/chromium.rc (+1/-1)
Ambiance/metacity-1/metacity-theme-1.xml (+4/-4)
Radiance/gtk-2.0/apps/chromium.rc (+2/-2)
Radiance/metacity-1/metacity-theme-1.xml (+51/-25)
debian/changelog (+13/-0)
Changed in light-themes (Ubuntu): | |
assignee: | nobody → Andrea Cimitan (cimi) |
Changed in light-themes: | |
status: | New → In Progress |
assignee: | nobody → Andrea Cimitan (cimi) |
importance: | Undecided → Wishlist |
Changed in light-themes (Ubuntu): | |
milestone: | ubuntu-11.04-beta-1 → ubuntu-11.04-beta-2 |
Changed in light-themes: | |
status: | Fix Committed → Fix Released |
Thanks for reporting this bug and any supporting documentation. Since this bug has enough information provided for a developer to begin work, I'm going to mark it as confirmed and let them handle it from here. Thanks for taking the time to make Ubuntu better!