Hide Junk messages in Search folders

Bug #665330 reported by Brian J. Murrell
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evolution
Fix Released
Medium
evolution (Ubuntu)
Fix Released
Low
Mathieu Trudel-Lapierre
Maverick
Fix Released
Low
Unassigned

Bug Description

Binary package hint: evolution

SRU JUSTIFICATION:
A minimal patch that hides messages marked as Junk if and only if the current folder to display is a virtual, search folder. Standard folders such as pure IMAP folders will still show the message. Furthermore, there is a "Junk" folder which already groups messages marked as Junk, so the risk to actually lose a message is minimal.

Additionally, this appears to be a regression from Lucid, where Junk messages would not be shown in Search Folders.

TEST CASE:
1) Create a search folder that lists a number of messages from one or various sources (mail folders)
2) From the search folder, mark a message from the list as Junk.
3) Navigate to the Junk folder, make sure the marked message is listed.
4) Navigate back to the search folder; make sure the message is not visible.
5) (optional) mark the message back as Not Junk

I case of failure, the message will not be visible in the Junk folder. For a failed test case, the message could also still be visible in the new search folder.
For a successful test case, the message marked as Junk will no longer be listed in the Search folder, but will be visible in the Junk folder.

---

The upstream bug 617953 has a patch which prevents junk messages from being visible in search folders. I will attach a backport of that patch for Ubuntu's 2.30.3 evolution.

Revision history for this message
Brian J. Murrell (brian-interlinx) wrote :

Backport upstream patch.

To test, create a search folder and either populate the underlying physical folder with spam or wait for some to be populated. Exit evolution and then restart it. Without the patch you should see the spam even though it's been marked as junk. With the patch, junk stays hidden from the search folder the same way it does for the physical folder.

Changed in evolution:
importance: Unknown → Medium
status: Unknown → Fix Released
Revision history for this message
Pedro Villavicencio (pedro) wrote :

Didier may you have a look to the patch? Thanks.

Changed in evolution (Ubuntu):
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Didier Roche (didrocks)
tags: added: patch
Revision history for this message
Brian J. Murrell (brian-interlinx) wrote :

Will this be making it into an updated evolution package for Maverick any time soon?

Changed in evolution (Ubuntu):
assignee: Didier Roche (didrocks) → Mathieu Trudel-Lapierre (mathieu-tl)
description: updated
description: updated
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

The attached debdiff applies the patch and appears to fix the problem.

This also applies the fix for bug 664169.

Revision history for this message
Brian J. Murrell (brian-interlinx) wrote :

Great. So will this go into a new release for evolution for Maverick or has interest in maintaining evolution in Maverick waned?

Revision history for this message
Sebastien Bacher (seb128) wrote :

the issue is fixed in the current version

Changed in evolution (Ubuntu):
status: Triaged → Fix Released
Changed in evolution (Ubuntu Maverick):
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

sru sponsorized now

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted evolution into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package evolution - 2.30.3-1ubuntu7.2

---------------
evolution (2.30.3-1ubuntu7.2) maverick-proposed; urgency=low

  * debian/patches/93_git_hide_junk_messages_in_search_folders.patch:
    - do not show Junk messages in Search folders (LP: #665330)
  * debian/patches/93_git_use_proxy_cred_for_images.patch:
    - use proxy credentials when loading images from the web (LP: #664169)
 -- Mathieu Trudel-Lapierre <email address hidden> Tue, 23 Nov 2010 11:55:35 -0500

Changed in evolution (Ubuntu Maverick):
status: Fix Committed → Fix Released
Revision history for this message
Brian J. Murrell (brian-interlinx) wrote : Re: [Bug 665330] Re: Hide Junk messages in Search folders

On Mon, 2011-01-03 at 09:02 +0000, Launchpad Bug Tracker wrote:
> This bug was fixed in the package evolution - 2.30.3-1ubuntu7.2

Great!

> ---------------
> evolution (2.30.3-1ubuntu7.2) maverick-proposed; urgency=low
>
> * debian/patches/93_git_hide_junk_messages_in_search_folders.patch:
> - do not show Junk messages in Search folders (LP: #665330)
> * debian/patches/93_git_use_proxy_cred_for_images.patch:
> - use proxy credentials when loading images from the web (LP: #664169)
> -- Mathieu Trudel-Lapierre <email address hidden> Tue, 23 Nov 2010 11:55:35 -0500

Will these changes ever get migrated/merged back to the maverick
evolution bzr repo or will they forever only live in the
maverick-proposed repo?

tags: added: testcase
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.