'Edit' & 'Delete' button on taskslist.tpl needs to be translatable.

Bug #617953 reported by Mitsuhiro Yoshida
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Dan Poltawski

Bug Description

'Edit' & 'Delete' button on artefact/plans/theme/raw/taskslist.tpl needs to be translatable as below.

--- [ before ] ---
{auto_escape on}
{foreach from=$tasks.data item=task}
    {if $task->completed == -1}
        <tr class="incomplete">
            <td class="c1">{$task->completiondate}</td>
            <td class="c2">{$task->title}</td>
            <td class="c3">{$task->description}</td>
            <td class="c4">&nbsp;</td>
            <td class="c5"><a href="{$WWWROOT}artefact/plans/edit/task.php?id={$task->task}">Edit</a></td>
            <td class="c6"><a href="{$WWWROOT}artefact/plans/delete/task.php?id={$task->task}">Delete</a></td>
        </tr>
    {else}
        <tr class="{cycle values='r0,r1'}">
            <td class="c1">{$task->completiondate}</td>
            <td class="c2">{$task->title}</td>
            <td class="c3">{$task->description}</td>
            {if $task->completed == 1}
                <td class="c4"><div class="completed"><img src="{$WWWROOT}theme/raw/static/images/success.gif" alt="" /></div></td>
            {else}
                <td class="c4">&nbsp;</td>
            {/if}
            <td class="c5"><a href="{$WWWROOT}artefact/plans/edit/task.php?id={$task->task}">Edit</a></td>
            <td class="c6"><a href="{$WWWROOT}artefact/plans/delete/task.php?id={$task->task}">Delete</a></td>
        </tr>
    {/if}
{/foreach}
{/auto_escape}

--- [ after ] ---
{auto_escape on}
{foreach from=$tasks.data item=task}
    {if $task->completed == -1}
        <tr class="incomplete">
            <td class="c1">{$task->completiondate}</td>
            <td class="c2">{$task->title}</td>
            <td class="c3">{$task->description}</td>
            <td class="c4">&nbsp;</td>
            <td class="c5"><a href="{$WWWROOT}artefact/plans/edit/task.php?id={$task->task}"><?php echo get_string('edit'); ?></a></td>
            <td class="c6"><a href="{$WWWROOT}artefact/plans/delete/task.php?id={$task->task}"><?php echo get_string('delete'); ?></a></td>
        </tr>
    {else}
        <tr class="{cycle values='r0,r1'}">
            <td class="c1">{$task->completiondate}</td>
            <td class="c2">{$task->title}</td>
            <td class="c3">{$task->description}</td>
            {if $task->completed == 1}
                <td class="c4"><div class="completed"><img src="{$WWWROOT}theme/raw/static/images/success.gif" alt="" /></div></td>
            {else}
                <td class="c4">&nbsp;</td>
            {/if}
            <td class="c5"><a href="{$WWWROOT}artefact/plans/edit/task.php?id={$task->task}"><?php echo get_string('edit'); ?></a></td>
            <td class="c6"><a href="{$WWWROOT}artefact/plans/delete/task.php?id={$task->task}"><?php echo get_string('delete'); ?></a></td>
        </tr>
    {/if}
{/foreach}
{/auto_escape}

Revision history for this message
Mitsuhiro Yoshida (mits) wrote :
Changed in mahara:
assignee: nobody → Dan Poltawski (dan-poltawski)
Revision history for this message
Dan Poltawski (dan-poltawski) wrote :

Thanks Mitsuhiro - i've committed a fix (using the {str} templating mechanism rather than get_string)

Changed in mahara:
status: New → Fix Committed
importance: Undecided → Low
importance: Low → Medium
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.