byobu

byobu-launcher-install doesn't create the directory it needs

Bug #580384 reported by Mark Schouten on 2010-05-14

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
byobu	Fix Released	Low	Dustin Kirkland 
byobu (Ubuntu)	Fix Released	Low	Unassigned
Lucid	Fix Released	Low	Dustin Kirkland 	Ubuntu lucid-updates

Bug Description

When running byobu-launcher-install on a new machine (which hasn't run byobu yet), it fails with the following message:
root@host01:~# byobu-launcher-install
touch: cannot touch `/root/.byobu/disable-autolaunch': No such file or directory

If you start buyobu first, quit and than run byobu-launcher-install, it works fine.

The issue seems to be in byobu-launcher-uninstall. Please find patch attached.

====
SRU
* IMPACT: affects users who run byobu-launcher-install before ever having run byobu (mostly affects ubuntu vm appliance makers)
* HOW FIXED: this is trivially fixed with a very safe mkdir -p
* TEST CASE: install byobu; make sure that ~/.byobu does not exist; try running byobu-launcher-install; boom; install new package, try same thing, works better
* REGRESSION POTENTIAL: none
===

See original description

Tags:

Related branches

lp:byobu

lp:ubuntu/maverick/byobu

lp:ubuntu/lucid-proposed/byobu

Revision history for this message

Mark Schouten (mark-prevented) wrote on 2010-05-14:

Patch to check if the dir we try to touch a file in actually exists Edit (436 bytes, text/plain)

Dustin Kirkland  (kirkland) on 2010-05-15

Changed in byobu:
status:	New → Fix Committed
importance:	Undecided → Low
assignee:	nobody → Dustin Kirkland (kirkland)
Changed in byobu (Ubuntu):
status:	New → Fix Committed
importance:	Undecided → Low

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-05-15:

This bug was fixed in the package byobu - 2.75-0ubuntu1

---------------
byobu (2.75-0ubuntu1) maverick; urgency=low

  * usr/bin/byobu: ensure that .screenrc gets sourced if byobu is run
    with arguments, LP: #580760
  * ec2_cost, ip_address, network, rcs_cost: fix bug when calling ifconfig
    without setting lang to english, LP: #578792
  * byobu-launcher-uninstall: create the directory, in case this script is
    executed before byobu actually runs, LP: #580384
  * usr/bin/byobu-launcher: allow user to add custom screen arguments to
    byobu-launcher (useful in .profile for adding an option like -UDR),
    LP: #578373
-- Dustin Kirkland <email address hidden> Sat, 15 May 2010 15:32:30 -0400

Changed in byobu (Ubuntu):
status:	Fix Committed → Fix Released

Dustin Kirkland  (kirkland) on 2010-05-21

Changed in byobu:
status:	Fix Committed → Fix Released

Dustin Kirkland  (kirkland) on 2010-06-13

Changed in byobu (Ubuntu Lucid):
status:	New → In Progress
importance:	Undecided → Low
assignee:	nobody → Dustin Kirkland (kirkland)
milestone:	none → lucid-updates

Revision history for this message

Dustin Kirkland  (kirkland) wrote on 2010-06-13:

out Edit (1.8 KiB, text/plain)

SRU patch attached.

description:

updated

Dustin Kirkland  (kirkland) on 2010-06-13

Changed in byobu (Ubuntu Lucid):
status:	In Progress → Fix Committed

Revision history for this message

Colin Watson (cjwatson) wrote on 2010-06-16: Please test proposed package

Accepted into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags:

added: verification-needed

Revision history for this message

Alon Swartz (alonswartz) wrote on 2010-06-16:

Fix confirmed to work (from lucid-proposed).
Tested on: turnkey-core-beta (based on Lucid Lynx).

Martin Pitt (pitti) on 2010-06-16

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-06-24:

This bug was fixed in the package byobu - 2.68-0ubuntu1.1

---------------
byobu (2.68-0ubuntu1.1) lucid-proposed; urgency=low

  * usr/bin/byobu-launch, usr/bin/byobu-launcher-install: exit 0 after
    launching byobu to prevent the user from having to do the double-exit
    when exiting or detaching, LP: #568306
  * byobu-launcher-uninstall: create the directory, in case this script is
    executed before byobu actually runs, LP: #580384
-- Dustin Kirkland <email address hidden> Sun, 13 Jun 2010 11:59:44 -0500