empire confuses users: sawmill employs toolsmith

[Sigra]

The empire tribe confuses the users; the samill employs a toolsmith and the toolsmith is created from a saw.

[Nasenbaer (nasenbaer)]

This is actually easy to fix, BUT will break savegame compatibility, as long as we do not change the loading code in some places. (including the send out / conversation of the toolsmiths occupying sawmills in build13 savegames)

[SirVer (sirver)]

I target this for build16-rc1 because we will break savegame compatibility there to get rid of old attic.

[SirVer (sirver)]

now what about this bug? It is the time to fix this, but what is the proposed or correct fix?

[Nasenbaer (nasenbaer)]

well I think we should create a new worker "sawyer" and use that one in the sawmill.
However as far as I understood the discussion on the mailinglist, the idea is, to *not* break any none scenario games - so there should be a hardcoded switch in the savegame loading code that replaces the string "toolsmith" for empire sawmills with "sawyer".

Any arguments against this?

[Nasenbaer (nasenbaer)]

set to opinion to finally get to a point where this can be marked as "fixed" or "won't fix" ;)

[SirVer (sirver)]

I fixed this in r5655: I copied the toolsmith to a new worker called carpenter and changed the sawmill to require this new worker.

Chuck, I assign you this as we need new graphics for this worker (as I just copied him from the toolsmith). If you feel not like doing this for build 16, just retarget this bug.

[Nasenbaer (nasenbaer)]

this was fixed by Chuck in rev 5678
(no I did not just push the buttons side by side it really is 5678 ;) )

[SirVer (sirver)]

Released in build16-rc1