gupnp-igd ftbfs on all archs in lucid

[Alexander Sack]

like https://edge.launchpad.net/~asac/+archive/armel1/+build/1544328

[Laurent Bigonville (bigon)]

0.1.6-1 is required with last version of gupnp

[Steve Langasek (vorlon)]

Upstream commit d5dd3215559642ee6e19c6362e72f35c5c2d4b6e fixes the failure to build the test suite. However, *running* the test suite appears to still fail even in the latest upstream version because it depends on having the dbus system bus available at build time.

Laurent, what in 0.1.6 is required for compatibility with gupnp aside from this testsuite fix? If this is required, then we would need an FFe for a merge since the new package has a changed soname and introduces new python bindings.

[Steve Langasek (vorlon)]

With 0.1.6, enabling the test suite fails with:

/usr/bin/make check-TESTS
make[4]: Entering directory `/home/devel/canonical/lucid/gupnp-igd-0.1.6/tests/gtest'
/simpleigd/new:
** WARNING **: Failed to connect to System Bus: Failed to connect to socket /var/run/dbus/system_bus_socket: No such file or directory
aborting...
/bin/bash: line 4: 17483 Trace/breakpoint trap XML_PATH=. G_SLICE=debug-blocks LD_LIBRARY_PATH=../../libgupnp-igd/.libs ${dir}$tst
FAIL: gupnp-simple-igd
======================================
1 of 1 test failed
Please report to http://www.gupnp.org/
======================================
make[4]: *** [check-TESTS] Error 1

[Laurent Bigonville (bigon)]

Could be related to http://bugzilla.openedhand.com/show_bug.cgi?id=1979

[Martin Pitt (pitti)]

Before I even get to the D-Bus failure I now get yet another failure:

make[3]: Betrete Verzeichnis '/home/martin/upstream/gupnp-igd/tests/gtest'
/simpleigd/new:
GLib-GObject-WARNING **: IA__g_object_set_valist: construct property "main-context" for object `GUPnPSimpleIgdThread' can't be set after construction
aborting...

I confirmed this failure on current upstream git head.

I'll investigate that first.

[Martin Pitt (pitti)]

So for the previous failure, the GUPnPSimpleIgdThreadClass wrapper's _init() function apparently tries to set the context for the wrapped GUPnPSimpleIgdThread:

  g_object_set (self, "main-context", self->priv->context, NULL);

However, GUPnPSimpleIgdThread's property is declared as G_PARAM_CONSTRUCT_ONLY, thus you can't set it from outside.

I replaced G_PARAM_CONSTRUCT_ONLY with G_PARAM_CONSTRUCT, which fixes above problem, but is that actually the correct solution?

Also, this now fails later on in a different test:

/simpleigd/new: OK
/simpleigd/default_ctx: OK
/simpleigd/custom_ctx: OK
/simpleigd/thread: OK
/simpleigd/random/no_conflict: OK
/simpleigd/random/conflict: OK
/simpleigd/dispose_removes/regular: OK
/simpleigd/dispose_removes/thread: OK
/simpleigd/invalid_ip: OK
/simpleigd/empty_ip:
GLib-GObject-WARNING **: invalid uninstantiatable type `(null)' in cast to `GUPnPContextManager'
aborting...
/bin/bash: Zeile 5: 10679 Trace/breakpoint trap (Speicherabzug geschrieben) XML_PATH=. G_SLICE=debug-blocks LD_LIBRARY_PATH=../../libgupnp-igd/.libs ${dir}$tst
FAIL: gupnp-simple-igd

but this seems unrelated.

[Martin Pitt (pitti)]

Ah, the empty_ip failure only affects git head, not our version in lucid.

[Martin Pitt (pitti)]

I filed the main-context property bug upstream: http://bugzilla.openedhand.com/show_bug.cgi?id=2031

[Martin Pitt (pitti)]

I can replicate the D-Bus failure locally with sudo chmod 600 /var/run/dbus/system_bus_socket. This needs to be fixed in gupnp itself, adding task.

[Martin Pitt (pitti)]

gupnp uploaded with the D-Bus warning fix.

[Martin Pitt (pitti)]

gupnp-igd fix uploaded.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gupnp-igd - 0.1.3-4ubuntu1

---------------
gupnp-igd (0.1.3-4ubuntu1) lucid; urgency=low

  [ Steve Langasek ]
  * Merge from Debian testing, remaining changes:
    - debian/rules: Enable test suite on build.
  * 0001-Use-new-api-to-create-a-root-device-if-possible.patch: cherry pick
    from upstream to fix FTBFS with gupnp 0.13. LP: #534311.

  [ Martin Pitt ]
  * Add 0001-Fix-GUPnPSimpleIgd-main-context-property-declaration.patch:
    Fix GUPnPSimpleIgd main-context property declaration. This fixes the tests
    to not break on the "construct property can't be set after construction"
    warning.
  * debian/control: Bump libgupnp-1.0-dev build dependency to 0.13.2-1ubuntu1.
    This version downgrades the D-BUS connection failure warning which caused
    our test suite to fail on the buildds (where no system D-BUS is running).
    (LP: #534311)

gupnp-igd (0.1.3-4) unstable; urgency=low

  * Build depends on automake1.11 (Closes: #550427)
  * Bump Standards-Version (no further changes)

gupnp-igd (0.1.3-3) unstable; urgency=low

  * debian/watch: Fix URL path
  * debian/control:
    - Fix spelling in description
    - Build-depends on automake instead of automake1.10 (Closes: #541529)

gupnp-igd (0.1.3-2) unstable; urgency=low

  * Add libgupnp-1.0-dev and libglib2.0-dev dependencies for
    libgupnp-igd-1.0-dev package

gupnp-igd (0.1.3-1) unstable; urgency=low

  * Initial release (Closes: #533542)
 -- Martin Pitt <email address hidden> Mon, 15 Mar 2010 11:50:27 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package gupnp - 0.13.2-1ubuntu1

---------------
gupnp (0.13.2-1ubuntu1) lucid; urgency=low

  * Add dbus-fail-warning.patch: Downgrade D-Bus connection failure warning.
    It's not fatal for the context of libgupnp, and it causes the test suite
    of gupnp-igd to fail. (LP: #534311)
 -- Martin Pitt <email address hidden> Mon, 15 Mar 2010 11:46:54 +0100