ambiance panel buttons do not have contrast

Bug #533081 reported by xl_cheese
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
light-themes (Ubuntu)
Fix Released
Undecided
James Schriver

Bug Description

Binary package hint: light-themes

In the dark ambiance theme the panel buttons are black while their borders are black.

Try something like this in the gtkrc

style "murrine-panelbuttons" = "panel"
{
 bg[NORMAL] = shade (0.18, @bg_color) # "#f6f4f1"
 bg[PRELIGHT] = shade (0.26, @bg_color)
 bg[ACTIVE] = shade (0.40, @selected_bg_color)
 bg[SELECTED] = shade (0.70, @selected_bg_color)
 engine "murrine" {

  contrast = 0.4 # 0.8 for less contrast, more than 1.0 for more contrast on borders
  glazestyle = 0 # 0 = flat highlight, 1 = curved highlight, 2 = concave style, 3 = top curved highlight, 4 = beryl highlight
                glow_shade = 1.3
  glowstyle = 4 # 0 = top, 1 = bottom, 2 = top and bottom, 3 = horizontal, 4 = centered glow
  gradient_shades = {1.1,0.8,1.0,0.9}
  highlight_shade = 1.6

 }

}

widget_class "PanelToplevel.*<GtkButton>*" style "murrine-panelbuttons"
class "PanelToplevel.*<GtkButton>*" style "murrine-panelbuttons"
widget "*PanelApplet*" style "murrine-panelbuttons"

Revision history for this message
Chris Johnston (cjohnston) wrote :

Please provide a screenshot of what buttons you are referring to.

Changed in light-themes (Ubuntu):
status: New → Incomplete
Revision history for this message
xl_cheese (xl-cheese) wrote :

Here's a screenshot of what I'm referring to. the gtk stuff I post may still need some fine tuning, but the the idea is that for dark buttons they need a lighter outline rather than a darker one. It makes them stand out better.

Revision history for this message
xl_cheese (xl-cheese) wrote :

this is a bit better.

style "murrine-panelbuttons" = "panel"
{
 bg[NORMAL] = shade (0.18, @bg_color) # "#f6f4f1"
 bg[PRELIGHT] = shade (0.26, @bg_color)
 bg[ACTIVE] = shade (0.40, @selected_bg_color)
 bg[SELECTED] = shade (0.70, @selected_bg_color)
 engine "murrine" {

  contrast = 7.8 # 0.8 for less contrast, more than 1.0 for more contrast on borders
  glazestyle = 3 # 0 = flat highlight, 1 = curved highlight, 2 = concave style, 3 = top curved highlight, 4 = beryl highlight
                glow_shade = 1.3
  glowstyle = 4 # 0 = top, 1 = bottom, 2 = top and bottom, 3 = horizontal, 4 = centered glow
  gradient_shades = {0.5,0.6,0.2,0.7}
  highlight_shade = 1.5

 }

}

widget_class "PanelToplevel.*<GtkButton>*" style "murrine-panelbuttons"
class "PanelToplevel.*<GtkButton>*" style "murrine-panelbuttons"
widget "*PanelApplet*" style "murrine-panelbuttons"

Changed in light-themes (Ubuntu):
status: Incomplete → New
Revision history for this message
James Schriver (dashua) wrote :

Fix in my junk branch. This can be accomplished with border_shades and border_colors. Please test and report back.

Changed in light-themes (Ubuntu):
assignee: nobody → James Schriver (dashua)
status: New → Fix Committed
Revision history for this message
xl_cheese (xl-cheese) wrote :

See attached screenshot for a close up of what I'm thinking.

Note the "help" button pictured. There's a dark 1px border surrounding the entire button. Then there is a lighter 1px border giving the button the appearance of having thickness. Then inside that is the gradient fill.

The dark panel buttons aren't the same.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package light-themes - 0.1.5.6

---------------
light-themes (0.1.5.6) lucid; urgency=low

  * Bringing things back inline with the original design

light-themes (0.1.5.5) lucid; urgency=low

  [ James Schriver ]
  * Ambiance/Radiance: Deprecate pixmap scrollbars now drawn via the murrine engine
   - Visual refresh of buttons, notebook, comboboxentry for theme consistency
   - Add border_shade and colors
   - Add additional murrine options through_shades, shadow_shades, etc.
   - Sync scale with visual scrollbar changes for theme consistency
   - Fix blurry BG[INSENSITIVE] text/menubar text
   - Fix GtkScrollbar::min-slider-length = 36 (LP: #533537).
   - Adjust global border_shades for consistent shading with combobox
  * Ambiance: Fix text on memenu (LP: #532843).
   - Clean up panel; Fix (LP: #533081) panel buttons with no contrast
   - Fix statusbar (LP: #532964).
   - Fix dark text CPU applet on panel (LP: #532385).
   - Fix system monitor artifacts (LP: #533271).
   - Fix Gedit and Gimp menu separators (LP: #532323).
  * Radiance: Fix indistinguishable notebook tabs (LP: #532340).
   - Fix statusbar (LP: #532693).
  * Ambiance/Radiance: Fix metacity frame_style_maximized close and minimize unfocused prelight (LP: #532690).

  [ Kenneth Wimer ]
  * Ambiance/Radiance: set trough border only under scrollbar
  * Ambiance/Radiance: set automnemonics to 1 (lp: #532927)
  * Setting focus_color
 -- Kenneth Wimer <email address hidden> Tue, 09 Mar 2010 11:42:16 +0000

Changed in light-themes (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.