Help /About crashes

[David Roberts]

Bzr-Explorer [1.0.0.rc.0] rev:428

(proposed fix is available - see end of report)

From Explorer main window -> HELP -> ABOUT

Generates this error:

bzr: ERROR: exceptions.ValueError: version_info (1, 0, 0, 'rc', 0) not valid

Traceback (most recent call last):
  File "C:/localapp/Program Files/Bazaar/plugins\explorer\lib\explorer.py", line 1847, in do_about
  File "bzrlib\__init__.pyo", line 107, in _format_version_tuple
ValueError: version_info (1, 0, 0, 'rc', 0) not valid

bzr 2.1.0rc1 on python 2.5.4 (win32)
arguments: ['C:\\localapp\\Program Files\\Bazaar\\bzr.exe', 'explorer']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\localapp\Program Files\Bazaar\plugins\bzrtools [2.1.0b1]
  colo C:\localapp\Program Files\Bazaar\plugins\colo [0.0.2dev]
  depend C:\localapp\Program Files\Bazaar\plugins\depend [unknown]
  explorer C:\localapp\Program Files\Bazaar\plugins\explorer [1.0.0.rc.0]
  extmerge C:\localapp\Program Files\Bazaar\plugins\extmerge [unknown]
  grep C:\localapp\Program Files\Bazaar\plugins\grep [unknown]
  launchpad C:\localapp\Program Files\Bazaar\plugins\launchpad [2.1.0rc1]
  netrc_credential_store C:\localapp\Program Files\Bazaar\plugins\netrc_credential_store [2.1.0rc1]
  qbzr C:\localapp\Program Files\Bazaar\plugins\qbzr [0.19.0dev]
  rebase C:\localapp\Program Files\Bazaar\plugins\rebase [0.5.5]
  svn C:\localapp\Program Files\Bazaar\plugins\svn [1.0.1]
  upload C:\localapp\Program Files\Bazaar\plugins\upload [1.0.0dev]
  xmloutput C:\localapp\Program Files\Bazaar\plugins\xmloutput [0.8.5]

Problem was introduced in revno:425
Invalid syntax used in definition of version_info in __init__.py

A branch with a suggested fix will be proposed for merge shortly.

[Martin Pool (mbp)]

On 10 February 2010 21:51, David Roberts <email address hidden> wrote:

> bzr: ERROR: exceptions.ValueError: version_info (1, 0, 0, 'rc', 0) not
> valid
>
> Traceback (most recent call last):
>  File "C:/localapp/Program Files/Bazaar/plugins\explorer\lib\explorer.py", line 1847, in do_about
>  File "bzrlib\__init__.pyo", line 107, in _format_version_tuple
> ValueError: version_info (1, 0, 0, 'rc', 0) not valid

This check (which I added) is bullshit. It encodes bzr policy into a
library useful to others. Please just delete it.

--
Martin <http://launchpad.net/~mbp/>

[David Roberts (smartgpx)]

As an interim measure the reported Error has been fixed by modifying the Caller (ie. ..\plugins\explorer\__init__.py )

The OP is not going to attempt to fix anything in bzrlib - I don't have Python on my Windows machines or Qt on my linux netbook, so any changes would be untestable.

Removing the test (either the whole IF starting at line 95, or just the terminating ELSE at line 106) would mean that this requirement (from the method definition) would no longer be satisfied
 >>> print _format_version_tuple((1, 4, 0, 'wibble', 0))
    Traceback (most recent call last):
    ...
    ValueError: version_info (1, 4, 0, 'wibble', 0) not valid

So the value of 'Release Level' would not be validated.

There is another 'puzzle' related to this area.

Here is some output from 'bzr plugins' -

H:\David\bzrlpbranches\bzr>bzr plugins -v
bzrtools 2.1.0b1
    Various useful commands for working with bzr.
    C:\Added Program Files\Bazaar\plugins\bzrtools

explorer 1.0.0.rc.0
    Version Control for Human Beings.
    C:\Added Program Files\Bazaar\plugins\explorer

launchpad 2.1.0rc1
    Launchpad.net integration plugin for Bazaar.
    C:\Added Program Files\Bazaar\plugins\launchpad

Note that only explorer (with my patch) has the separator between release_level and serial. Why?

[Alexander Belchenko (bialix)]

David Roberts пишет:
> As an interim measure the reported Error has been fixed by modifying the
> Caller (ie. ..\plugins\explorer\__init__.py )
>
> The OP is not going to attempt to fix anything in bzrlib - I don't have
> Python on my Windows machines or Qt on my linux netbook, so any changes
> would be untestable.

I think we just need different API for using in bzr-explorer, something
from plugin.py module.

> Removing the test (either the whole IF starting at line 95, or just the terminating ELSE at line 106) would mean that this requirement (from the method definition) would no longer be satisfied
> >>> print _format_version_tuple((1, 4, 0, 'wibble', 0))
> Traceback (most recent call last):
> ...
> ValueError: version_info (1, 4, 0, 'wibble', 0) not valid
>
> So the value of 'Release Level' would not be validated.
>
> There is another 'puzzle' related to this area.
>
> Here is some output from 'bzr plugins' -
>
> H:\David\bzrlpbranches\bzr>bzr plugins -v
> bzrtools 2.1.0b1
> Various useful commands for working with bzr.
> C:\Added Program Files\Bazaar\plugins\bzrtools
>
> explorer 1.0.0.rc.0
> Version Control for Human Beings.
> C:\Added Program Files\Bazaar\plugins\explorer
>
> launchpad 2.1.0rc1
> Launchpad.net integration plugin for Bazaar.
> C:\Added Program Files\Bazaar\plugins\launchpad
>
> Note that only explorer (with my patch) has the separator between
> release_level and serial. Why?

I think this is because rc0 is invalid, Ian really should have used rc1
instead. And quick check confirms this.

[Ian Clatworthy (ian-clatworthy)]

Alexander Belchenko wrote:

>> Note that only explorer (with my patch) has the separator between
>> release_level and serial. Why?
>
> I think this is because rc0 is invalid, Ian really should have used rc1
> instead. And quick check confirms this.

The trouble is that I don't want the UI to say "rc1" until I actually
release RC1. In the absence of rc1.dev, rc0 seems sensible enough. :-)

Ian C.