Comment 2 for bug 519757

Revision history for this message
David Roberts (smartgpx) wrote :

As an interim measure the reported Error has been fixed by modifying the Caller (ie. ..\plugins\explorer\__init__.py )

The OP is not going to attempt to fix anything in bzrlib - I don't have Python on my Windows machines or Qt on my linux netbook, so any changes would be untestable.

Removing the test (either the whole IF starting at line 95, or just the terminating ELSE at line 106) would mean that this requirement (from the method definition) would no longer be satisfied
 >>> print _format_version_tuple((1, 4, 0, 'wibble', 0))
    Traceback (most recent call last):
    ...
    ValueError: version_info (1, 4, 0, 'wibble', 0) not valid

So the value of 'Release Level' would not be validated.

There is another 'puzzle' related to this area.

Here is some output from 'bzr plugins' -

H:\David\bzrlpbranches\bzr>bzr plugins -v
bzrtools 2.1.0b1
    Various useful commands for working with bzr.
    C:\Added Program Files\Bazaar\plugins\bzrtools

explorer 1.0.0.rc.0
    Version Control for Human Beings.
    C:\Added Program Files\Bazaar\plugins\explorer

launchpad 2.1.0rc1
    Launchpad.net integration plugin for Bazaar.
    C:\Added Program Files\Bazaar\plugins\launchpad

Note that only explorer (with my patch) has the separator between release_level and serial. Why?