Should not report tests in abstract class as invalid
Bug #488002 reported by
Kenneth Xu
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
NUnit Framework |
Fix Released
|
High
|
Adam Connelly | ||
NUnit V2 |
Fix Released
|
Medium
|
Charlie Poole |
Bug Description
Making a class abstract should be sufficient to indicate the test fixture is intended to be inherited by other concrete test fixture.
The problem occurs when the said abstract test fixture inherits from a 3rd party test fixture that already has TestFixture attribute, there is no way to avoid the warning now.
See http://
Related branches
Changed in nunitv2: | |
status: | New → Confirmed |
Changed in nunit-3.0: | |
status: | New → Confirmed |
Changed in nunitv2: | |
assignee: | nobody → Charlie Poole (charlie.poole) |
milestone: | none → 2.5.3 |
status: | Confirmed → In Progress |
Changed in nunitv2: | |
importance: | Undecided → Medium |
Changed in nunitv2: | |
status: | In Progress → Fix Committed |
Changed in nunit-3.0: | |
status: | Confirmed → Triaged |
importance: | Undecided → High |
tags: | added: easy v2port |
Changed in nunitv2: | |
status: | Fix Committed → Fix Released |
Changed in nunit-3.0: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Charlie, is this definitely a problem on the current trunk? I tried to reproduce it (by making the same changes that you made to nunitv2) and the test runner didn't produce any warnings. Also, you removed two tests about not being able to run abstract fixtures and added two tests about being able to run fixtures derived from abstract fixtures (more or less). I couldn't see anything about warnings. My understanding of this is that you still shouldn't be able to run abstract fixtures, but you shouldn't get any warnings about abstract classes that are marked as fixtures. Am I missing something?