Tests in generic class without proper TestFixture attribute should be reported as invalid
Bug #487878 reported by
Kenneth Xu
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
NUnit Framework |
Fix Released
|
High
|
Adam Connelly | ||
NUnit V2 |
Fix Released
|
Medium
|
Charlie Poole |
Bug Description
There are two cases that NUnit should report invalid tests but it doesn't:
1) without TestFixtureAttr
// forgot [TestFixture(
public class GenericTestFixt
{
[Test] public void TestOnGenericFi
}
2) with inherited TestFixtureAttr
[TestFixture]
public class ThirdPartyFixture
{
}
// forgot [TestFixture(
public class GenericTestFixt
{
[Test] public void TestOnGenericFi
}
See http://
Related branches
lp:~adam-rpconnelly/nunit-3.0/bug-487878
Merged
into
lp:nunit-3.0
- Charlie Poole: Needs Fixing
-
Diff: 172 lines (+108/-14)3 files modifiedsrc/framework/Internal/Extensions/NUnitTestFixtureBuilder.cs (+21/-4)
src/test-assembly/TestFixtureData.cs (+33/-0)
src/tests/NUnit/Core/TestFixtureTests.cs (+54/-10)
Changed in nunitv2: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Charlie Poole (charlie.poole) |
milestone: | none → 2.5.3 |
Changed in nunitv2: | |
status: | In Progress → Fix Committed |
Changed in nunit-3.0: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: v2port |
Changed in nunitv2: | |
status: | Fix Committed → Fix Released |
Changed in nunit-3.0: | |
assignee: | nobody → Adam Connelly (adam-rpconnelly) |
Changed in nunit-3.0: | |
milestone: | none → 2.9.4 |
Changed in nunit-3.0: | |
milestone: | 2.9.4 → none |
Changed in nunit-3.0: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Merged manually, updating to reflect code changes in the trunk.