OK button not enabled after adding printer

[Scott Dylewski]

Binary package hint: system-config-printer

After successfully adding a printer (laserjet 5M), a dialog box asks if I want to print a test page. I clicked "ok", and the page printed successfully, but then the "ok" button stayed grayed out even after the process finished. The OK button should be enabled! only the "cancel" button is enabled. 1.1.12+git20090826-0ubuntu5. The version with the problem is This works correctly on my older laptop running system-config-printer-gnome 1.1.3+git20090218-0ubuntu19.2

ProblemType: Bug
Architecture: i386
Date: Mon Oct 5 22:21:17 2009
DistroRelease: Ubuntu 9.10
Lpstat: device for HP-LaserJet-5M: socket://192.168.0.190:9100
MachineType: LENOVO 20021,2959
NonfreeKernelModules: wl
Package: system-config-printer-gnome 1.1.12+git20090826-0ubuntu5
PackageArchitecture: all
Papersize: letter
PpdFiles: HP-LaserJet-5M: HP LaserJet 5M - CUPS+Gutenprint v5.2.4
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-11-generic root=UUID=9e7cc5b9-4dfd-44f7-bb38-b1bd7c6a7eea ro quiet splash
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-11.38-generic
SourcePackage: system-config-printer
Tags: ubuntu-unr
Uname: Linux 2.6.31-11-generic i686
dmi.bios.date: 06/01/2009
dmi.bios.vendor: LENOVO
dmi.bios.version: 19CN17WW
dmi.board.name: MoutCook
dmi.board.vendor: LENOVO
dmi.board.version: Not Applicable
dmi.chassis.asset.tag: No Asset Tag
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: N/A
dmi.modalias: dmi:bvnLENOVO:bvr19CN17WW:bd06/01/2009:svnLENOVO:pn20021,2959:pvrLenovoIdeapadS12:rvnLENOVO:rnMoutCook:rvrNotApplicable:cvnLENOVO:ct10:cvrN/A:
dmi.product.name: 20021,2959
dmi.product.version: Lenovo Ideapad S12
dmi.sys.vendor: LENOVO

[Till Kamppeter (till-kamppeter)]

I have seen this, too.

Tim, is this intended behavior? And if yes, why? I think the OK button should be always active, even if all changes are already saved by clicking "Apply".

[Tim Waugh (twaugh)]

It probably shouldn't display the properties dialog at all.

[Till Kamppeter (till-kamppeter)]

Tim, for me the "OK" button is even grayed out when I right-click the icon of an existing print queue and choose "Properties" in the pop-up menu. The "OK" button should always be active, even if there are no changes to be saved, Can you also attach a patch to fix this issue? Thanks.

[Tim Waugh (twaugh)]

*That* part is intentional:
https://bugzilla.redhat.com/show_bug.cgi?id=493891

[Launchpad Janitor (janitor)]

This bug was fixed in the package system-config-printer - 1.1.12+git20090826-0ubuntu6

---------------
system-config-printer (1.1.12+git20090826-0ubuntu6) karmic; urgency=low

  * debian/patches/67_match-usb-uris-of-usblp-and-libusb.patch: Let the
    udev callout not only match absolutely identical URIs but also USB
    URIs being for the same device but obtained via access through the
    usblp kernel module or via low-level USB (libusb). This avoids creation
    of new print queues when the kernel module is loaded or unloaded
    (LP: #448583).

  * debian/patches/73_dont-display-properties-dialog-for-first-test-page.patch:
    Do not display the printer properties dialog when printing a test page
    right after creating a new print queue (LP: #444280).

 -- Till Kamppeter <email address hidden> Tue, 13 Oct 2009 23:38:09 +0200

[DrKay (dr-jameskay)]

I just added a printer in Ubuntu 11.04. This is not fixed. Attached is a screenshot.

[Pascal De Vuyst (pascal-devuyst)]

1) The printer properties dialog is displaying again in Ubuntu 11.04 (system-config-printer-gnome 1.3.1+20110222-0ubuntu16.3) when asked to print a test page and clicking OK right after creating a new print queue, so reopening.

2) Apart from that the "intentional" grayed out OK button of the printer properties dialog seems to be different to what is mentioned in the GNOME Human Interface Guidelines (http://developer.gnome.org/hig-book/3.0/hig-book.html#windows-explicit-apply) and what people expect. Also have a look at bug #576348 which is the same issue. The printer properties dialog Apply-Cancel-OK buttons should follow the HIG.

[Till Kamppeter (till-kamppeter)]

Tim, I think it is much less confusing if the OK button is always active, even if there are no changes to be saved.

[DrKay (dr-jameskay)]

Hello-

I think the expected behavior in this situation is for the OK button to close the window/properties box. So, even if there are no new settings to apply, it should just close the window.

Thank you

[Tim Waugh (twaugh)]

See what you think of commit 4ede663. The only situation in which OK is not sensitive is if there are conflicts.

[Launchpad Janitor (janitor)]

This bug was fixed in the package system-config-printer - 1.3.5+20110801-0ubuntu1

---------------
system-config-printer (1.3.5+20110801-0ubuntu1) oneiric; urgency=low

  * New upstream release
     o GIT 1.3.x snapshot from 1 August 2011
     o Deactivate OK button of the printer properties dialog only if there are
       conflicts between settings (LP: #444280).
     o Make PackageKit optional in cupshelpers (Red Hat bug #726996,
       LP: #819000, LP: #819267).
  * debian/control: Removed dependency on python-packagekit again, as this
    package is in Universe (LP: #819267).
 -- Till Kamppeter <email address hidden> Mon, 01 Aug 2011 16:43:19 +0200

[Till Kamppeter (till-kamppeter)]

Tim, thanks for the quick fix.