notify-osd changes the way it supports int32-hints

[Ken VanDine]

Binary package hint: gnome-settings-daemon

The way notify-osd treats int32-hints passed to it has changed. The net result of this is that the UI-behaviour of the
feedback-notifications (Volume Up/Down, Screen-Brightness Up/Down, Keyboard-Brightness Up/Down) works now correctly with under- and overshoot throbbing.

[Ken VanDine (ken-vandine)]

Patch from Mirco Müller

[Ken VanDine (ken-vandine)]

Patch from Mirco Müller

[Sebastien Bacher (seb128)]

Thanks but as said on IRC I'm not convinced by the new gboolean use, why the volume value couldn't be used directly?

[Ken VanDine (ken-vandine)]

Mirco can you respond to Sebastien's comment?

[Mirco Müller (macslow)]

The design team wants the indicator to "throb" when the user hits volume/brightness up (down) but the systems state-value for that is already at its maximum (minimum). The only way to communicate this to notify-osd by using these special values 101 (-1), because notify-osd has no (and should not have) any knowledge about system state-values for volume/brightness. notify-osd just displays values without any knowledge of its context.

Using values 0 and 100 like it was before, does not work. This is also a bug reported by one of the members of the design team here: https://bugs.edge.launchpad.net/notify-osd/+bug/337820. The cause for that bug is due to the incomplete or wrong patch work done on g-s-d and g-p-m during the jaunty cycle. My patches fixes all that. Initially I also considered fixing this already for the jaunty SRU-phase, but that would have not gone past the SRU-policy-enforcers.

BTW the volume/brightness value is used directly if 0 <= value <= 100.

In addition to that the use of those two booleans make the code/patch easier to read and thus understand.

[Sebastien Bacher (seb128)]

let's upload this version for now that doesn't seem the optimal way to do things but if that's working

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-settings-daemon - 2.27.3-0ubuntu2

---------------
gnome-settings-daemon (2.27.3-0ubuntu2) karmic; urgency=low

  * debian/patches/16_use_synchronous_notifications.patch:
    - update by Mirco Müller to work better with notify-osd (lp: #390670)

 -- Sebastien Bacher <email address hidden> Tue, 23 Jun 2009 00:07:34 +0200