Comment 5 for bug 390670

Revision history for this message
Mirco Müller (macslow) wrote :

The design team wants the indicator to "throb" when the user hits volume/brightness up (down) but the systems state-value for that is already at its maximum (minimum). The only way to communicate this to notify-osd by using these special values 101 (-1), because notify-osd has no (and should not have) any knowledge about system state-values for volume/brightness. notify-osd just displays values without any knowledge of its context.

Using values 0 and 100 like it was before, does not work. This is also a bug reported by one of the members of the design team here: https://bugs.edge.launchpad.net/notify-osd/+bug/337820. The cause for that bug is due to the incomplete or wrong patch work done on g-s-d and g-p-m during the jaunty cycle. My patches fixes all that. Initially I also considered fixing this already for the jaunty SRU-phase, but that would have not gone past the SRU-policy-enforcers.

BTW the volume/brightness value is used directly if 0 <= value <= 100.

In addition to that the use of those two booleans make the code/patch easier to read and thus understand.