Migrated tags under Related Tags gives UnboundLocalError on "related"

[Anthony]

Entering Tag on My Profile followed by enter - All Person's Name Tags Produces General KARL Error. Traceback code attached.

To reproduce:

1) Go to http://kdiab.sixfeetup.com/profiles/plonepaul

2) Click on "africa" in "Paul's tags" portlet on right.

3) Click on "aryeh" in "Related Tags"

This only happens for tags that are migrated. New tags don't have this problem.

[Paul Everitt (paul-agendaless)]

Tres, can you take a look at this one?

[Tres Seaver (tseaver)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status inprogress

- --
===================================================================
Tres Seaver [phone] <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKCyNv+gerLs4ltQ4RAugVAJ4qknqKZ4nkGPnkSLtMS9rd3d86qgCgwvyM
wAP6X9Cpia3Zd9TiePAgSjU=
=hfvX
-----END PGP SIGNATURE-----

[Paul Everitt (paul-agendaless)]

As a quick FYI, OSI plans to test migration of tags and office stuff in the morning around 10:30. It's not imperative that you wrap this one or others up, it's just an FYI. I told them to review the open bugs before eval.

Regarding updates, Chris Rossi is going to svn up now and kick off an import. We'll probably svn up again in the morning if it is worthwhile.

[Chris Rossi (chris-archimedeanco)]

Paul asked me to poach this one.

[Chris Rossi (chris-archimedeanco)]

Ok, I've commited a fix for the problem which creates the error. However, there remains, in my opinion, still a higher level logical error that I'm not entirely sure what to do with.

In the case above, with the fix in place, now, when you click on 'aryeh_neier' you're going to get a page with no results on it because the user, plonepaul, has not applied the 'aryeh_neier' tag to anything, and we are still in the plonepaul context using the profile_showtag_view.

I see a couple of better behaviors for this:

1) Don't show related tags that weren't applied by profile user in this profile context, ie don't show tags not applied by plonepaul.

2) When clicking on a related tag, move out of the profile context into the global context. IE, instead of going to /profiles/plonepaul/showtag/aryeh_neier, go to /showtag/aryeh_neier at the site root. This way we'll see everything tagged with 'aryeh_neier', whether plonepaul did it or not. I think this is a bit more intuitive since I don't think the end user is going retain, mentally, an idea that he is still in a plonepaul context after having clicked away by a couple of clicks at this point. Especially, since there is no discernible UI element indicating that you are in the plonepaul context, other than the url in your address bar.

2 makes a little more sense to me. I've also looked at the related_tags code and I'm pretty sure that implementing 1 would be pretty hard and doing it in a very performant way would be next to impossible. Unless we can change the ITaggingEngine API.

[Paul Everitt (paul-agendaless)]

I believe that behavior isn't the correct (KARL2) behavior. Tags are
"related" between users, not just "if you tagged the same resource
with another tag".

--Paul

On May 15, 2009, at 12:43 PM, Chris Rossi wrote:

> Ok, I've commited a fix for the problem which creates the error.
> However, there remains, in my opinion, still a higher level logical
> error that I'm not entirely sure what to do with.
>
> In the case above, with the fix in place, now, when you click on
> 'aryeh_neier' you're going to get a page with no results on it because
> the user, plonepaul, has not applied the 'aryeh_neier' tag to
> anything,
> and we are still in the plonepaul context using the
> profile_showtag_view.
>
> I see a couple of better behaviors for this:
>
> 1) Don't show related tags that weren't applied by profile user in
> this
> profile context, ie don't show tags not applied by plonepaul.
>
> 2) When clicking on a related tag, move out of the profile context
> into
> the global context. IE, instead of going to
> /profiles/plonepaul/showtag/aryeh_neier, go to /showtag/aryeh_neier at
> the site root. This way we'll see everything tagged with
> 'aryeh_neier',
> whether plonepaul did it or not. I think this is a bit more intuitive
> since I don't think the end user is going retain, mentally, an idea
> that
> he is still in a plonepaul context after having clicked away by a
> couple
> of clicks at this point. Especially, since there is no discernible UI
> element indicating that you are in the plonepaul context, other than
> the
> url in your address bar.
>
> 2 makes a little more sense to me. I've also looked at the
> related_tags
> code and I'm pretty sure that implementing 1 would be pretty hard and
> doing it in a very performant way would be next to impossible. Unless
> we can change the ITaggingEngine API.
>
> --
> Migrated tags under Related Tags gives UnboundLocalError on "related"
> https://bugs.launchpad.net/bugs/375547
> You received this bug notification because you are subscribed to
> KARL3.
>
> Status in Porting KARL to a new architecture: In Progress
>
> Bug description:
> Entering Tag on My Profile followed by enter - All Person's Name
> Tags Produces General KARL Error. Traceback code attached.
>
> To reproduce:
>
> 1) Go to http://kdiab.sixfeetup.com/profiles/plonepaul
>
> 2) Click on "africa" in "Paul's tags" portlet on right.
>
> 3) Click on "aryeh" in "Related Tags"
>
> This only happens for tags that are migrated. New tags don't have
> this problem.

[Chris Rossi (chris-archimedeanco)]

Hi Paul,

I'm not sure we're talking about the same thing. When I see "Related Tags" portlet on the right of a "Show Tag" view, I would, intuitively, expect to see everything with that tag when I click on it. At this point I'm no longer looking at a profile and there's no UI indication that I'm, navigationally speaking, underneath a profile.

This is not to say that tags aren't related between users. They are, in the current system even. This touches upon what we talked about in irc that in order to get two tags to be related I had to put them on the same piece of content and make them by the same user.

Is that clear as mud?

We may need to do a phone call on this one.

Thanks,
Chris

[Paul Everitt (paul-agendaless)]

Are you looking at KARL2's (karl.soros.org) behavior for this?

--Paul

On May 15, 2009, at 4:44 PM, Chris Rossi wrote:

> Hi Paul,
>
> I'm not sure we're talking about the same thing. When I see "Related
> Tags" portlet on the right of a "Show Tag" view, I would, intuitively,
> expect to see everything with that tag when I click on it. At this
> point I'm no longer looking at a profile and there's no UI indication
> that I'm, navigationally speaking, underneath a profile.
>
> This is not to say that tags aren't related between users. They
> are, in
> the current system even. This touches upon what we talked about in
> irc
> that in order to get two tags to be related I had to put them on the
> same piece of content and make them by the same user.
>
> Is that clear as mud?
>
> We may need to do a phone call on this one.
>
> Thanks,
> Chris
>
> --
> Migrated tags under Related Tags gives UnboundLocalError on "related"
> https://bugs.launchpad.net/bugs/375547
> You received this bug notification because you are subscribed to
> KARL3.
>
> Status in Porting KARL to a new architecture: In Progress
>
> Bug description:
> Entering Tag on My Profile followed by enter - All Person's Name
> Tags Produces General KARL Error. Traceback code attached.
>
> To reproduce:
>
> 1) Go to http://kdiab.sixfeetup.com/profiles/plonepaul
>
> 2) Click on "africa" in "Paul's tags" portlet on right.
>
> 3) Click on "aryeh" in "Related Tags"
>
> This only happens for tags that are migrated. New tags don't have
> this problem.