Please merge classpath 2:0.97.2-1.1 (universe) from Debian unstable

[Manny Vindiola]

Binary package hint: classpath

Please merge classpath 2:0.97.2-1.1 (universe) from Debian unstable

[Manny Vindiola (serialorder)]

package ready for merge (i think)
package builds successfully in i386 pbuilder

I had to change builddepends on iceape-dev to libxul-dev to fix a FTBFS error.
It solved the problem but I am not totally sure if that was the right thing to do. I just followed the advice mentioned in the package descriptions.

Potentially important note: gcjwebplugin has been disabled due to security issue
should we open a security bug for previous versions?
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=267040

changelog
classpath (2:0.97.2-1.1ubuntu1) jaunty; urgency=low

  * Merge from debian unstable (LP: #309549)(LP: #237668), remaining changes:
    * debian/control:
      - Recommend firefox instead of mozilla-firefox.
    * Fix FTBFS caused by -Werror where return value of 'chdir' was ignored
      - add debian/patches/20_fix_ftbfs_warn_unused_result.dpatch
      - update debian/patches/00list
    * fix LP: #272772: packages that Depend/Recommend/Suggest firefox
       (meta-package) must alternatively Depend/Recommend/Suggest abrowser
  * Fix FTBFS due to missing mozilla-plugin build dependency
    - added build-depends on libxul-dev
    - removed build depends on

 -- Manny Vindiola <email address hidden> Thu, 18 Dec 2008 21:24:48 -0500

classpath (2:0.97.2-1.1) unstable; urgency=high

  * Non-maintainer upload.
  * Redisable gcjwebplugin for all architectures, since the security
    issues are not considered to be adequately resolved for lenny and the
    icedtea-gcjwebplugin is now available (closes: #267040).

 -- Sean Finney <email address hidden> Sun, 26 Oct 2008 21:45:32 +0100

classpath (2:0.97.2-1) unstable; urgency=low

  * New upstream release.
  * Reenable gcjwebplugin for all architectures.
  * Cleaned up Build-Depends.
  * Moved all tools from classpath into classpath-common package.
  * Moved gappletviewer from gcjwebplugin into classpath package.
  * Build only the needed stuff when building arch:any packages only.

 -- Michael Koch <email address hidden> Fri, 06 Jun 2008 08:32:51 +0200

classpath (2:0.97.1-4) unstable; urgency=low

  * Build gcjwebplugin only on amd64, armel, i386, mips, mipsel and powerpc.

 -- Michael Koch <email address hidden> Sat, 31 May 2008 21:37:32 +0200

classpath (2:0.97.1-3) unstable; urgency=low

  * Build-Depends iceape-dev install of libxul-dev. Closes: #480803

 -- Michael Koch <email address hidden> Fri, 23 May 2008 07:48:05 +0200

classpath (2:0.97.1-2) unstable; urgency=low

  * Build-Depends on ecj and gcj not on alpha, arm, hppa and hurd-i386.
    Closes: #477852

 -- Michael Koch <email address hidden> Mon, 05 May 2008 18:00:40 -0100

classpath (2:0.97.1-1) unstable; urgency=low

  * New upstream release
    - Disable javadoc generation for jsr166 code. This breaks with current
      gjdoc.
  * Re-add conditional for Alsa dependencies. Closes: #468851.
  * Added patch from Petter Reinholdtsen to fix Swing buttons.

 -- Michael Koch <email address hidden> Wed, 16 Apr 2008 07:46:14 +0200

classpath (2:0.97-1) unstable; urgency=low

  * New upstream release.
    - JAP GUI works now. Closes: #349062.
  * debian/control (classpath): Depend on classpath-common (>= 2:0.97).
  * debian/control (gcjwebplugin): Recommend i...

[James Westby (james-w)]

Hi Manny,

Thanks for working on this. I'm not sure if we want to be disabling the
gcjwebplugin as Debian has done; I would lean towards doing it.

Thanks,

James

[James Westby (james-w)]

Hi Manny,

I also have a couple of comments about the diff from Debian.

Firstly, I don't see a difference in the XB-Npp-MimeType lines
that show up in the diff, am I missing something, or is it just whitespace?

Also, Fabien's patch to handle chdir errors appears to leak file descriptors,
it should use the same error handling as lower down in the function. I can't
see that the patch was forwarded either. It would be great if it was sent to
when corrected.

  http://www.gnu.org/software/classpath/

Thanks,

James

[Manny Vindiola (serialorder)]

>Firstly, I don't see a difference in the XB-Npp-MimeType lines
>that show up in the diff, am I missing something, or is it just whitespace?

There was a trailing space, I have removed it.

>Also, Fabien's patch to handle chdir errors appears to leak file descriptors,
I don't think it does but I could of course be wrong.
The code in cpproc.c near the patch looks like this:
...
 close_all_fds(local_fds, pipe_count * 2);

 chdir(wd);
...

from what I understand the line right before chdir(wd) closes the open file descriptors but maybe I am missing something?
I will submittodebian when it is accepted.

I have a question I have had a hard time finding an answer to:
When should one choose among: iceape-dev, seamonkey-dev, libxul-dev, xulrunner-1.9-dev ?
I have asked a few times on irc but never received a response. It seams that the iceape-dev comments suggest using seamonkey-dev instead, seamonkey-dev suggest using libxul-dev instead and I read something from debian that said not to use libxul-dev but to prefer xulrunner-dev. That message is here: http://lists.debian.org/debian-release/2008/05/msg00009.html

[Manny Vindiola (serialorder)]

Regarding the gcjwebplugin plugin i think it makes sense to disable it given that it lackas a security manager and the icedtea-gcjwebplugin exists as a replacement. That is just my two sense though and I have only been at this for about 5 weeks.

[Launchpad Janitor (janitor)]

This bug was fixed in the package classpath - 2:0.97.2-1.1ubuntu1

---------------
classpath (2:0.97.2-1.1ubuntu1) jaunty; urgency=low

  [ Manny Vindiola ]
  * Merge from debian unstable (LP: #309549)(LP: #237668), remaining changes:
    * debian/control:
      - Recommend firefox instead of mozilla-firefox.
    * Fix FTBFS caused by -Werror where return value of 'chdir' was ignored
      - add debian/patches/20_fix_ftbfs_warn_unused_result.dpatch
      - update debian/patches/00list
    * fix LP: #272772: packages that Depend/Recommend/Suggest firefox
       (meta-package) must alternatively Depend/Recommend/Suggest abrowser
  * Fix FTBFS due to missing mozilla-plugin build dependency
    - changed to build-depends on libxul-dev instead of iceape-dev

  [ James Westby ]
  * Add libsamplerate0-dev to Build-Depends to fix build error by not being
    able to find the .a file from it. This is a dependency of jack, but not
    specified in it's depends. This is probably due to bug 258491, and so if
    that is fixed try building without the extra Build-Depends.

classpath (2:0.97.2-1.1) unstable; urgency=high

  * Non-maintainer upload.
  * Redisable gcjwebplugin for all architectures, since the security
    issues are not considered to be adequately resolved for lenny and the
    icedtea-gcjwebplugin is now available (closes: #267040).

classpath (2:0.97.2-1) unstable; urgency=low

  * New upstream release.
  * Reenable gcjwebplugin for all architectures.
  * Cleaned up Build-Depends.
  * Moved all tools from classpath into classpath-common package.
  * Moved gappletviewer from gcjwebplugin into classpath package.
  * Build only the needed stuff when building arch:any packages only.

classpath (2:0.97.1-4) unstable; urgency=low

  * Build gcjwebplugin only on amd64, armel, i386, mips, mipsel and powerpc.

classpath (2:0.97.1-3) unstable; urgency=low

  * Build-Depends iceape-dev install of libxul-dev. Closes: #480803

classpath (2:0.97.1-2) unstable; urgency=low

  * Build-Depends on ecj and gcj not on alpha, arm, hppa and hurd-i386.
    Closes: #477852

classpath (2:0.97.1-1) unstable; urgency=low

  * New upstream release
    - Disable javadoc generation for jsr166 code. This breaks with current
      gjdoc.
  * Re-add conditional for Alsa dependencies. Closes: #468851.
  * Added patch from Petter Reinholdtsen to fix Swing buttons.

classpath (2:0.97-1) unstable; urgency=low

  * New upstream release.
    - JAP GUI works now. Closes: #349062.
  * debian/control (classpath): Depend on classpath-common (>= 2:0.97).
  * debian/control (gcjwebplugin): Recommend iceweasel instead of
    mozilla-firefox by default.
  * Add XB-Npp-* headers from Ubuntu.
  * Removed debian/classpath.links: Obsolete.

 -- Manny Vindiola <email address hidden> Thu, 18 Dec 2008 21:24:48 -0500

[James Westby (james-w)]

Hi Manny,

As you see I just uploaded your merge, thanks.

I see you are correct about Fabien's patch, thanks for that.

Debian packages xul differently, so the packages that are required are
different, so I believe libxul-dev is correct for Ubuntu, whereas Debian asks
for xulrunner-dev.

Thanks,

James