Comment 4 for bug 309549

Revision history for this message
Manny Vindiola (serialorder) wrote :

>Firstly, I don't see a difference in the XB-Npp-MimeType lines
>that show up in the diff, am I missing something, or is it just whitespace?

There was a trailing space, I have removed it.

>Also, Fabien's patch to handle chdir errors appears to leak file descriptors,
I don't think it does but I could of course be wrong.
The code in cpproc.c near the patch looks like this:
...
 close_all_fds(local_fds, pipe_count * 2);

 chdir(wd);
...

from what I understand the line right before chdir(wd) closes the open file descriptors but maybe I am missing something?
I will submittodebian when it is accepted.

I have a question I have had a hard time finding an answer to:
When should one choose among: iceape-dev, seamonkey-dev, libxul-dev, xulrunner-1.9-dev ?
I have asked a few times on irc but never received a response. It seams that the iceape-dev comments suggest using seamonkey-dev instead, seamonkey-dev suggest using libxul-dev instead and I read something from debian that said not to use libxul-dev but to prefer xulrunner-dev. That message is here: http://lists.debian.org/debian-release/2008/05/msg00009.html