/usr/bin/update-manager:AttributeError:<lambda>:available:start_available:refresh_cache:_get_ua_security_status

[errors.ubuntu.com bug bridge]

Impact
------

This bug was is a regression of the bug fix LP:2058133; It held back the phasing of the package.

The symptom is that update-manager crashes right at start, doesn't launch.

The ua.updates() and current_news() end-points are documented to throw no exceptions, but actually they might, in which case this bug is encountered. As such, the proposed fix tries the API but ignores exceptions raised by it, causing update-manager to still work, even if the Pro packages end up being classified as normal packages or if Pro news aren't displayed.

Test plan
---------

Run 'UA_CONFIG_FILE=/ update-manager --no-update', update-manager should launch, not crash.

Where problems could occur
--------------------------

If the API end-points are working, ensure that classifying Pro packages as such and displaying possible Pro news continues to work.

Original report
---------------

Looks like ua.updates() can actually throw an exception. Only that would explain this crash.

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/UpdateManager/Dialogs.py", line 118, in <lambda>
    button.connect("clicked", lambda x: callback())
  File "/usr/lib/python3/dist-packages/UpdateManager/Dialogs.py", line 371, in available
    self.window_main.start_available(error_occurred=True)
  File "/usr/lib/python3/dist-packages/UpdateManager/UpdateManager.py", line 242, in start_available
    self.refresh_cache()
  File "/usr/lib/python3/dist-packages/UpdateManager/UpdateManager.py", line 461, in refresh_cache
    self._get_ua_security_status()
  File "/usr/lib/python3/dist-packages/UpdateManager/UpdateManager.py", line 285, in _get_ua_security_status
    for package in self.ua_updates:
AttributeError: 'UpdateManager' object has no attribute 'ua_updates'

The Ubuntu Error Tracker has been receiving reports about a problem regarding update-manager. This problem was most recently seen with package version 1:22.04.20, the problem page at https://errors.ubuntu.com/problem/ed0e9f0ed8bc4002d808a11e37e4ee9d870e32c1 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://forms.canonical.com/reports/.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:24.10.1

---------------
update-manager (1:24.10.1) oracular; urgency=medium

  [ Nathan Pratta Teodosio ]
  * Don't crash if the updates() end-point of the Pro API fails (LP: #2064211).

  [ Himadri Sekhar Basu ]
  * Fix scroll window on update downloading page
    - Currently the download progress box does not
      expand vertically when in fullscreen, however
      the expansion in vertical direction with
      increasing window height is the proper
      behaviour. This fix provides this desired
      behaviour.
    - Fixes LP: #1772486, LP: #1856404

 -- Graham Inggs <email address hidden> Wed, 22 May 2024 15:21:09 +0000

[Nathan Teodosio (nteodosio)]

Fix was insufficient as per test case, current_news() also hits the same problem. Reverting to triaged and proposing a new merge request for that remaining part.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:24.10.2

---------------
update-manager (1:24.10.2) oracular; urgency=medium

  * Don't crash if the current_news() end-point of the Pro API fails
    (LP: #2064211).

 -- Nathan Pratta Teodosio <email address hidden> Fri, 24 May 2024 16:08:50 +0200