[SRU] Create directories for apt configuration files if they are absent
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
software-properties (Ubuntu) |
Fix Released
|
Low
|
Nathan Teodosio | ||
Xenial |
Fix Released
|
High
|
Nathan Teodosio |
Bug Description
Impact
------
The autopkgtest for 0.96.20.12, which introduces Ubuntu Pro in Xenial's software-
The failure is because, at some point in time, the .keep file were removed from the otherwise empty tests/aptroot/
It seems that previous uploaders did not use the Git checkout, as the offending commit was introduced in Jun 2019 and there were subsequent uploads that did contain those empty directories.
Test case
---------
Trigger an autopkgtest against the proposed package version. It must succeed.
Regression Potential
-------
Although the introduced change is idempotent, there could be other part of the code assuming the directories didn't exist and trying to create them with a "fail if already exists" approach, causing a runtime regression.
Related branches
- Sebastien Bacher: Approve
-
Diff: 59 lines (+15/-0)3 files modifieddebian/changelog (+7/-0)
softwareproperties/SoftwareProperties.py (+4/-0)
tests/test_dbus.py (+4/-0)
- Sebastien Bacher: Approve
- Ubuntu Core Development Team: Pending requested
-
Diff: 73 lines (+17/-1)4 files modifieddebian/changelog (+8/-0)
debian/control (+1/-1)
softwareproperties/SoftwareProperties.py (+4/-0)
tests/test_dbus.py (+4/-0)
Changed in software-properties (Ubuntu Xenial): | |
importance: | Undecided → High |
assignee: | nobody → Nathan Teodosio (nteodosio) |
I've included the bug reference to 0.96.20.13 and reuploaded (also force pushed the vcs so you might need to force pull over ubuntu/xenial)