Backport Ubuntu Pro to Xenial

[Nathan Teodosio]

* Impact

We want desktop integration with Ubuntu Pro

* Test case

- ensure that the machine isn't attached to ubuntu pro (otherwise the screen would not be displayed) and is online
$ pro status
and `$ pro detach` if needed

- $ software-properties-gtk
-> the list of tabs should include an 'Ubuntu Pro' one

The Ubuntu Pro tab should state 'This machine is not covered by an Ubuntu Pro subscription', display a 'Enable Ubuntu Pro' button and have other controls inactive

- click 'Enable Ubuntu Pro'
-> A dialog 'Enable Ubuntu Pro' opens
-> the first option 'Enter code on ubuntu.com/pro/attach' is selected
-> a pincode is displayed under the option

- go to http//ubuntu.com/pro/attach and enter the pincode
-> after some seconds the software-properties UI should update and display a green mark and 'Valid token' label on the right of the pincode

- click 'Confirm'
-> you should get an authentification prompt

- enter your password
-> a spinner starts animating instead of the 'Valid token' label
-> once the attachment job is done the dialog is autoclosed
-> the UI should now state 'Ubuntu Pro support is enabled', under Security 'ESM Infra', 'ESM Apps' and 'Kernel Livepatch' should be displayed an enabled
(or without 'ESM Apps' if you don't have the current ubuntu-advantage-tools)

- check that the '$ pro status' output matches the UI one

- try enabling/disable options
-> verify that the 'pro status' change accordingly

- Click 'Disable Ubuntu Pro'
-> you get asked for confirmation and password
-> confirm that the UI is back to the original state and that 'pro status' confirm the system isn't attached to Ubuntu Pro anymore

- Go through the testcase again but selecting the 'Or add token manually' option, the steps should be similar

* Regression Potential

There could be problems in the UI
The new service could be not working as expected
Strings are new and currently have no translations

The livepatch checkbox is also inactive because the current update-notifier version in xenial doesn't include livepatch support

-------------------------

Ubuntu Pro enables extended support for 10 years for long term support Ubuntu series. Xenial is therefore currently also supported under Ubuntu Pro.

Xenial's software-properties-gtk, however, doesn't have the Ubuntu Pro functionality that exists in Bionic, Focal etc.

Thus this request to backport the Ubuntu Pro functionality to Xenial.

This depends on LP:2029089.

[Robie Basak (racb)]

Note related bug 2029089 that needs releasing at the same time.

[Robie Basak (racb)]

Hello Nathan, or anyone else affected,

Accepted software-properties into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.96.20.11 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted software-properties (0.96.20.11) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

software-properties/0.96.20.11 (amd64, i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#software-properties

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Nathan Teodosio (nteodosio)]

That result is weird.

--->
491s ERROR: Python module urllib.request not found
491s ERROR: Python module urllib.error not found
491s ERROR: Python module urllib.parse not found
491s ERROR: Python module http.client not found
491s ERROR: Python module PyQt5.QtCore not found
491s ERROR: Python module PyQt5.QtGui not found
491s ERROR: Python module PyQt5 not found
491s ERROR: Python module I18nHelper not found
491s ERROR: Python module queue not found
491s ERROR: Python module urllib.request not found
491s ERROR: Python module PyQt5.QtCore not found
491s ERROR: Python module PyQt5.QtGui not found
491s ERROR: Python module PyQt5.QtWidgets not found
491s ERROR: Python module sip not found
491s ERROR: Python module aptdaemon not found
491s ERROR: Python module aptdaemon.errors not found
<---

We didn't even introduce half of those modules. Thinking...

[Nathan Teodosio (nteodosio)]

Although those are marked as "ERRORS" they don't fail the test as per
the .10 results[1].

What is failing the test is error:

--->
running build_ext
[Errno 2] No such file or directory:
'/tmp/autopkgtest.nvBrFt/build.RHr/src/tests/aptroot/etc/apt/sources.list'
<---

[1]
https://autopkgtest.ubuntu.com/results/autopkgtest-xenial/xenial/amd64/s/software-properties/20231025_145356_9e13b@/log.gz

[Timo Aaltonen (tjaalton)]

Hello Nathan, or anyone else affected,

Accepted software-properties into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.96.20.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Nathan Teodosio (nteodosio)]

I installed .12 from proposed.

Ensured that the machine wasn't attached to ubuntu pro with

$ pro status

Launched software-properties-gtk, went to the Ubuntu Pro tab, which stated 'This machine is not covered by an Ubuntu Pro subscription', displayed a 'Enable Ubuntu Pro' button and had the service controls inactive.

Clicked 'Enable Ubuntu Pro' and entered the PIN in ubuntu.com/pro/attach, after some seconds the software-properties UI updated and displayed a green mark and 'Valid token' label, I clicked 'Confirm', entered password at the prompt, the spinner showed up in place of the mark/label, once the attachment job was done the dialog was autoclosed.

The UI then stated 'Ubuntu Pro support is enabled' and under Security 'ESM Infra', 'ESM Apps' and 'Kernel Livepatch' were displayed an enabled, with '$ pro status' output matching the UI.

Enabled and disabled Infra in the UI and confirmed that the 'pro status' changed accordingly.

Clicked 'Disable Ubuntu Pro', got asked for confirmation and password, confirmed that the UI is back to the original state and that 'pro status' confirmed the system wasn't attached to Ubuntu Pro anymore.

The same testcase also succeeded for the 'Or add token manually' option.

[Andreas Hasenack (ahasenack)]

Version 0.96.20.10 passed in xenial/amd64 about 10 days ago (via an ubuntu-advantage-tools update), but version 0.96.20.12 failed a few days before. I triggered another run just in case.

If that new run also fails, then something is going on, and it has to be sorted out before this update can be released.

[Nathan Teodosio (nteodosio)]

Hi Andreas, thank you for having a look.

0.96.20.13 was queued to fix autopkgtest failures with 0.96.20.12. Do I need a new SRU bug for that?

[Andreas Hasenack (ahasenack)]

Queued where? I don't see it in xenial unapproved. If it's just fixing the autopkgtests, not the software-properties code or anything else in debian/*, then no need for a new SRU bug. Just make sure to build it with the appropriate -v parameter to include all changes since 0.96.20.10 (IIRC).

[Andreas Hasenack (ahasenack)]

Ah, software-properties, sorry, I still had update-manager in my mind.

[Andreas Hasenack (ahasenack)]

I just looked at the changes, and I would prefer to have a new SRU bug for those, yes please.

[Chris Halse Rogers (raof)]

Hello Nathan, or anyone else affected,

Accepted software-properties into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.96.20.13 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Nathan Teodosio (nteodosio)]

I installed .13 from proposed.

Ensured that the machine wasn't attached to ubuntu pro with

$ pro status

Launched software-properties-gtk, went to the Ubuntu Pro tab, which stated 'This machine is not covered by an Ubuntu Pro subscription', displayed a 'Enable Ubuntu Pro' button and had the service controls inactive.

Clicked 'Enable Ubuntu Pro' and entered the PIN in ubuntu.com/pro/attach, after some seconds the software-properties UI updated and displayed a green mark and 'Valid token' label, I clicked 'Confirm', entered password at the prompt, the spinner showed up in place of the mark/label, once the attachment job was done the dialog was autoclosed.

The UI then stated 'Ubuntu Pro support is enabled' and under Security 'ESM Infra', 'ESM Apps' and 'Kernel Livepatch' were displayed an enabled, with '$ pro status' output matching the UI.

Enabled and disabled Infra in the UI and confirmed that the 'pro status' changed accordingly.

Clicked 'Disable Ubuntu Pro', got asked for confirmation and password, confirmed that the UI is back to the original state and that 'pro status' confirmed the system wasn't attached to Ubuntu Pro anymore.

The same testcase also succeeded for the 'Or add token manually' option.