[24.04 FEAT] [LDP2024] Upgrade libica to latest version (crypto)

[bugproxy]

Please upgrade libica to newest version 4.3.0 which is planned to be available beginning of February from github:
https://github.com/opencryptoki/libica

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2024-01-25 05:04 EDT-------
@JSCHMIDB: Thanks Joerg, for making the new Libica version 4.3.0 available today!
This is perfectly in time for Noble to upgrade to the new version.

[Alexandre Erwin Ittner (aittner)]

A debdiff to the new version follows attached, changes were:

  * New upstream release LP: #2050024
  * d/libica4.symbols: add new symbols.
  * d/control: Update upstream homepage.
  * d/control: Upgrade Standards-Version to 4.6.2.

There us a test build available in https://launchpad.net/~aittner/+archive/ubuntu/lp2050024-noble1

I also updated the standards-version to current 4.6.2. Comments on relevant items are:

= 4.1.1 =

Pass.

= 4.1.2 =

Fail item 10.4: The shebang at the top of Perl command scripts must be #!/usr/bin/perl. (Previously, this was a ‘should’ rather than a ‘must’.)

    ubuntu@devnoble1:~/libica-noble/libica-4.3.0$ grep -ri "^#\!.*perl.*" .
    ./src/perlasm/s390x.pm:#!/usr/bin/env perl
    ./src/mp.pl:#! /usr/bin/env perl
    ./test/drbg_birthdays_test.pl:#!/usr/bin/env perl

This requisite was reverted in version 4.2.1, so it will pass later.

= 4.1.3 =

Pass.

= 4.1.4 =

Pass.

= 4.1.5 =

Pass.

= 4.2.0 =

Item 4.9 ("The package build should be as verbose as reasonably possible. This means that debian/rules should pass to the commands it invokes options that cause them to produce verbose output."):
Seems ok, all build steps are handled by dh-* so they generate the intended debug messages.

Item 12.7 ("Upstream release notes, when available, should be installed as /usr/share/doc/package/NEWS.gz. Upstream changelogs may be made available as /usr/share/doc/package/changelog.gz.") :
Upstream changelog is not installed at all, but it's a "may"

= 4.2.1 =

Item 10.4 & perl ("The requirement that the shebang at the top of Perl command scripts be #!/usr/bin/perl is relaxed from a ‘must’ to a ‘should’."):

This reverts 4.1.2 and now it passes, no patches needed.

= 4.3.0 =

10.1 Binaries should be stripped using strip --strip-unneeded --remove-section=.comment --remove-section=.note (as dh_strip already does).

10.1 It is no longer suggested nor recommended to use install -s to strip binaries, because it gets several things wrong.

10.2 When stripping shared libraries with strip(1), you should additionally pass --remove-section=.comment --remove-section=.note (as dh_strip already does).

There is ho explicit dh_strip in d/rules bu it is called after build

    make[1]: Leaving directory '/home/ubuntu/libica-noble/libica-4.3.0'
       dh_dwz -a
       dh_strip -a

Binaries are stripped correctly:

    ubuntu@devnoble1:~/libica-noble/libica-utils_4.3.0-0ubuntu1_s390x.dir/usr/bin$ file *
    icainfo: ELF 64-bit MSB pie executable, IBM S/390, version 1 (SYSV), dynamically linked, interpreter /lib/ld64.so.1, BuildID[sha1]=5264342089bebc43043f34d22c2b88bfb5f0579c, for GNU/Linux 3.2.0, stripped
    icainfo-cex: ELF 64-bit MSB pie executable, IBM S/390, version 1 (SYSV), dynamically linked, interpreter /lib/ld64.so.1, BuildID[sha1]=7416ee37024734c9eba078ac44f4e21da60b9ebc, for GNU/Linux 3.2.0, stripped
    icastats: ELF 64-bit MSB pie executable, IBM S/390, version 1 (SYSV), dynamically linked, interpreter /lib/ld64.so.1, BuildID[sha1]=7dd9507e67b21724b18252546059c5d83da9007e, for GNU/Linux 3.2.0, stripped

    ubuntu@devnoble1:~/libica-noble/libica4_4.3.0-0ubuntu1_s390x.dir/usr/lib/s390x-linux-gnu$ ...

[Frank Heimes (fheimes)]

Thanky you Alexandre for the work on the new libica version.

Review check-list:
- changelog looks good with:
  - correct version string
  - code-name
  - all changes listed
  - LP bug referenced
- maintainer field ok
- existing patches got checked, no new ones
- symbols file updates
- build log looks good, no issues
- debdiff looks reasonable
- lintian (-EvIL -pedantic) on and bin DEBs are reasonable (no errors)
- sanity checks are fine, install and upgrade
- LP bug made public
- rdeps checked, and test builds done

The above covers the requested version bump.
On top I noticed two (probably legacy) issues, that I would like to solve with this upload too - if you don't mind:
  * d/libica4.symbols: Add '* Build-Depends-Package: libica-dev' lines to
    solve lintian message 'symbols-file-missing-build-depends-package-field'.
  * d/rules: Set 'DEB_BUILD_MAINT_OPTIONS to hardening=+all' to solve
    lintian message 'hardening-no-bindnow'.
Based on that I've rebuild the package (incl. it's redepends) here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp2050024
and re-validated the above checklist again.

The update looks pretty good now, I think it's ready to be uploaded ...

[Frank Heimes (fheimes)]

Updated package sponsored and uploaded !
Now let's follow the transition on britney ...

Thanks for your contribution, Alexandre!

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "libica_4.2.2-0ubuntu1_4.3.0-0ubuntu1.diff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Frank Heimes (fheimes)]

"ubuntu-sponsors" can be unsubscribed, since this package got already reviewed and sponsored
and it got already built: https://launchpad.net/ubuntu/+source/libica/4.3.0-0ubuntu1
(I'm not able to unsubscribe ubuntu-sponsors from this LP bug)

[Launchpad Janitor (janitor)]

This bug was fixed in the package libica - 4.3.0-0ubuntu1

---------------
libica (4.3.0-0ubuntu1) noble; urgency=medium

  [ Alexandre Erwin Ittner ]
  * New upstream release LP: #2050024
  * d/libica4.symbols: add new symbols.
  * d/control: Update upstream homepage.
  * d/control: Upgrade Standards-Version to 4.6.2.

  [ Frank Heimes ]
  * d/libica4.symbols: Add '* Build-Depends-Package: libica-dev' lines to
    solve lintian message 'symbols-file-missing-build-depends-package-field'.
  * d/rules: Set 'DEB_BUILD_MAINT_OPTIONS to hardening=+all' to solve
    lintian message 'hardening-no-bindnow'.

 -- Alexandre Erwin Ittner <email address hidden> Thu, 25 Jan 2024 15:30:59 +0000

[Frank Heimes (fheimes)]

Package has landed now in -proposed:
libica | 4.3.0-0ubuntu1 | noble-proposed/universe | source
updating status to Fix Committed.